Re: [Gen-art] review of draft-ietf-netmod-syslog-model-21.txt

"Clyde Wildes (cwildes)" <cwildes@cisco.com> Thu, 08 March 2018 21:43 UTC

Return-Path: <cwildes@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 63D34124234; Thu, 8 Mar 2018 13:43:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.531
X-Spam-Level:
X-Spam-Status: No, score=-14.531 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dVNWI4cGohQt; Thu, 8 Mar 2018 13:43:54 -0800 (PST)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B764D127863; Thu, 8 Mar 2018 13:43:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2640; q=dns/txt; s=iport; t=1520545434; x=1521755034; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=z7vsbFKUz0THptT8iP1eD0KYzGyaD/SJGPbd+0GdY2M=; b=SlL63KoYUAhXe8n+dBE/gHEYk77jtrU2J0pHMt3pmEXsyobXascIMygG sSpDNvczKCcy7AHy2iVztSJjJOYAYCCKu6grOUhxo7lWOCdRATWmPY0uS r61C7aVd5fE2tc+VVJ/TSUfDghYJ5EkPBlfMuS+QkUUCnUtbkhMQA3BwD I=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DNAAA6rqFa/5hdJa1eGQEBAQEBAQEBAQEBAQcBAQEBAYNQZm8oCoNGih6NdoICgRaUKYIVCiOFAgIagnAhNBgBAgEBAQEBAQJrJ4UkBiMEDUUQAgEIEAQGAiYCAgIwFRACBAENBYUZD6t4gWw6hHGDdoITBYEOhCeCLoFWgWYpgwSDLgKBcTgCgk8wgjIEiDSSGwkChkeKH4FjhDSISol5hycCERMBgSsBHjiBUnAVGQQdKgGCGIRId4ongRcBAQE
X-IronPort-AV: E=Sophos;i="5.47,442,1515456000"; d="scan'208";a="363464750"
Received: from rcdn-core-1.cisco.com ([173.37.93.152]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2018 21:43:53 +0000
Received: from XCH-ALN-011.cisco.com (xch-aln-011.cisco.com [173.36.7.21]) by rcdn-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id w28LhrSI032741 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 8 Mar 2018 21:43:53 GMT
Received: from xch-aln-015.cisco.com (173.36.7.25) by XCH-ALN-011.cisco.com (173.36.7.21) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 8 Mar 2018 15:43:53 -0600
Received: from xch-aln-015.cisco.com ([173.36.7.25]) by XCH-ALN-015.cisco.com ([173.36.7.25]) with mapi id 15.00.1320.000; Thu, 8 Mar 2018 15:43:52 -0600
From: "Clyde Wildes (cwildes)" <cwildes@cisco.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-netmod-syslog-model.all@ietf.org" <draft-ietf-netmod-syslog-model.all@ietf.org>
Thread-Topic: review of draft-ietf-netmod-syslog-model-21.txt
Thread-Index: AQHTtNTGp7H6M0OJOUmjK3l1ntPOw6PHSAQA
Date: Thu, 08 Mar 2018 21:43:52 +0000
Message-ID: <B01E5F97-0D14-400E-AD1F-552C76C68518@cisco.com>
References: <201803052227.w25MRHkB011235@givry.fdupont.fr>
In-Reply-To: <201803052227.w25MRHkB011235@givry.fdupont.fr>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.20.145.3]
Content-Type: text/plain; charset="utf-8"
Content-ID: <A1F3274CD220474E8A03995FD3BEB7B4@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/lYcRt-H0499Ctp24LZNbSZrqP8Q>
Subject: Re: [Gen-art] review of draft-ietf-netmod-syslog-model-21.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2018 21:43:56 -0000

Francis,

Thanks for your review. My comments below…

On 3/5/18, 2:53 PM, "Francis Dupont" <Francis.Dupont@fdupont.fr> wrote:

    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    
    Document: draft-ietf-netmod-syslog-model-21.txt
    Reviewer: Francis Dupont
    Review Date: 20180225
    IETF LC End Date: 20180228
    IESG Telechat date: unknown
    
    Summary: Ready
    
    Major issues: None
    
    Minor issues: None
    
    Nits/editorial comments: 
    (I took my notes on version 21 but I have version 23 in front of me)
    
     - ToC page 2 and 6 page 27 (title): Acknowledgements -> Acknowledgments

[clw] Accepted
    
     - 1 page 3: acknowledgement -> acknowledgement

[clw] Accepted
    
     - 4.1 page 10: do the same than 1.1 page 3: refer to RFC8174 too
      for keywords.

[clw] Accepted 
  
     - 4.1 page 18 (advanced-compare): spectify -> specify

[clw] Accepted
    
     - 4.1 page 23 (remote transport and tls) (twice):
      specified: an ipv4 address, an ipv6 address, ipv4->IPv4 and ipv6->IPv6

[clw] one address is for the UDP case and the other is for the TLS case. I think this this is ok.
    
     - 6 page 27: there is no "and" between the two last names and no
      final dot so I am afraid the list was truncated (BTW obviously iy is
      not the case but please add a final dot, i.e.:
      Aleksandr Zhdankin -> Aleksandr Zhdankin.

[clw] Accepted.

Thanks,

Clyde
    
    Note I trust the Yang tools to have checked the syntax.
    
    Regards
    
    Francis.Dupont@fdupont.fr