Re: [Gen-art] Review of draft-ietf-6tisch-minimal-17

Brian E Carpenter <brian.e.carpenter@gmail.com> Wed, 04 January 2017 22:34 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E7101296DE; Wed, 4 Jan 2017 14:34:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M3JiBTXeCX9J; Wed, 4 Jan 2017 14:34:44 -0800 (PST)
Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3566126B6D; Wed, 4 Jan 2017 14:34:43 -0800 (PST)
Received: by mail-pg0-x244.google.com with SMTP id b1so38474485pgc.1; Wed, 04 Jan 2017 14:34:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=r5dER9mgDmSFOI8wj5y/+2R7HaxYQQvQQU6huHo/ZmU=; b=ilxLUMoCJlToFESxKN+OJcPy+1sw6bcGe+DktV2tOl4b875IHgYU2qhIl76qFPjCF6 UUICSWVfSg8I5IQqPPdq5WwWp5TNOBXw/DFXfzK2wEGuHXQqHTfrI7K9XSf+GJ33dplq dg6WdUeoAsq3rssG5xXIb2cLtzEccvnjvudf2b5fy6LhiA8La3hnpKqI5w0NWemQbSIo eQFEa9btwWnDHAY+D8WNPI5ikqmLphAtiqH+OMioEEJ3gcwycEafHZTEVEH81FPQQCZX +t1zesAV5Vq1O6om4dh21/mzUjG368gbCWxwYQrMFPY4mm/77z+kPYz5gfOTgLw6GdOZ BeGg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=r5dER9mgDmSFOI8wj5y/+2R7HaxYQQvQQU6huHo/ZmU=; b=an6MwA7Av/KYs+5D4KmsToOf6ESXgStnjvBOVOttyChd90HUCTtqQ2v06WagZ6x55s VbDyUXT4pQPG5D5J3KSZfB10biTeHSbqW2CngVt/MHT5J/ma7+aHiLAGh48vofKWiVdA pYWgkTrCAVUX3lLowrTiS4rTJCNGQuZCo36inZey8qQFQvDIPq8P9yaHbnCoNP1iOYkn V8as6FuKZ3XhvjC94FS2sIHGh8uZFiSg3l/Be2ObpbIBbCd5dc0NKgDfqInhyk55St22 7djCCJOocNEfQvI2KZDnLVdicRvGj10PTiSjiNO3hL9etZQjwgWnsnKI0RxKWmDamcB1 dAng==
X-Gm-Message-State: AIkVDXJmWU/if+2v8oLo9weSzCOjwqpkv+Wt7h0NyoOkrdEXpnKMj+ci90tddot+F3sokQ==
X-Received: by 10.84.225.148 with SMTP id u20mr135894275plj.93.1483569283276; Wed, 04 Jan 2017 14:34:43 -0800 (PST)
Received: from [192.168.178.21] ([118.148.113.183]) by smtp.gmail.com with ESMTPSA id b71sm149043517pfj.62.2017.01.04.14.34.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2017 14:34:42 -0800 (PST)
To: Thomas Watteyne <thomas.watteyne@inria.fr>
References: <148140959184.3857.2236566242217564901.idtracker@ietfa.amsl.com> <CADJ9OA8vju=Y13u8EtfsrpT0Kcaf4X-TWzmgfJ=oKkWo+pdxWw@mail.gmail.com> <CADJ9OA_q391_4thKKsXnTQw1gyS3vp+8-CRPUwDqqCzoNKZMDQ@mail.gmail.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
Message-ID: <3b1ec831-33b1-91ee-d380-1315cb7a3f81@gmail.com>
Date: Thu, 05 Jan 2017 11:34:44 +1300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <CADJ9OA_q391_4thKKsXnTQw1gyS3vp+8-CRPUwDqqCzoNKZMDQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/luTEg4qtjY64qDC2NDFrLJ_qeoY>
Cc: gen-art@ietf.org, "6tisch@ietf.org" <6tisch@ietf.org>, draft-ietf-6tisch-minimal.all@ietf.org
Subject: Re: [Gen-art] Review of draft-ietf-6tisch-minimal-17
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2017 22:34:46 -0000

Hi Thomas,

The responses to my comments almost all look fine to me. Just one point,
on MINOR COMMENT 4 (slide 8):

"Shouldn't this also say that this value MUST NOT be used in operational networks?"

We've seen many cases over the years of informal values making it into shipped
products... generally a Bad Thing. But with my lack of IEEE802.15.4 expertise,
I really don't know whether it matters in this case. Whatever the WG decides
is good, as long as the point is considered.

I hope the interim goes well, it is too far out of my time zone to attend!

Thanks
   Brian

On 05/01/2017 03:43, Thomas Watteyne wrote:
> Brian, all,
> 
> We have discussed the possible resolutions to your comments with Xavi. I
> have captured those in a slideset [1] to be presented at this Friday's
> interim meeting [2].
> 
> Early comments about the discussions and proposed resoltuion in the
> slideset, in preparation for their presentation on Friday, welcome.
> 
> Thomas
> 
> [1]
> https://bitbucket.org/6tisch/meetings/src/master/170106_webex/slides_170106_webex_b_minimal_brian.ppt?fileviewer=file-view-default
> [2] https://www.ietf.org/mail-archive/web/6tisch/current/msg05106.html
> 
> On Wed, Jan 4, 2017 at 1:38 PM, Thomas Watteyne <thomas.watteyne@inria.fr>
> wrote:
> 
>> Brian,
>> Just a quick admin update that the authors have taken your comments into
>> account, which will be integrated in -18.
>> We will discuss the proposed resolutions at an interim meeting this Friday
>> and publish it next week.
>> Thomas
>>
>> On Sat, Dec 10, 2016 at 11:39 PM, Brian Carpenter <
>> brian.e.carpenter@gmail.com> wrote:
>>
>>> Reviewer: Brian Carpenter
>>> Review result: Almost Ready
>>>
>>> Gen-ART Last Call review of draft-ietf-6tisch-minimal-17
>>>
>>> I am the assigned Gen-ART reviewer for this draft. The General Area
>>> Review Team (Gen-ART) reviews all IETF documents being processed
>>> by the IESG for the IETF Chair.  Please treat these comments just
>>> like any other last call comments.
>>>
>>> For more information, please see the FAQ at
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>
>>> Document: draft-ietf-6tisch-minimal-17.txt
>>> Reviewer: Brian Carpenter
>>> Review Date: 2016-12-11
>>> IETF LC End Date: 2016-12-20
>>> IESG Telechat date: 2017-01-05
>>>
>>> Summary: Almost Ready
>>> --------
>>>
>>> Comment:
>>> --------
>>>
>>> Although I found some issues, this is a good document which is mainly
>>> very clear. I was not in a position to check IEEE802.15.4 details.
>>>
>>> It's too late now, but judging by the shepherd's writeup, this draft
>>> would have been an excellent candidate for an Implementation Status
>>> section under RFC 6982.
>>>
>>> Major Issues:
>>> -------------
>>>
>>> I was very confused for several pages until I went back and read this
>>> again:
>>>
>>>>   This specification defines operational parameters and procedures
>>> for
>>>>   a minimal mode of operation to build a 6TiSCH Network.  The
>>> 802.15.4
>>>>   TSCH mode, the 6LoWPAN framework, RPL [RFC6550], and its Objective
>>>>   Function 0 (OF0) [RFC6552], are used unmodified.
>>>
>>> Then I realised that there is some very basic information missing at
>>> the beginning
>>> of the Introduction. That little phrase "the 6LoWPAN framework" seems
>>> to be the clue.
>>> What is the 6LoWPAN framework? Which RFCs? I'm guessing it would be
>>> RFC4944, RFC6282
>>> and RFC6775, but maybe not. In any case, the very first sentence of
>>> the Introduction
>>> really needs to be a short paragraph that explains in outline, with
>>> citations, how a
>>> 6TiSCH network provides IPv6 connectivity over NBMA. With that, the
>>> rest of the document
>>> makes sense.
>>>
>>> But related to that, the Abstract is confusing in the same way:
>>>
>>>> Abstract
>>>>
>>>>   This document describes a minimal mode of operation for a 6TiSCH
>>>>   Network.  It provides IPv6 connectivity over a Non-Broadcast
>>> Multi-
>>>>   Access (NBMA) mesh...
>>>
>>> "It" is confusing since it seems to refer to this document, which
>>> hardly
>>> mentions IPv6 connectivity. I suggest s/It/6TiSCH/.
>>>
>>> As far as I know a Security Considerations section is still always
>>> required. I understand
>>> that this document discusses security in detail, but that doesn't
>>> cancel the
>>> requirement (https://tools.ietf.org/html/rfc3552#section-5).
>>>
>>> Minor issues:
>>> -------------
>>>
>>>> 4.4.  Timeslot Timing
>>> ...
>>>>   The RX node needs to send the first bit after the
>>>>   SFD of the MAC acknowledgment exactly tsTxAckDelay after the end
>>> of
>>>>   the last byte of the received packet.
>>>
>>> I don't understand "exactly". Nothing is exact - there is always clock
>>> jitter.
>>> Shouldn't there be a stated tolerance rather than "exactly"?
>>>
>>>> 4.5.  Frame Formats
>>>>
>>>>   The following sections detail the RECOMMENDED format of link-layer
>>>>   frames of different types.  A node MAY use a different formats
>>> (bit
>>>>   settings, etc)...
>>>
>>> Doesn't this create an interoperability issue for independent
>>> implementations?
>>> How can you mix and match implementations that use variants of the
>>> frame format?
>>> This seems particularly strange:
>>>
>>>>   The IEEE802.15.4 header of BEACON, DATA and ACKNOWLEDGMENT frames
>>>>   SHOULD include the Source Address field and the Destination
>>> Address
>>>>   field.
>>>
>>> How will it work if some nodes omit the addresses?
>>>
>>>> 4.6.  Link-Layer Security
>>> ...
>>>>   For early interoperability testing, value 36 54 69 53 43 48 20 6D
>>> 69
>>>>   6E 69 6D 61 6C 31 35 ("6TiSCH minimal15") MAY be used for K1.
>>>
>>> Shouldn't this also say that this value MUST NOT be used in
>>> operational networks?
>>>
>>> Nits:
>>> -----
>>>
>>>> 1.  Introduction
>>>>
>>>>   A 6TiSCH Network provides IPv6 connectivity...
>>>
>>> I would expect to see a reference to [RFC2460] right there.
>>>
>>> Outdated reference: draft-ietf-6lo-paging-dispatch has been published
>>> as RFC 8025
>>>
>>>
>>
>>
>> --
>> _______________________________________
>>
>> Thomas Watteyne, PhD
>> Research Scientist & Innovator, Inria
>> Sr Networking Design Eng, Linear Tech
>> Founder & co-lead, UC Berkeley OpenWSN
>> Co-chair, IETF 6TiSCH
>>
>> www.thomaswatteyne.com
>> _______________________________________
>>
> 
> 
>