[Gen-art] Gen-ART Telechat review: draft-ietf-tls-dtls-heartbeat-03.txt

Mary Barnes <mary.ietf.barnes@gmail.com> Fri, 28 October 2011 15:56 UTC

Return-Path: <mary.ietf.barnes@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 35FDF21F869E for <gen-art@ietfa.amsl.com>; Fri, 28 Oct 2011 08:56:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.665
X-Spam-Level:
X-Spam-Status: No, score=-102.665 tagged_above=-999 required=5 tests=[AWL=0.933, BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qBA4i+f8XR5G for <gen-art@ietfa.amsl.com>; Fri, 28 Oct 2011 08:56:04 -0700 (PDT)
Received: from mail-vw0-f44.google.com (mail-vw0-f44.google.com [209.85.212.44]) by ietfa.amsl.com (Postfix) with ESMTP id 90B4621F8634 for <gen-art@ietf.org>; Fri, 28 Oct 2011 08:56:04 -0700 (PDT)
Received: by vws5 with SMTP id 5so4205044vws.31 for <gen-art@ietf.org>; Fri, 28 Oct 2011 08:56:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=I9V2TqXTrQl3lR0sO1tnuep6wym10s/UrznReLIBW2o=; b=k+vyHufq5dAmo9ao7P+ZEX8obJBbkCqNO34lTpMK+M4fBkjJnymFgzqkA3eXjHYQSk 2RTGc1xyCfDBqGz6NJXxEbW0JTgBrT98N6HW9/rnq+YnIcEmfwbKdcsEYvtblvYoqY57 iDnOJ9hvd6YF/XPJdw4Xbg+2iplNiWotnccj8=
MIME-Version: 1.0
Received: by 10.52.22.81 with SMTP id b17mr721275vdf.87.1319817362458; Fri, 28 Oct 2011 08:56:02 -0700 (PDT)
Received: by 10.52.169.164 with HTTP; Fri, 28 Oct 2011 08:56:02 -0700 (PDT)
Date: Fri, 28 Oct 2011 10:56:02 -0500
Message-ID: <CAHBDyN5L9a6UY6seczmw=S_Wmu3YwZnbJ+dhtqw2D95ZEqva=Q@mail.gmail.com>
From: Mary Barnes <mary.ietf.barnes@gmail.com>
To: draft-ietf-tls-dtls-heartbeat.all@tools.ietf.org
Content-Type: multipart/alternative; boundary="20cf307812dc0ec75c04b05ded15"
Cc: gen-art@ietf.org
Subject: [Gen-art] Gen-ART Telechat review: draft-ietf-tls-dtls-heartbeat-03.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Oct 2011 15:56:05 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
< http://wiki.tools.ietf.org/**area/gen/trac/wiki/GenArtfaq<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>.

Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-tls-dtls-heartbeat-03.txt
Reviewer:  Mary Barnes
Review Date:  28 Oct 2011
IETF LC Date:  18 Oct 2011
IESG Telechat Date:  3 Nov 2011

Summary:  Ready with editorial comments

Editorial:

1) Section 2 (1st P, last sentence).  The following sentence needs some work
(there's a missing noun before the SHOULD) - I suggest something like the
following:
OLD:
If an endpoint has indicated peer_not_allowed_to_send and receives a
HeartbeatRequest message SHOULD drop the message silently and MAY
send an unexpected_message Alert message.

NEW:
If an endpoint that has indicated peer_not_allowed_to_send receives a
HeartbeatRequest message, the endpoint SHOULD drop the message silently and
MAY send an unexpected_message Alert message.

2) Section 3: Should the "has to be" in this sentence be a MUST?
   Whenever a HeartbeatRequest message is
   received, it has to be answered with a corresponding
   HeartbeatResponse message.