Re: [Gen-art] review of draft-ietf-trill-centralized-replication-10.txt

"Susan Hares" <shares@ndzh.com> Tue, 12 December 2017 17:05 UTC

Return-Path: <shares@ndzh.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80E7D1294C7; Tue, 12 Dec 2017 09:05:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.946
X-Spam-Level:
X-Spam-Status: No, score=0.946 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DOS_OUTLOOK_TO_MX=2.845, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KGjkFfsPSuPd; Tue, 12 Dec 2017 09:05:40 -0800 (PST)
Received: from hickoryhill-consulting.com (50-245-122-97-static.hfc.comcastbusiness.net [50.245.122.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8D9F312871F; Tue, 12 Dec 2017 09:05:37 -0800 (PST)
X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=174.230.30.174;
From: Susan Hares <shares@ndzh.com>
To: 'Francis Dupont' <Francis.Dupont@fdupont.fr>, gen-art@ietf.org
Cc: draft-ietf-trill-centralized-replication.all@ietf.org
References: <201712111629.vBBGTxIp043810@givry.fdupont.fr>
In-Reply-To: <201712111629.vBBGTxIp043810@givry.fdupont.fr>
Date: Tue, 12 Dec 2017 12:05:34 -0500
Message-ID: <066001d3736b$6d0d9d20$4728d760$@ndzh.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQHXUVStKixNGudtSf1nEuiMvw0/1qM4NBzg
Content-Language: en-us
X-Authenticated-User: skh@ndzh.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/naCjULI7oXnYFRiDzZimzKXNZn8>
Subject: Re: [Gen-art] review of draft-ietf-trill-centralized-replication-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2017 17:05:42 -0000

Francis:

Thank you for reviewing this document. 

Susan Hares 
WG Chair 

-----Original Message-----
From: Francis Dupont [mailto:Francis.Dupont@fdupont.fr] 
Sent: Monday, December 11, 2017 11:30 AM
To: gen-art@ietf.org
Cc: draft-ietf-trill-centralized-replication.all@ietf.org
Subject: review of draft-ietf-trill-centralized-replication-10.txt

I am the assigned Gen-ART reviewer for this draft. The General Area Review
Team (Gen-ART) reviews all IETF documents being processed by the IESG for
the IETF Chair.  Please treat these comments just like any other last call
comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-trill-centralized-replication-10.txt
Reviewer: Francis Dupont
Review Date: 20171209
IETF LC End Date: 20171212
IESG Telechat date: unknown

Summary: Ready with Issues

Major issues: None

Minor issues: C-nickname is used before being defined

Nits/editorial comments: 
 - Abstract page 1: please expand the RPF abbrev

 - Abstract page 1 and 1 page 3: Mutlicast -> Multicast

 - ToC page 2 and 3 title page 5:
  Centralized Replication Solution Overview -> Centralized replication
  solution overview
  (mainly for consistency)

 - ToC page 2 and 6 title page 8: a edge group -> an edge group
  (It seems both are accepted?)

 - ToC page 2 and 9 title page 12: I have a little concern with the
  CMT abbrev which BTW is not in the RFC Editor list
  (https://www.rfc-editor.org/materials/abbrev.expansion.txt)
  I suggest to add "(RFC 7783)" after CMT

 - ToC page 3 and 10 title page 13:
  Network Upgrade Analysis -> Network upgrade analysis
  (still consistency)

 - 1 page 3: at the first read it was not obvious that RBv is just the
  notation for a virtual RBridge. I suggest to do the same than for RBn,
  i.e., to change the first occurrence from RBv to (RBv).

 - 1 page 3: my US English spell checker does not accept learnt
  (it wants learned ???)

 - 2 page 4: please move from RFC 2119 to its update RFC 8174

 - 2 page 4: LAALP -Local -> LAALP - Local

 - 3 page 5 title: cf ToC comment

 - 3 page 5: " BUM packet should be..." an example of a lower case
  "should" which can take benefit of RFC 8174 (vs RFC 2119). Note
  there are two other "should"s next page and a "may" in 4 (and other
  lower case keywords).

 - 3 page 6: C-nickname is used without explanation of what it is
  (the explanation is in 9 page 12 so far later). Some words and/or
  a forward reference should solve the issue.

 - 8 page 11 (last line): nodes/ multiple -> nodes / multiple

 - 9 page 12 title: cf ToC comment

 - 9 page 12: CMT -> Coordinated Multicast Trees (CMT)
  (at the first occurrence, i.e., first line after figure 2)

 - 9 page 12: the definition of C-nickname is here.
  BTW you use both C-flag and C-nickname flag, the second is not
  very correct from a language point of view but is very clear
  technically so I shan't object if you keep it.

 - 10 page 13 title: cf ToC comment

 - 11 page 13: psudo -> pseudo

 - Authors' Addresses page 17 (two occurrences): China -> PR China
  (or you can switch all countries to ISO IS 3166 two letter codes)

Regards

Francis.Dupont@fdupont.fr