Re: [Gen-art] [Idr] Genart last call review of draft-ietf-idr-rfc5575bis-20

Christoph Loibl <c@tix.at> Fri, 17 April 2020 07:43 UTC

Return-Path: <c@tix.at>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 610483A0FD1; Fri, 17 Apr 2020 00:43:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=tix.at
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pQZmKB76J9oy; Fri, 17 Apr 2020 00:43:18 -0700 (PDT)
Received: from mail.fbsd.host (mail.fbsd.host [IPv6:2001:858:58::22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20DD13A0FB8; Fri, 17 Apr 2020 00:43:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tix.at; s=rev1; h=References:To:Cc:In-Reply-To:Date:Subject:Mime-Version:Content-Type :Message-Id:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dguKkT6L0tRJg3kunZwNmQknMaJTBKin7B10aaGWBVI=; b=e7+SfkoI/ZFkEAWq6m3CUTus/g MRgURoxg07BnVD+/4xyPAtqPigO3iL3emBZ2lMXKDNFiSmqcx60tXvwL2CLyO3qJ6M8PYmmsvyB49 jB343HTslCgCZVGCUJmHUgsO01iPlrvFcQE5C+1aT6PAukp1ncUldOyUOWkD7b4vJObR51Dvco1mc tJ3TtaQ6HjNv3D2vk8cUsDSxxS5ltTkoXsjN6MnBH4oT1vu5Rwfx2EHRYYNUdCfeULh8LXg9H3q1h 4vVS91NM0prrv/bgitv8DHOMXyijKa31ja1ESd4PH76a0kSHP86LUeFu991r/HUyUieLANA0Eh5K/ xD4+kw3w==;
Received: from 213-225-13-127.nat.highway.a1.net ([213.225.13.127] helo=[192.168.88.217]) by mail.fbsd.host with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from <c@tix.at>) id 1jPLec-0001M5-0o; Fri, 17 Apr 2020 09:43:14 +0200
From: Christoph Loibl <c@tix.at>
Message-Id: <42014AE1-D058-486E-9E17-475D07A91885@tix.at>
Content-Type: multipart/alternative; boundary="Apple-Mail=_28C4CD40-E6D6-437F-8AFF-EDA123E64E81"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Date: Fri, 17 Apr 2020 09:43:12 +0200
In-Reply-To: <158629580378.13606.6350807287790835622@ietfa.amsl.com>
Cc: gen-art@ietf.org, last-call@ietf.org, draft-ietf-idr-rfc5575bis.all@ietf.org, IDR List <idr@ietf.org>
To: Gyan Mishra <hayabusagsm@gmail.com>
References: <158629580378.13606.6350807287790835622@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3608.60.0.2.5)
X-Scanned-By: primary on mail.fbsd.host (78.142.178.22); Fri, 17 Apr 2020 09:43:14 +0200
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/noETQ_KOLJtfORvUwSjI5L83FT0>
Subject: Re: [Gen-art] [Idr] Genart last call review of draft-ietf-idr-rfc5575bis-20
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2020 07:43:22 -0000

Hi Gyan,

Thanks for your review. According to your review I made the following changes to the document which is available now as revision -22:

> On 07.04.2020, at 23:43, Gyan Mishra via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Gyan Mishra
> Review result: Ready with Nits
> 
> Reviewer: Gyan Mishra
> Review result: Ready with Minor Issues
> 
> Minor issues:
> I am familiar with BGP Flow specification and would like to recommend some
> verbiage that may help in the introduction as far as explaining how BGP flow
> spec works.  Ssince the introduction has been re-written with this update, this
> could be a possible addition to the draft.
> 
> This could be placed at the end of the introduction if desired.
> BGP flow specification is a client-server model that allows for a more granular
> approach to DDOS mitigation than its predecessor, “Remotely Triggered Blackhole
> (RTBF) which tagged a prefix with a community and sent it do a discard next
> hop.  BGP flow spec has two main components, the “controller” being the BGP
> speaker device which acts as the server side, which injects the new flowspec
> entry, and the client side which is the BGP speaker devices that receives the
> flowspec NLRI and acts on the instruction to match a particular flow with Layer
> 3 and Layer 4 parameters and then implements the hardware forwarding action
> requested.

<-- 
Tracked via issue #163: https://github.com/stoffi92/rfc5575bis/issues/163

I do not agree that BGP flowspec is a client-server model -only-. We can propagate this NLRI over administrative domain borders as we do with IP routing information, it follows the same mechanisms. We see such solutions being deployed in the internet as inter provider DDoS solutions.

We actually had a paragraph in the darft that was explaining the advantages over other approaches like RTBF but this has been removed because it was pointed out that it is not relevant to the spec to justify a well deployed technology.
-->


> Nits/editorial comments:
> 7.  Traffic Filtering Actions
>   This document defines a minimum set of Traffic Filtering Actions that
>   it standardizes as BGP extended community values [RFC4360]
> 
>   Any mention of [RFC4360] should be updated with [RFC7153] IANA Registries
>   for BGP Extended Communities.
> 

<-- 
Tracked via issue #164: https://github.com/stoffi92/rfc5575bis/issues/164
Commits mentions:
    https://github.com/stoffi92/rfc5575bis/commit/31f0ac79b7cd998aa2750fd376dc148d7a590369
    https://github.com/stoffi92/rfc5575bis/commit/7aadadcdf55a1f5a7d5c1822070b862247dfaead

Removed the "values" statement (as suggested by Alvaro) from the draft to make clear we are not talking about particular values but about  Extended Communities as specified in RFC4360.
s/standardizes as BGP extended community values [RFC4360]/standardizes as BGP extended communities [RFC4360]/

-->

Cheers 
Christoph

-- 
Christoph Loibl
c@tix.at | CL8-RIPE | PGP-Key-ID: 0x4B2C0055 | http://www.nextlayer.at