Re: [Gen-art] Gen-ART Last Call review of draft-ietf-tsvwg-rfc4960-errata-06
Gorry Fairhurst <gorry@erg.abdn.ac.uk> Mon, 04 June 2018 11:51 UTC
Return-Path: <gorry@erg.abdn.ac.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3605412D943; Mon, 4 Jun 2018 04:51:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ps7a_CRTDGge; Mon, 4 Jun 2018 04:51:30 -0700 (PDT)
Received: from pegasus.erg.abdn.ac.uk (pegasus.erg.abdn.ac.uk [139.133.204.173]) by ietfa.amsl.com (Postfix) with ESMTP id 9661C124319; Mon, 4 Jun 2018 04:51:30 -0700 (PDT)
Received: from oa-edu-166-99.wireless.abdn.ac.uk (oa-edu-166-99.wireless.abdn.ac.uk [137.50.166.99]) by pegasus.erg.abdn.ac.uk (Postfix) with ESMTPSA id BF0821B00127; Mon, 4 Jun 2018 12:51:29 +0100 (BST)
To: Christer Holmberg <christer.holmberg@ericsson.com>, Paul Kyzivat <pkyzivat@alum.mit.edu>, "draft-ietf-tsvwg-rfc4960-errata.all@ietf.org" <draft-ietf-tsvwg-rfc4960-errata.all@ietf.org>
Cc: General Area Review Team <gen-art@ietf.org>
References: <9c54eccb-82f2-e135-39af-6bf32824b648@alum.mit.edu> <D73AC219.30C7F%christer.holmberg@ericsson.com> <D73ADF2B.30D2E%christer.holmberg@ericsson.com> <21073937-e22d-2b13-ffc2-aec9e14fd3bb@erg.abdn.ac.uk> <D73AE907.30D50%christer.holmberg@ericsson.com>
From: Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Message-ID: <7272c2b5-8834-62ba-8fa9-32c97052e424@erg.abdn.ac.uk>
Date: Mon, 04 Jun 2018 12:51:29 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <D73AE907.30D50%christer.holmberg@ericsson.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/nq0yFcEVkiIhT9Fu-czhlHLzVlM>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-tsvwg-rfc4960-errata-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jun 2018 11:51:34 -0000
Hi On 04/06/2018 11:13, Christer Holmberg wrote: > Hi Gorry, > > ... > >> The information in this document does not update RFC4640 or the Errata >> to that specification. The document is instead provided as input to >> preparation of a new document that is expected to be a standards-track >> replacement for RFC4960. If approved, the replacement document will >> incorporate the updates described here and any other changes needed to >> allow this to progress this specification along the standards track. > I am ok with the two first sentences. > > But, I don’t think you can make the last sentence. This document cannot > normatively define text for the replacement document, or assume that > everything will be incorporated: the WG will have to agree on what goes > into the replacement document once it has been added to the charter etc, > using normal IETF procedures. And it wouldn't say those exact words of course! If I carefully composed actual text, it would be IETF-compliant;-) Gorry > Regards, > > Christer > > > >>>> On 03/06/18 21:59, "Gen-art on behalf of Paul Kyzivat" >>>> <gen-art-bounces@ietf.org on behalf of pkyzivat@alum.mit.edu> wrote: >>>> >>>>> [[INCOMPLETE, NOT READY TO SEND. PLEASE IGNORE]] >>>>> >>>>> I am the assigned Gen-ART reviewer for this draft. The General Area >>>>> Review Team (Gen-ART) reviews all IETF documents being processed by >>>>> the >>>>> IESG for the IETF Chair. Please treat these comments just like any >>>>> other >>>>> last call comments. For more information, please see the FAQ at >>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >>>>> >>>>> Document: draft-ietf-tsvwg-rfc4960-errata-06 >>>>> Reviewer: Paul Kyzivat >>>>> Review Date: 2018-06-03 >>>>> IETF LC End Date: 2018-06-04 >>>>> IESG Telechat date: ? >>>>> >>>>> Summary: >>>>> >>>>> This draft is on the right track but has open issues, described in the >>>>> review. >>>>> >>>>> Issues: >>>>> >>>>> Major: 1 >>>>> Minor: 2 >>>>> Nits: 1 >>>>> >>>>> 1) MAJOR: >>>>> >>>>> The format of this document disturbs me. According to the abstract: >>>>> >>>>> ... This >>>>> document provides deltas to RFC4960 and is organized in a time >>>>> ordered way. The issues are listed in the order they were brought >>>>> up. Because some text is changed several times the last delta in >>>>> the >>>>> text is the one which should be applied. >>>>> >>>>> This format makes the document hard to deal with. A developer who >>>>> wants >>>>> to implement sctp with some or all of the errata fixes will want to >>>>> work >>>> >from a variant of 4960 that incorporates all of those fixes - a bis. >>>> But >>>>> it isn't clear how this document helps with that. I don't think you >>>>> can >>>>> start with 4960 and simply apply all the deltas sequentially, because >>>>> overlapping changes won't work right. >>>>> >>>>> A developer won't be interested in the order in which errata were >>>>> reported. An actual bis document would be more useful to a developer >>>>> than this format. Is that not being done because doing so would be >>>>> more >>>>> difficult? Or because it isn't yet certain that these are the correct >>>>> fixes? >>>>> >>>>> I think you should give some serious consideration of the most >>>>> suitable >>>>> form for this document, in the context of how it is intended to be >>>>> used. >>>>> >>>>> 2) MINOR (maybe MAJOR): >>>>> >>>>> Discovering where one change is impacted by another change is hard. >>>>> >>>>> I dug into the details of the document to understand how many places >>>>> there are actually overlaps between the changes in multiple sections. >>>>> (It took a lot of work to do this.) I found five of these: >>>>> >>>>> - 3.1 / 3.23 >>>>> - 3.3 / 3.43 >>>>> - 3.5 / 3.10 >>>>> - 3.6 / 3.23 >>>>> - 3.24 / 3.32 >>>>> >>>>> (I don't guarantee that this list is exhaustive.) >>>>> >>>>> Of these, I think only one (3.1/3.23) explicitly indicates the >>>>> conflict, >>>>> and it only indicates it within 3.23. >>>>> >>>>> Most of the changes don't have any conflicts. And some of the >>>>> conflicts >>>>> could be removed by being more precise in indicating the change being >>>>> made. In cases where this isn't possible, the presence of the conflict >>>>> should be indicated in each section that has a conflict, with cross >>>>> references. IOW, shift the burden of detecting conflicts from the >>>>> reader >>>>> to the document. >>>>> >>>>> 3) MINOR: >>>>> >>>>> Errata Tracking: Apparently each subsection of section 3 covers one >>>>> erratum. But the errata numbers are not mentioned. Each section ought >>>>> to >>>>> reference the errata number it responds to. >>>>> >>>>> 4) NIT: >>>>> >>>>> In section 3.35 (DSCP Changes) the change to section 10.1 isn't >>>>> properly >>>>> indicated. It shows 'Old text' twice rather than 'Old text' and 'New >>>>> text'. >>>>> >>>>> _______________________________________________ >>>>> Gen-art mailing list >>>>> Gen-art@ietf.org >>>>> https://www.ietf.org/mailman/listinfo/gen-art >>>> _______________________________________________ >>>> Gen-art mailing list >>>> Gen-art@ietf.org >>>> https://www.ietf.org/mailman/listinfo/gen-art >>
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Spencer Dawkins at IETF
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Gorry Fairhurst
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Michael Tuexen
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Alissa Cooper
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Gorry Fairhurst
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Gorry Fairhurst
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Christer Holmberg
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Spencer Dawkins at IETF
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat