Re: [Gen-art] review of draft-ietf-sidr-slurm-06.txt

Alissa Cooper <alissa@cooperw.in> Wed, 04 April 2018 18:01 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C01C5126CD6; Wed, 4 Apr 2018 11:01:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=NeqCf5on; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=kHIiKx33
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gstLyu-EKCxX; Wed, 4 Apr 2018 11:01:16 -0700 (PDT)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 733AB12D77B; Wed, 4 Apr 2018 11:01:13 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CFCB321AF7; Wed, 4 Apr 2018 14:01:12 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 04 Apr 2018 14:01:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=IREw/e+8LvkXIzkVxyOv4kPA8/gtn 24dsx9YJcqUwtU=; b=NeqCf5on+NZjJpHC+PueSvHBBUAscBYZNzIfQOgOu3bg5 u33CXA9SQpN8sMzHCQBfJtXu1VSoFbeELyg1r9jZnfcBwo2DfhRPGbeFomA0h6Ay et6/SlDDT4pwunfYIStASiJFLoEReCuicYQt0yIhfhfRSXQreDgtN8E6OuW+gMLZ hmFhOz0BXcUWjA1souwKYeQuS+5iJ/xvumQsaalBawxMLubnue7+iwKXXIH01jTj N7sByqYhOJQwYG5AEGrJ0AgNiG0ygVPqTA5U5RjOBgcYylOeIQrs+8HZCH9ATE27 2v0NE3TbSCPsduGWzrF9gdFvpdmrf5jgOd5C4Cnnw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=IREw/e +8LvkXIzkVxyOv4kPA8/gtn24dsx9YJcqUwtU=; b=kHIiKx33p4HWDXfgUMcIcb ljjJo4N/RuDvPwYzzfnQmOwQ4N0j+oXHKt03nb4FGgZuim2/kEzBv4gSSAKz8qd8 Q6ZXaMFruTJDTzJXFF0Bw3jYChrNxoRZE+HHtMfKDA2hg+K6x+5Hs6ej0ghSyzbH EFzwR9douDxLKaMRieSBACmE/tS1J54LsLeN2q1f5cxIexrfK/AUiK4kfePsarjn dmKJey2XiBaoH2lcoG37vxXCrP5yKkrxhVR3N6WRr4scSwuv1LkDS3hjIGSeGx/F Q+NWUxcU034hy/AxY3a3QPTpXWWPm+RKbXqyEirVPf8Pmcenw3w4Due7JiUoW/TQ ==
X-ME-Sender: <xms:6BLFWtG7Dz8r3XpyU97rgDTFt6bU3us1krnq0OeBylOeYrVIDkoNpg>
Received: from rtp-alcoop-nitro3.cisco.com (unknown [173.38.117.78]) by mail.messagingengine.com (Postfix) with ESMTPA id 70046E43BE; Wed, 4 Apr 2018 14:01:12 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <201802261624.w1QGOKdk042835@givry.fdupont.fr>
Date: Wed, 4 Apr 2018 14:01:11 -0400
Cc: gen-art@ietf.org, draft-ietf-sidr-slurm.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D9B7631D-FBDB-4A04-BA6C-12B8CF3BA4F7@cooperw.in>
References: <201802261624.w1QGOKdk042835@givry.fdupont.fr>
To: Francis Dupont <Francis.Dupont@fdupont.fr>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/nqteyK21dD36dWNm7mt23mLRBbo>
Subject: Re: [Gen-art] review of draft-ietf-sidr-slurm-06.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 18:01:19 -0000

Francis, thanks for your review. Authors, thanks for your responses. I have entered a No Objection ballot.

Alissa


> On Feb 26, 2018, at 11:24 AM, Francis Dupont <Francis.Dupont@fdupont.fr> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-sidr-slurm-06.txt
> Reviewer: Francis Dupont
> Review Date: 20180217
> IETF LC End Date: 20180221
> IESG Telechat date: unknown
> 
> Summary: Ready
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments: 
> - ToC page 2 and 6 page 14 (title): Security considerations ->
>  Security Considerations
> 
> - ToC page 2 and 7 page 14: Acknowledgements -> Acknowledgments
> 
> - 1 page 3: please expand the TA abbrev (it is the only occurrence BTW).
> 
> - 1.1. page 3: add a reference to RFC 8174 which updates RFC 2119 fixing
>  the keyword case silly issue.
> 
> - 2 page 3: please introduce the RP abbrev before (RP is not well known
>  because it has 4 different meanings. Here it is not ambiguous but
>  for instance RP does not stand for the beginning of RPKI...)
> 
> - 3.1 page 4: [RFC8259]format -> [RFC8259]format (missing space).
> 
> - 3.1 page 4: for me the right reference to JSON specs is ECMA-404.
>  Now I don't know the policy of the IETF about this particular point
>  (anyway if this must be fixed this will be by the RFC Editor?)
> 
> - 3.2 page 5: I leave the choice to introduce FQDN to you (for me
>  it is more than well known but it is not in RFC Editor list
>  https://www.rfc-editor.org/materials/abbrev.expansion.txt)
> 
> - 3.2 page 5: MUST in " all targets must be acceptable"?
> 
> - 3.3 page 6 example 1: "asn": 65536 -> "asn": 65536,
>  (missing comma which leads to incorrect JSON)
> 
> - 3.3 page 7 example 2: another missing comma at the same position.
> 
> - 3.4.1 page 7: I have no idea whether "subsume" is common English or not,
>  one of the authors is from China so I believe it is...
> 
> - 3.4.2 page 8: please introduce the SKI abbrev.
> 
> - 3.4.2 page 8 and 3.5.2 page 10: the document does not specify what
>  is the encoding. I suppose it is BER? If you believe it is not useful
>  you can keep the document as it is (i.e. not adding new encoding details).
>  Note for the public key 3.5.2 says DER.
> 
> - 3.6 pages 11 and 12: there are JSON pretty-printers available if you
>  like (I even have one :-). (I don't mean 3.6 JSON is not well indented,
>  just signal there are tools in the case you don't already know).
> 
> - 4.2 page 13 (twice): Y,Z -> Y, Z
> 
> - 6 page 14: strange (to me) comma in "by the RPKI, to that RP."
> 
> - authors' addresses page 17: China -> PR China or CN
> 
> - authors' addresses page 17: I am not sure that to be affilated to
>  his own personal organization is to be "unaffiliated"... IMHO the
>  problem is the XML schema requires the organization field to be set (:-).
> 
> Regards
> 
> Francis.Dupont@fdupont.fr
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art