[Gen-art] Gen-ART review of draft-ietf-httpbis-tunnel-protocol-04
Christer Holmberg <christer.holmberg@ericsson.com> Fri, 22 May 2015 08:26 UTC
Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EE451ACEFF for <gen-art@ietfa.amsl.com>; Fri, 22 May 2015 01:26:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h9NyXCe_7Q2f for <gen-art@ietfa.amsl.com>; Fri, 22 May 2015 01:26:40 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8FD1F1ACEFB for <gen-art@ietf.org>; Fri, 22 May 2015 01:26:39 -0700 (PDT)
X-AuditID: c1b4fb2d-f794d6d000004501-93-555ee83dda38
Received: from ESESSHC012.ericsson.se (Unknown_Domain [153.88.253.125]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 10.75.17665.D38EE555; Fri, 22 May 2015 10:26:37 +0200 (CEST)
Received: from ESESSMB209.ericsson.se ([169.254.9.71]) by ESESSHC012.ericsson.se ([153.88.183.54]) with mapi id 14.03.0210.002; Fri, 22 May 2015 10:26:37 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-httpbis-tunnel-protocol-04
Thread-Index: AdCURVhZjLRhErAsTfa4sHud0oIj2w==
Date: Fri, 22 May 2015 08:26:36 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B1D82B57A@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.154]
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B1D82B57AESESSMB209erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsUyM+Jvra7ti7hQgxUvrSyeX3O1uPrqM4sD k8eSJT+ZPL5c/swWwBTFZZOSmpNZllqkb5fAlfGg7QNrwdE+xooHe88zNjDOr+li5OSQEDCR 6P7WxAZhi0lcuLceyObiEBI4yijx8/VCJghnMaPEjLVNLF2MHBxsAhYS3f+0QRpEBDQl5q54 ywQSZhYoldh9MQYkLCzgINH2/AAzRImrxJbVZ1kgbD2JTxNawWwWAVWJSzdnsIK08gr4Sny4 kAoSZgQ64fupNUwgNrOAuMStJ/OZIE4TkFiy5zwzhC0q8fLxP1YIW0li0e3PUPX5Euce7QCz eQUEJU7OfMIygVF4FpJRs5CUzUJSBhHXkViw+xMbhK0tsWzha2YY+8yBx0zI4gsY2Vcxihan FhfnphsZ66UWZSYXF+fn6eWllmxiBMbOwS2/dXcwrn7teIhRgINRiYf3wdG4UCHWxLLiytxD jNIcLErivF5dIaFCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGFkml3yJN955/O29Tr5NK1Mi L00/sXRm+ERmOdXDz1eW+L/uWHqXq99I4v2StmSOdjvpaabxVYtV0yOP8TlunPiis8Dkvcgb uSCbNTWHNpjqBhuImt1+3pzjsEnlvuZ3oV/zefQf8U/gFxR5GMhyyDV13Z/YOWY8fOFaE5L9 Turf8dl59bz1KyWW4oxEQy3mouJEAG3T8Z9+AgAA
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/oycbmbRAuGXacIGJb1y9Z6zkM-s>
Cc: "draft-ietf-httpbis-tunnel-protocol.all@tools.ietf.org" <draft-ietf-httpbis-tunnel-protocol.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-httpbis-tunnel-protocol-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 May 2015 08:26:44 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document: draft-ietf-httpbis-tunnel-protocol-04.txt
Reviewer: Christer Holmberg
Review Date: 22 May 2015
IETF LC End Date: 3 June 2015
IETF Telechat Date: 6 June 2015
Summary: The document is well written, and almost ready for publication. However, I have a few editorial comments, and one technical question/issue.
Major Issues:
Q1:
As the ALPN header field can contain multiple, comma separated, header field values, I don't think the ABNF is correct. It should be something like:
ALPN = "ALPN":" protocol-id *(COMMA protocol-id)
Minor Issues: None
Editorial Issues:
Section 1:
-------------
Q1_1:
The text says:
"Proxies do not implement the tunneled protocol"
Are proxies prevented from implementing any tunneled protocol? If not, should the text say "Proxies might not implement the tunneled protocol"?
Q1_2:
The 2nd paragraph says:
"The HTTP ALPN header field identifies the protocol that will be used
within the tunnel, using the Application Layer Protocol Negotiation
identifier (ALPN, [RFC7301])."
...and the 3rd paragraph says:
"When the CONNECT method is used to establish a tunnel, the ALPN
header field can be used to identify the protocol that the client
intends to use with that tunnel."
Do you need both sentences, or could they be combined into a single sentence?
Q1_3:
The text says:
"For a tunnel that is then secured using TLS [RFC5246], the header field carries the same application
protocol label as will be carried within the TLS handshake."
I think it would be useful to add a reference to RFC 7301 after TLS handshake:
"...be carried within the TLS handshake [RFC7301]."
(The draft does reference 7301 earlier, but that is related to the definition of ALPN.)
Q1_4:
The text says:
"The ALPN header field carries an indication of client intent only.
An ALPN identifier is used here only to identify the application
protocol or suite of protocols that the client intends to use in the
tunnel. No negotiation takes place using this header field. In TLS,
the final choice of application protocol is made by the server from
the set of choices presented by the client. Other substrates could
negotiate the application protocol differently."
What if TLS is NOT used? Who makes the choice of application protocol then? What if the recipient does not support, or does not want to use, the protocol(s) indicated by the client?
Section 2:
-------------
Q2_1:
The text says that the ALPN header field will contain the protocol that will be used within the tunnel.
I think "will" is wrong wording, as the recipient has the final saying on what will be used. Later in the document the text says "intended to be used", and I think that would fit here too.
Section 2.3:
----------------
Q2-3_1:
The text says:
"For a CONNECT tunnel that conveys a TLS session that in turn
encapsulates another protocol,..."
The text is confusing. Shouldn't it simply say "A tunnel that is secured using TLS", or something?
Q2-3_2:
The text says:
"When used in the ALPN header field, the ALPN identifier and registry
are used..."
What is meant by "registry" here?
- [Gen-art] Gen-ART review of draft-ietf-httpbis-tu… Christer Holmberg
- Re: [Gen-art] Gen-ART review of draft-ietf-httpbi… Paul Kyzivat
- Re: [Gen-art] Gen-ART review of draft-ietf-httpbi… Martin Thomson
- Re: [Gen-art] Gen-ART review of draft-ietf-httpbi… Jari Arkko