Re: [Gen-art] Genart last call review of draft-ietf-mpls-ldp-yang-06

Alissa Cooper <alissa@cooperw.in> Wed, 04 December 2019 18:25 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E66812085B; Wed, 4 Dec 2019 10:25:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=mDWaFXqe; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=D2fy/gze
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mNqvcbRIrmgz; Wed, 4 Dec 2019 10:25:22 -0800 (PST)
Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7CDAA12087D; Wed, 4 Dec 2019 10:25:22 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B6300A3F; Wed, 4 Dec 2019 13:25:21 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 04 Dec 2019 13:25:22 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=2 JhpmTA/y1lwLcHXuGjVANT65kGv7nDJHK0xnFbFqZ0=; b=mDWaFXqeVwqfBdJfs iY93SR0f+6uvIbTudPB8g3y1xsRtueHulJrKpqJAQ0fgB9fsIixLSlfrNxOhWiC1 1NC8wZwy9w97cGDpa/i0rtCai0cZ15kGPEOlZ1S901H1oy7q3twe1D3dfSFfkdJ4 sUFzf3wcW7QkruyrxuVE7leT5Y88b5dgkDeBtyTlkRJLoMOsCzBaedt6UfX7qpDs IIMIHbdmjZpa0P8pHYEztiwuNk2/EwaXu05WdYvVhv7JMnONVJVfZJ2jDpsgbH14 joRfSyiIVeANK6cCLHUIVjh7U5b6m3p8XJ2LDempB8G68bkzyhdHLvQiLW6fqvwL ct44Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2JhpmTA/y1lwLcHXuGjVANT65kGv7nDJHK0xnFbFq Z0=; b=D2fy/gzed2mxy7YC98bmF6J9gPCzq+kshWniR+OL2HUJxe8OSxOrwt+xA krXHZUVmjmlY+kMV8Qn9/lwSZo5C5rYRW1adq1VJ+NmLwEh/3RTPSKH84F1bCfNp qiOKzNeLgtfDGZzfpv4dpqF01W8tc73CIApY5DQ/9cIkNcNDu3WI9RnhXzTXzep8 7W9mQu3IBJiEcbsS1+GD9nigQPKhZ2oqJ18VuBrGFYIVRk4wzebzmx8BtHZxK+D2 n7Qmd6PrDkZOycPlkuEQDGUzhV5MBmnuEW3agpi772Mm0sYj00IZQihY7Kt2oGgd A5RlgH8GbGEnIaNZnNwdFHqQx5CTw==
X-ME-Sender: <xms:EPrnXfrZoTNxYLzEZZR606jF7T5DwAmsDN_IHPdfIiU9OjFhNLSIUg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudejledgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeetlhhi shhsrgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomh grihhnpehivghtfhdrohhrghenucfkphepuddtkedrhedurddutddurdelkeenucfrrghr rghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhush htvghrufhiiigvpedt
X-ME-Proxy: <xmx:EPrnXdwNLt52Ii3vbdRLAzdZf0ZJzJdGqEVEnzpvexC5ca4WXCPQOg> <xmx:EPrnXZNNJNIhoCIuHG_ySw2nPFoeGzX-pTctny2A6mqDhuhsoizNMg> <xmx:EPrnXde1jNcVpam0uN1gYc2ZEOLDJFg3hqAuY4DnE2ntBY9ePYFaJA> <xmx:EfrnXWdLU5IG79F05rPazUMmj-1bvfAZqJpgSVXE9ngnYcyLod6XFA>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id 28F0430600BD; Wed, 4 Dec 2019 13:25:20 -0500 (EST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <156939784126.29030.13643769362107489881@ietfa.amsl.com>
Date: Wed, 4 Dec 2019 13:25:19 -0500
Cc: General Area Review Team <gen-art@ietf.org>, IETF MPLS List <mpls@ietf.org>, draft-ietf-mpls-ldp-yang.all@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F743EA72-9243-4D42-87E2-A1DB72DC691A@cooperw.in>
References: <156939784126.29030.13643769362107489881@ietfa.amsl.com>
To: Theresa Enghardt <theresa@inet.tu-berlin.de>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/p82PV5Lk_JevREB34Iq7Yn54Mek>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mpls-ldp-yang-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Dec 2019 18:25:24 -0000

Theresa, thanks for your review. I entered a No Objection ballot supporting Roman’s and Benjamin’s DISCUSS ballots, which note the items you mention below about the security considerations and IPv6, respectively.

Alissa


> On Sep 25, 2019, at 3:50 AM, Theresa Enghardt via Datatracker <noreply@ietf.org>; wrote:
> 
> Reviewer: Theresa Enghardt
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-mpls-ldp-yang-06
> Reviewer: Theresa Enghardt
> Review Date: 2019-09-25
> IETF LC End Date: 2019-10-04
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> This draft is basically ready for publication, but has some minor issues that
> should be fixed before publication.
> 
> Major issues: None.
> 
> Minor issues:
> 
> Section 1.1:
> 
> Why is LDP IPv6 grouped in the "extended" category and not in the "base"
> category, which the draft states to be the "minumum requirements for a typical
> base LDP deployment" and "suffice for small deployments"? Are typical, small
> deployments usually IPv4-only, and is this expected to remain true? Please
> consider briefly explaining this design decision.
> 
> What does "igp sync" refer to? Is this the same as "igp-synchronization-delay"
> in the extended model? Please consider expanding this abbreviation and/or
> providing a reference.
> 
> Section 3:
> 
> Could you provide references for the "widely deployed non-RFC features", which
> are part of the extended model, please?
> 
> "GR session is in recovery state" - What does "GR" refer to?
> 
> Section 10:
> 
> In the Security Considerations, it would be great if you could provide some
> examples of writable/creatable/deletable data nodes which may be considered
> sensitive or vulnerable, and what negative effects on network operations one
> could expect if an attacker wrote to them.
> 
> Nits/editorial comments:
> 
> The document doesn't use any RFC 2119 keywords, yet has text resembling RFC
> 2119 boilerplate text. Please consider removing the RFC 2119 boilerplate text.
> 
> The document contains a few typos and grammar issues.
> To improve readability, please check for consistency of upper/lower case terms,
> for the use of definite and indefinite articles, and consider running a
> spellchecker.
> 
> Some examples:
> 
> Section 1.1:
> 
> "The configuration and state items are divided into following two broad
> categories" --> "The configuration and state items are divided into the
> following two broad categories"
> 
> "This is worth higlighting " --> "It is worth highlighting"
> 
> Section 3:
> 
> "yang" - should this be all caps?
> 
> "rpc" - should this be all caps?
> 
> "grapically" --> "graphically"
> 
> Section 5.2.1:
> 
> "This container falls under global tree" --> "This container falls under the
> global tree"
> 
> "The example of former is interface hello timers, and example of latter is
> enabling hellos for a given AF under an interface." --> "The example of the
> former is interface hello timers, and an example of the latter is enabling
> hellos for a given AF under an interface."
> 
> "A peer is uniquely identified using its LSR Id and hence LSR Id is the key for
> peer list" [missing punctuation]
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art