Re: [Gen-art] Genart last call review of draft-uberti-rtcweb-rfc8829bis-02

Sean Turner <sean@sn3rd.com> Tue, 29 March 2022 02:47 UTC

Return-Path: <sean@sn3rd.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B15D83A0E5F for <gen-art@ietfa.amsl.com>; Mon, 28 Mar 2022 19:47:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.109
X-Spam-Level:
X-Spam-Status: No, score=-7.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=sn3rd.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NO3P_gX5KAZw for <gen-art@ietfa.amsl.com>; Mon, 28 Mar 2022 19:47:37 -0700 (PDT)
Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5ADA63A10DC for <gen-art@ietf.org>; Mon, 28 Mar 2022 19:47:37 -0700 (PDT)
Received: by mail-qk1-x72f.google.com with SMTP id g8so13090780qke.2 for <gen-art@ietf.org>; Mon, 28 Mar 2022 19:47:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sn3rd.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=M967Pg6xSJcmRhABgQlNO5ZtrHZ6xxG82Nh7TvaJ55s=; b=d7y72XS5DdJh3+1IL9yYmM6NUt8kTlvedCjwr80HXqW9iTxh94Td1NVhLJNwrLn7uZ gFbPUTxGVqG7t5aK76kU2TUJi2zXZ/1GeA4rXvjJu2wp1ZC6jOBxMNF21Mgy4UX7lUPL kS5udyRT+eGy/8t965eQCskwy8pYoNja482TM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=M967Pg6xSJcmRhABgQlNO5ZtrHZ6xxG82Nh7TvaJ55s=; b=p2mu1DkIZVkRz/B7ajpfnjo/setMJ8Dy+Rz/gMs9bmwF+uJvSOdurshd0ClXOB3WwR C+nqpDbuZPAuA/eUAgLdKoIUr8hiOlJc7iXPWIMbillD92FUyokeCH5z3tZwpPHCk3eJ 0fT49Zs002liYxRcYYW1ZwfqfkM2XC7URZ945NCjJQgVhU1OjN/b7fa+4XxJ5t3sA/oJ 0bclBCD+7UEUFwVY2hpbjtozdVyD+q5fD/1VfBOuxVPJ4et17SCDO4quNbkVyxjEf7G5 DxCczkPsRltxwTEJqC+yhlFyAk3tYSw3B0hBfnjsQg1i0o+KV78jDEYKOtF7fK9z9KKt WJEg==
X-Gm-Message-State: AOAM531gpw1A7wK3OEmH3F2XF3IwNAaQRRtLFfgEVUfIGG0426LdRtO4 uSsXp487g6dNhA7IQAnrI9edde//hacoAw==
X-Google-Smtp-Source: ABdhPJzImPlq+uNGb///VdbPfRFgzRPoTfF/Q2N+guPv8h/5R2XAP+n53LSM1bscwDMsXKW5Wa0jzQ==
X-Received: by 2002:a05:620a:489:b0:67b:31cb:fbca with SMTP id 9-20020a05620a048900b0067b31cbfbcamr19296623qkr.701.1648522055788; Mon, 28 Mar 2022 19:47:35 -0700 (PDT)
Received: from smtpclient.apple (pool-71-178-177-131.washdc.fios.verizon.net. [71.178.177.131]) by smtp.gmail.com with ESMTPSA id v12-20020a05622a130c00b002e1b3ccd9adsm14078610qtk.79.2022.03.28.19.47.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Mar 2022 19:47:35 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
From: Sean Turner <sean@sn3rd.com>
In-Reply-To: <164840334560.25727.8727238035250838155@ietfa.amsl.com>
Date: Mon, 28 Mar 2022 22:47:34 -0400
Cc: gen-art@ietf.org, draft-uberti-rtcweb-rfc8829bis.all@ietf.org, last-call@ietf.org, RTCWeb IETF <rtcweb@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <320CCABF-5283-4B07-B637-FC03F582CA2D@sn3rd.com>
References: <164840334560.25727.8727238035250838155@ietfa.amsl.com>
To: Joel Halpern <jmh@joelhalpern.com>
X-Mailer: Apple Mail (2.3654.120.0.1.13)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/pEpQZ7B3WrxIG4V2VSRQe3RTU1c>
Subject: Re: [Gen-art] Genart last call review of draft-uberti-rtcweb-rfc8829bis-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2022 02:47:42 -0000


> On Mar 27, 2022, at 13:49, Joel Halpern via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Joel Halpern
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-uberti-rtcweb-rfc8829bis-02
> Reviewer: Joel Halpern
> Review Date: 2022-03-27
> IETF LC End Date: 2022-04-05
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This document is ready for publication as a Proposed Standard. 
> However, there are some issues that should be considered before final approval.
> 
> Major issues: None
> 
> Minor issues:
>    I found myself confused as a reader about one aspect of this document  The
>    document seems to describe both the Interface to the JSEP and the details
>    of what the underlying system must do in response to JSEP operations.  The
>    later is described very well and clearly.  The former is described quite
>    vaguely.  I suspect that the assumption is that the required parameters are
>    described in the W3C documents.  But it is hard to tell, and the only
>    formal reference is a vague citation in the introduction to an outdated W3C
>    specification.  A little more clarity on how an implementor is supposed to
>    know what actual interface objects, methods, and parameters they need to
>    provide would be helpful.  Also, the reference should be updated to
>    whatever is the current W3C specification.

Will check on updating the reference. I would be floored if we couldn’t point to it.

The basic idea here is that the W3C WebRTC spec is API and this is the protocol spec.

> Nits/editorial comments:
> 
> 
>