IETF Logo Mail Archive

[Gen-art] Gen-ART Telechat review of draft-ietf-pcp-third-party-id-option-04.txt

Suresh Krishnan <suresh.krishnan@ericsson.com> Wed, 18 November 2015 04:15 UTC

Return-Path: <suresh.krishnan@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 83C5A1AC3D3; Tue, 17 Nov 2015 20:15:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TBWDwpdDAHf0; Tue, 17 Nov 2015 20:15:19 -0800 (PST)
Received: from usevmg20.ericsson.net (usevmg20.ericsson.net [198.24.6.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE70D1A6F13; Tue, 17 Nov 2015 20:15:18 -0800 (PST)
X-AuditID: c618062d-f79ef6d000007f54-14-564b9950d1c4
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id B1.39.32596.0599B465; Tue, 17 Nov 2015 22:17:05 +0100 (CET)
Received: from EUSAAMB107.ericsson.se ([147.117.188.124]) by EUSAAHC002.ericsson.se ([147.117.188.78]) with mapi id 14.03.0248.002; Tue, 17 Nov 2015 23:15:17 -0500
From: Suresh Krishnan <suresh.krishnan@ericsson.com>
To: "draft-ietf-pcp-third-party-id-option.all@ietf.org" <draft-ietf-pcp-third-party-id-option.all@ietf.org>, General Area Review Team <gen-art@ietf.org>
Thread-Topic: Gen-ART Telechat review of draft-ietf-pcp-third-party-id-option-04.txt
Thread-Index: AdEht7qbpNGMPV5LTXS24OfwQP9ung==
Date: Wed, 18 Nov 2015 04:15:16 +0000
Message-ID: <E87B771635882B4BA20096B589152EF63AA5ABFC@eusaamb107.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.117.188.12]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsUyuXSPn27gTO8wg28aFkv2tLNYXH31mcWB yWPJkp9MAYxRXDYpqTmZZalF+nYJXBm3F6xnK5gtUPFtAkcD41beLkYODgkBE4nL+yS6GDmB TDGJC/fWs3UxcnEICRxhlLjYcJwRwlnOKPH93kVWkCo2oIYNOz8zgSREBOYwSpz7dpUJZJKw QKDEt49cIDUiAmESXY/eskHYehJHXu5hAbFZBFQlPi7vZwKxeQV8Jd7NPQtWwwi0+fupNWBx ZgFxiVtP5jNBXCQgsWTPeWYIW1Ti5eN/rBC2ksSc19eYIep1JBbs/sQGYWtLLFv4mhlivqDE yZlPWCYwCs9CMnYWkpZZSFpmIWlZwMiyipGjtDi1LDfdyGATIzCcj0mw6e5g3PPS8hCjAAej Eg/vBwfvMCHWxLLiytxDjBIczEoivJqvgEK8KYmVValF+fFFpTmpxYcYpTlYlMR59y+5Hyok kJ5YkpqdmlqQWgSTZeLglGpg1Dj7Rb3vdZJ6u+vnnCjHLYULitd1pa1JErun+nqv7cwUjfm5 zxMXBh486tSldrrq2beAG94z2Epmvu13KQmIYRPJlv9X9DMuKMTyD4OplPWbBQd2Z2k/63wq MjeHV9L9husV/xnRu8XCysvrrn+bly5jwr7tx6p4rckbSrNkWXwFDpYpsq9VYinOSDTUYi4q TgQAfnoce2MCAAA=
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/pMxxlHGt3ZJcd96LbqJar_hawrM>
Subject: [Gen-art] Gen-ART Telechat review of draft-ietf-pcp-third-party-id-option-04.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2015 04:15:20 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Please wait for direction from your document shepherd or AD before
posting a new version of the draft.

Document: draft-ietf-pcp-third-party-id-option-04.txt
Reviewer: Suresh Krishnan
Review Date: 2015/11/17
IESG Telechat date: 2015/11/19

Summary: The draft is almost ready for publication as a Proposed Standard but 
I do have a major issue that needs to be addressed.

Major
=====

* Section 5.2

The draft is a bit underspecified on how the THIRD_PARTY_ID carried in the 
option is compared to existing entries in the mapping table in the processing 
of request messages. Given that the option itself is loosely specified 
(allowing pretty much anything to be used as the ID) I think it is going to 
be very difficult to realize interoperable implementations unless the 
comparison method is clearly specified. e.g. Consider one of the options for 
THIRD_PARTY_ID described in the document - the MAC address. It could be 
carried as 48 bits binary (aabbccddeeff), hyphen delimited string of hex 
digits ("aa-bb-cc-dd-ee-ff") , colon delimited string of hex digits 
("aa:bb:cc:dd:ee:ff") with upper case and lower case variants. If you intend 
this to be an exact bit by bit comparison, it would be helpful if you state 
it explicitly. If not, please state that as well.

Minor
=====

* IANA considerations

"  [NOTE for IANA: Please allocate a PCP Option Code at
    http://www.iana.org/assignments/pcp-parameters/pcp-
    parameters.xml#option-rules]"

The URL for this registry is wrong. Did you mean

http://www.iana.org/assignments/pcp-parameters/pcp-parameters.xml#options

instead?

Thanks
Suresh

v2.23.0 | Report a Bug | By Email