Re: [Gen-art] Gen_ART review of draft-santesson-auth-context-extension-10

Jari Arkko <jari.arkko@piuha.net> Wed, 25 November 2015 13:08 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 29DF71B2C53 for <gen-art@ietfa.amsl.com>; Wed, 25 Nov 2015 05:08:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.485
X-Spam-Level:
X-Spam-Status: No, score=-2.485 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.585] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 84BCVjVx3Ebj for <gen-art@ietfa.amsl.com>; Wed, 25 Nov 2015 05:08:21 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 2EFE91B2C4D for <gen-art@ietf.org>; Wed, 25 Nov 2015 05:08:21 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 2C5022CC5D; Wed, 25 Nov 2015 15:08:19 +0200 (EET) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xl8dw-A784BH; Wed, 25 Nov 2015 15:08:18 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 729C02CC5C; Wed, 25 Nov 2015 15:08:18 +0200 (EET) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_FAD8627D-C000-4939-88D9-ACC286981B52"; protocol="application/pgp-signature"; micalg=pgp-sha512
X-Pgp-Agent: GPGMail 2.5.1
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <F064785A-11BE-419C-A3E3-55CD0F8A7145@aaa-sec.com>
Date: Wed, 25 Nov 2015 15:08:16 +0200
Message-Id: <D29A2ADC-613E-4716-BECE-8E7050ACE4A0@piuha.net>
References: <CAC8SSWu-p-exvzpEY=5hVQrHiCnKRkbfMHCevbu8Az=mGwFpRQ@mail.gmail.com> <D4D187AF-63A7-45C0-B5DC-F420CC7FB291@piuha.net> <F064785A-11BE-419C-A3E3-55CD0F8A7145@aaa-sec.com>
To: Stefan Santesson <stefan@aaa-sec.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/pg__MFupWJVi7YYl0d5TDwYRtwY>
Cc: General Area Review Team <gen-art@ietf.org>, draft-santesson-auth-context-extension.all@tools.ietf.org
Subject: Re: [Gen-art] Gen_ART review of draft-santesson-auth-context-extension-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2015 13:08:24 -0000

thanks

On 23 Nov 2015, at 00:18, Stefan Santesson <stefan@aaa-sec.com> wrote:

> Thank you,
> 
> I have now seen this and I will address this in the final document update.
> 
> /Stefan
> 
> 
> 
> 
> On 20/11/15 02:12, "Jari Arkko" <jari.arkko@piuha.net> wrote:
> 
>> Thanks for your review, Jouni!
>> 
>> (Authors, did you see this review - wanted to make sure no information is lost.)
>> 
>> Jari
>> 
>> On 16 Oct 2015, at 01:56, jouni korhonen <jouni.nospam@gmail.com> wrote:
>> 
>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>> Gen-ART, please see the FAQ at
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>> 
>>> Please resolve these comments along with any other Last Call comments
>>> you may receive.
>>> 
>>> Document:draft-santesson-auth-context-extension-10
>>> Reviewer: Jouni Korhonen
>>> Review Date: Oct-15-2015
>>> IETF LC End Date: Oct-27-2015
>>> IESG Telechat date: not yet
>>> 
>>> 
>>> Summary:
>>> --------
>>> 
>>> Ready for publication as an Informational RFC.
>>> 
>>> Comments:
>>> ---------
>>> 
>>> I do not have deep expertise on the area this I-D covers. Having read it through and knowing the solution is already deployed for few years I have no technical comments.
>>> 
>>> Minor issues/nits:
>>> ------------------
>>> 1) IDNits result that need to be addressed:
>>>   ** The abstract seems to contain references ([RFC5280], [SAML]), which it
>>>      shouldn't.  Please replace those with straight textual mentions of the
>>>      documents in question.
>>> 
>>> 2) == Unused Reference: 'RFC5322' is defined on line 416, but no explicit
>>>      reference was found in the text
>>> 
>>> 
>>> 3) Since this targets Informational RFC I wouldn't mind seeing all references
>>>   except RFC2119 as informational references and not normative. We could argue
>>>   whether RFC2119 language is needed at all (but no strong opinion here).
>>> 4) Introduction third paragraph:
>>>   * expand SAML on the first occurrence
>>>   * I would welcome a reference for "SAML federation"
>>> 
>>> 5) Introduction eight paragraph:
>>>   * expand CA on the first occurrence
>>> 6) Section 3.1.2:
>>>   * expand OID on the first occurrence (now it comes after the paragraph
>>>     explaining "Ref")
>>>   * three times  s/REF/Ref
>>> _______________________________________________
>>> Gen-art mailing list
>>> Gen-art@ietf.org
>>> https://www.ietf.org/mailman/listinfo/gen-art
>> 
>