IETF Logo Mail Archive

Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06

Benjamin Kaduk <kaduk@mit.edu> Wed, 07 February 2018 17:35 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BEBC212D84B; Wed, 7 Feb 2018 09:35:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.211
X-Spam-Level:
X-Spam-Status: No, score=-4.211 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id urOJ7r83swWF; Wed, 7 Feb 2018 09:35:45 -0800 (PST)
Received: from dmz-mailsec-scanner-7.mit.edu (dmz-mailsec-scanner-7.mit.edu [18.7.68.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC3C81270AE; Wed, 7 Feb 2018 09:35:44 -0800 (PST)
X-AuditID: 12074424-cafff700000048fe-7b-5a7b38edf9fe
Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP id 7C.43.18686.EE83B7A5; Wed, 7 Feb 2018 12:35:42 -0500 (EST)
Received: from outgoing.mit.edu (OUTGOING-AUTH-1.MIT.EDU [18.9.28.11]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id w17HZdlc005810; Wed, 7 Feb 2018 12:35:40 -0500
Received: from mit.edu (24-107-191-124.dhcp.stls.mo.charter.com [24.107.191.124]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id w17HZYiw029773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 7 Feb 2018 12:35:37 -0500
Date: Wed, 07 Feb 2018 11:35:34 -0600
From: Benjamin Kaduk <kaduk@mit.edu>
To: Weijun Wang <weijun.wang@oracle.com>
Cc: draft-ietf-kitten-rfc5653bis.all@ietf.org, kitten <kitten@ietf.org>, gen-art <gen-art@ietf.org>, "Joel M. Halpern" <jmh@joelhalpern.com>, Alissa Cooper <alissa@cooperw.in>, Greg Hudson <ghudson@mit.edu>
Message-ID: <20180207173534.GX12363@mit.edu>
References: <25d5a1bb-e7bb-431b-6632-09904a581d77@joelhalpern.com> <074DA813-1E7F-4C03-AEEE-5D76E8804C31@oracle.com> <41bbbe7d-0f35-78ad-a5cd-673488f3ac09@joelhalpern.com> <20180103030817.GH50827@kduck.kaduk.org> <C47701B8-2504-490B-BE38-ED35A1D2C1A2@oracle.com> <19F5D23D-3677-41C6-B504-454C7595FF1F@cooperw.in> <D6DB69A6-5768-4536-89AA-40E0A905DF95@oracle.com> <366697b8-2a0c-243b-b153-ee8eb4358580@mit.edu> <8F5B79CD-B928-4B8E-97FA-D946784228B7@oracle.com> <505EACB9-D92E-4DE9-9ECC-DF931C1B924D@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <505EACB9-D92E-4DE9-9ECC-DF931C1B924D@oracle.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsUixCmqrfvOojrKYPkzK4vpZ/4yWiw6uo/Z 4uqrzywWH0+9YbI4unkVi8XXpRuYHdg8vjx5yeSxZMlPJo9zU74zenx8eoslgCWKyyYlNSez LLVI3y6BK6PhnXxBF3/F5j/nmRoYH3N3MXJySAiYSFxZvJ+5i5GLQ0hgMZPE4ZuLGSGcDYwS e/duhcqcYZLYdHIaE0gLi4CKxOGXnewgNhuQ3dB9mRnEFhHQkGh40ATWwCzwgFFi3udOFpCE sEC0RNvCa2wgNq+AjsT026+hVvSzSJx5fYMVIiEocXLmE7AGZgEtiRv/XgJt4wCypSWW/+MA MTkF7CTW3tYBqRAVUJbY23eIfQKjwCwkzbOQNM9CaF7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEv L7VI11wvN7NELzWldBMjKMTZXVR2MHb3eB9iFOBgVOLhnWFeHSXEmlhWXJl7iFGSg0lJlPfx wqooIb6k/JTKjMTijPii0pzU4kOMEhzMSiK87uxA5bwpiZVVqUX5MClpDhYlcV4PE+0oIYH0 xJLU7NTUgtQimKwMB4eSBO8dkD2CRanpqRVpmTklCGkmDk6Q4TxAw5eA1PAWFyTmFmemQ+RP Mepy3Hjxuo1ZiCUvPy9VSpz3A0iRAEhRRmke3BxQapLI3l/zilEc6C1hiHU8wLQGN+kV0BIm oCU3gipBlpQkIqSkGhinMkVM4omT9Ijbr3DgpLx4385lu+5pzD/2W8EjsuWRxi2RGK87vx1n qUcYhnM13dm7dHV+RJ1J0d2Sdee2fNzMNfc7H8+/jW6zUrRLDwRFhz8zq+fJVrwfanNWUMPJ NNDf5srTDveH593/PF7zVsA45PfHlODrcxI8ZxkzBdt/WfGJ3fmfn6sSS3FGoqEWc1FxIgAM vqanKAMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/pkR9RskkFb7oU70dy6LlOD3X4p8>
Subject: Re: [Gen-art] [kitten] Genart telechat review of draft-ietf-kitten-rfc5653bis-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2018 17:35:47 -0000

I am doing a review now.  (Line 413, "SHOULD not" --> "SHOULD NOT"
is all I have so far.)

And I will second Greg's comment about this format being an awesome
way to view these changes -- thank you again for putting them
together!

-Ben

On Tue, Feb 06, 2018 at 10:17:35PM +0800, Weijun Wang wrote:
> I will submit a new draft tomorrow if there is no other feedback.
> 
> Thanks
> Weijun
> 
> > On Jan 29, 2018, at 9:26 AM, Weijun Wang <weijun.wang@oracle.com> wrote:
> > 
> > The HTML file updated in place.
> > 
> > Thanks
> > Weijun
> > 
> >> On Jan 27, 2018, at 10:12 AM, Greg Hudson <ghudson@mit.edu> wrote:
> >> 
> >> On 01/23/2018 06:43 PM, Weijun Wang wrote:
> >>> I've uploaded an updated version at
> >>> 
> >>> http://cr.openjdk.java.net/~weijun/rfc5653bis/draft-ietf-kitten-rfc5653bis-07.html
> >> 
> >> This is a great format for reviewing these changes; thanks for
> >> generating it.
> >> 
> >> Line 416 does not capitalize "optional" in "optional services", but
> >> lines 385 and 391 do.
> >> 
> >> Lines 422 and 424 should probably capitalize "should".  Line 429 should
> >> probably capitalize "may".
> >> 
> >> At line 598, I would lean towards leaving "MUST" in lowercase as we are
> >> describing an application requirement, not prescribing one.
> >> 
> >> Line 1174, I would leave "MAY" in lowercase.
> >> 
> >> Line 1229, "may" should probably be capitalized.
> >> 
> >> Line 1369, I would leave "MAY" alone as this seems more descriptive than
> >> prescriptive.
> >> 
> >> Line 3221's use of "SHOULD" is prescriptive, but there's no other way to
> >> request the default QOP.  So I would leave it lowercase (or change the
> >> wording, but I'm not trying to open any more cans of worms).
> >> 
> > 
> > _______________________________________________
> > Kitten mailing list
> > Kitten@ietf.org
> > https://www.ietf.org/mailman/listinfo/kitten
>

v2.23.0 | Report a Bug | By Email