Re: [Gen-art] [Idr] Genart last call review of draft-ietf-idr-rfc5575bis-20

Gyan Mishra <hayabusagsm@gmail.com> Tue, 28 April 2020 23:50 UTC

Return-Path: <hayabusagsm@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90D7F3A0ACD; Tue, 28 Apr 2020 16:50:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6jmVjs6e0uw8; Tue, 28 Apr 2020 16:50:37 -0700 (PDT)
Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 906373A0AC9; Tue, 28 Apr 2020 16:50:36 -0700 (PDT)
Received: by mail-il1-x133.google.com with SMTP id b18so724587ilf.2; Tue, 28 Apr 2020 16:50:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=26i7oENWhAtDIsZ+lIdDQxMzbHKi6rABW2OgwCs42dk=; b=Aa4uvGQPImUOVIgdBRNbnnfmQEl1rJZgKwVu/QtGJaOm/O73wVSqnwc/zjJdMleZGq V3KAJ4JLlvtDtf07vvp2IdN6XxROtVbysT2Wllv48oZ7brWRpC8eT39QEU57qvec4BSI uzDCw2KmY4jbyKlvNdC28XWQpZPOa5aFm//GALmQtZL/yzlKQ/awmp4bNG02JnDJDgTi U2UqjxpoOerCCj9Sw3HGjaCve/h3Na2n7HHctFqeruu7QjkQdTzSsUTzdRwQ1XCB/6Iu Z8Sj1qQqD1X9LTjxqNSBHojcjjbKCVpHdQ/UnayPMBdtVgudcExCpk2bsZJ8VqTJBL5h nGQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=26i7oENWhAtDIsZ+lIdDQxMzbHKi6rABW2OgwCs42dk=; b=QsIlzfMGxoaM3thfQDUO6V1LWbBI0T0x8s3YOpeeA7bSyOz+tlULD8zm8Xb+cudDuI YmsxrW3DSXOUx0j60550qVjHl0eDGENUcsotKRLlOPZt1lh4EWlQAqaY2KTa6zMv0SXn PgEhkVHls+5e4eWm36cLIcwbsxy0VSDZFVMHFo2dao1QxqeFcEKb6ETEZGF/1WN7l+U6 FMk6qgKbfhpmF3ixvr/WXqV1yBhJ1Ys6OiDSFwvBLQxmouDH2G+3AEd0UaECCZNgpkSu xUbs1TmSCZ8+tEKbN1XHuM78AcE8Ng782HhmLbTfGj6/GUUqVhsnixehp5voXWNePiSG p/+w==
X-Gm-Message-State: AGi0PuZ35a4qwz1XY6p6DgPEjD/vL1OOGBKh156ClLU/SS4cXWf9I0mg NBqM6qQ4Fi04NEDu+3bFy/W1DRzfI+IVOHQbr1J2RF06BTk=
X-Google-Smtp-Source: APiQypL2cmlQBu+ChoCjfdzZ2AhGwMu8zTCTTExzYkdBBz+IezZik5za/34ZyLSWFwW6ONAxvfCr2LXJN7b0/SkvxFM=
X-Received: by 2002:a92:3c55:: with SMTP id j82mr29856211ila.258.1588117835396; Tue, 28 Apr 2020 16:50:35 -0700 (PDT)
MIME-Version: 1.0
References: <158629580378.13606.6350807287790835622@ietfa.amsl.com> <42014AE1-D058-486E-9E17-475D07A91885@tix.at> <F7D42D8A-9764-4CB7-B6AC-600239CFBFF9@cooperw.in>
In-Reply-To: <F7D42D8A-9764-4CB7-B6AC-600239CFBFF9@cooperw.in>
From: Gyan Mishra <hayabusagsm@gmail.com>
Date: Tue, 28 Apr 2020 19:50:24 -0400
Message-ID: <CABNhwV0A5fZRPx8H2_G2_BdpY369eQtoLAEr6c137Dz9unvxRg@mail.gmail.com>
To: Alissa Cooper <alissa@cooperw.in>
Cc: Christoph Loibl <c@tix.at>, General Area Review Team <gen-art@ietf.org>, IDR List <idr@ietf.org>, draft-ietf-idr-rfc5575bis.all@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="00000000000070bc1305a4627faa"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/pzfmfep3TBT08ZD_lygg8oUMnh4>
Subject: Re: [Gen-art] [Idr] Genart last call review of draft-ietf-idr-rfc5575bis-20
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 23:50:41 -0000

Thanks Christoph & Alissa

Gyan

On Wed, Apr 22, 2020 at 9:55 AM Alissa Cooper <alissa@cooperw.in> wrote:

> Gyan, thanks for your review. Christoph, thanks for your response. I think
> the intro in the draft is ok as-is. I entered a DISCUSS ballot with a
> question about Section 7.
>
> Alissa
>
>
> On Apr 17, 2020, at 3:43 AM, Christoph Loibl <c@tix.at> wrote:
>
> Hi Gyan,
>
> Thanks for your review. According to your review I made the following
> changes to the document which is available now as revision -22:
>
> On 07.04.2020, at 23:43, Gyan Mishra via Datatracker <noreply@ietf.org>
> wrote:
>
> Reviewer: Gyan Mishra
> Review result: Ready with Nits
>
> Reviewer: Gyan Mishra
> Review result: Ready with Minor Issues
>
> Minor issues:
> I am familiar with BGP Flow specification and would like to recommend some
> verbiage that may help in the introduction as far as explaining how BGP
> flow
> spec works.  Ssince the introduction has been re-written with this update,
> this
> could be a possible addition to the draft.
>
> This could be placed at the end of the introduction if desired.
> BGP flow specification is a client-server model that allows for a more
> granular
> approach to DDOS mitigation than its predecessor, “Remotely Triggered
> Blackhole
> (RTBF) which tagged a prefix with a community and sent it do a discard next
> hop.  BGP flow spec has two main components, the “controller” being the BGP
> speaker device which acts as the server side, which injects the new
> flowspec
> entry, and the client side which is the BGP speaker devices that receives
> the
> flowspec NLRI and acts on the instruction to match a particular flow with
> Layer
> 3 and Layer 4 parameters and then implements the hardware forwarding action
> requested.
>
>
> <--
> Tracked via issue #163: https://github.com/stoffi92/rfc5575bis/issues/163
>
> I do not agree that BGP flowspec is a client-server model -only-. We can
> propagate this NLRI over administrative domain borders as we do with IP
> routing information, it follows the same mechanisms. We see such solutions
> being deployed in the internet as inter provider DDoS solutions.
>
> We actually had a paragraph in the darft that was explaining the
> advantages over other approaches like RTBF but this has been removed
> because it was pointed out that it is not relevant to the spec to justify a
> well deployed technology.
> -->
>
>
> Nits/editorial comments:
> 7.  Traffic Filtering Actions
>   This document defines a minimum set of Traffic Filtering Actions that
>   it standardizes as BGP extended community values [RFC4360]
>
>   Any mention of [RFC4360] should be updated with [RFC7153] IANA Registries
>   for BGP Extended Communities.
>
>
> <--
> Tracked via issue #164: https://github.com/stoffi92/rfc5575bis/issues/164
> Commits mentions:
>
> https://github.com/stoffi92/rfc5575bis/commit/31f0ac79b7cd998aa2750fd376dc148d7a590369
>
> https://github.com/stoffi92/rfc5575bis/commit/7aadadcdf55a1f5a7d5c1822070b862247dfaead
>
> Removed the "values" statement (as suggested by Alvaro) from the draft to
> make clear we are not talking about particular values but about  Extended
> Communities as specified in RFC4360.
> s/standardizes as BGP extended community values [RFC4360]/standardizes as
> BGP extended communities [RFC4360]/
>
> -->
>
> Cheers
> Christoph
>
> --
> Christoph Loibl
> c@tix.at | CL8-RIPE | PGP-Key-ID: 0x4B2C0055 | http://www.nextlayer.at
>
>
>
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art
>
>
> --

Gyan  Mishra

Network Engineering & Technology

Verizon

Silver Spring, MD 20904

Phone: 301 502-1347

Email: gyan.s.mishra@verizon.com