Re: [Gen-art] Gen-ART LC review of draft-ietf-dnsop-cookies-08

Donald Eastlake <d3e3e3@gmail.com> Mon, 28 December 2015 00:31 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E451E1A86E4; Sun, 27 Dec 2015 16:31:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.55
X-Spam-Level:
X-Spam-Status: No, score=0.55 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, MANGLED_LIST=2.3, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WRXd51pULamK; Sun, 27 Dec 2015 16:31:20 -0800 (PST)
Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9ABEC1A86E3; Sun, 27 Dec 2015 16:31:20 -0800 (PST)
Received: by mail-ob0-x232.google.com with SMTP id iw8so223340024obc.1; Sun, 27 Dec 2015 16:31:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=MDDkPDsC1iKtZeH4/d/0UupRjsX4YEiO2lXtOkEwMz0=; b=kniSccobf3Ha6jwclRy9Ee0wAL3J6NzNF0MNLCB2T2wdX2Kme5a3rBymBlY2K1jqI+ xt1xU/anzi47luDZmKl018kPOsp7X61E4SbTotNc4OSUNFBWFHQyJEcrGEItdN0870e8 uvnfI6HRTYEXjT+cm0K7VowF/g4jbOv/mqqTxhc0+KbmOcqqiosQ9Dd0JAKdJI86XGK4 oHtB+bvaSzL6nYD7f3ntlhvA1DTudeA3R5rlFHngOc09q/vD0niiro1wMsu72rEQM8QW QUaRZFA/mVULVHoYT8mmuTlX7EyyECi8c+/T9pfQ6YF17oOPthTNhmcLywpo4nztYHlg 6G4A==
X-Received: by 10.60.70.236 with SMTP id p12mr31952834oeu.55.1451262679949; Sun, 27 Dec 2015 16:31:19 -0800 (PST)
MIME-Version: 1.0
Received: by 10.76.157.161 with HTTP; Sun, 27 Dec 2015 16:31:05 -0800 (PST)
In-Reply-To: <011001d13eb3$63339cd0$299ad670$@akayla.com>
References: <011001d13eb3$63339cd0$299ad670$@akayla.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Sun, 27 Dec 2015 19:31:05 -0500
Message-ID: <CAF4+nEGeK9u47LZKD8D_LX75RXLiVdzJVi9LQMkt=eA3mN6a_Q@mail.gmail.com>
To: Peter Yee <peter@akayla.com>
Content-Type: text/plain; charset=UTF-8
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/q0wNo4_YtEW-tYGEtE-UvVxi6vY>
Cc: "gen-art@ietf.org Review Team" <gen-art@ietf.org>, draft-ietf-dnsop-cookies.all@ietf.org, IETF Discussion <ietf@ietf.org>
Subject: Re: [Gen-art] Gen-ART LC review of draft-ietf-dnsop-cookies-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Dec 2015 00:31:23 -0000

Hi Peter,

Thanks for the comments, see below.

On Thu, Dec 24, 2015 at 8:27 PM, Peter Yee <peter@akayla.com> wrote:
> I am the assigned Gen-ART reviewer for this draft.  The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comment.  For background on Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>
> (Actually, I'm tardy on this review.  It inexplicably dropped off my radar.
> So deal with these comments when you get around to handling Telechat input
> or AUTH48 or whenever it suits you!  I'm still posting this review as it
> will be needed come the Telechat.)

I don't think it has been scheduled for a Telechat yet so we might as
well resolve these comments now.

> Document: draft-ietf-dnsop-cookies-08
> Reviewer: Peter Yee
> Review Date: December 24, 2015
> IETF LC End Date: December 14, 2015
> IESG Telechat date: TBD
>
> Summary: This draft is basically ready for publication, but has nits that
> should be fixed before publication. [Ready with nits]
>
> The draft provides a lightweight means to increase the difficulty of certain
> DNS attacks by off-path attackers, but it isn't designed to be the be all
> and end all of DNS security.  It can be deployed incrementally.
>
> Major issues: None
>
> Minor issues:
>
> Page 14, Section 5.2.4, 1st paragraph, 1st sentence: It might be useful to
> mention what the examination entails as it would help in understanding the
> 3rd sentence in the paragraph.  There's an implied recalculation of the
> Server Cookie value based on the received Client Cookie and client IP
> address as opposed to a simple lookup of the received value.

I'm not so sure of that. If the server wanted to, it could generate a
random Server Cookie for each {Client Cookie, Client IP} and, in fact,
do a look up.

> Nits:
>
> Page 12, Section 5.2, 3rd paragraph, 1st sentence: change "the the" to just
> "the".

OK.

> Page 13, Section 5.2.2, 2nd paragraph: append "bytes" after "40".

Why after 40 but not after 8 or 16? Seems like me it would be an
improvement to add "bytes" after all three.

> Page 14, Section 5.2.4, 1st paragraph, 2nd sentence: delete the sentence.
> It's redundant with the 1st sentence.

OK.

> Page 15, Section 5.4, 2nd paragraph, 1st sentence: change first "a" to "an".

OK.

> Page 15, Section 5.4, 4th paragraph, 1st sentence: change first "a" to "an".

OK.

> Page 17, Section 6, 1st paragraph, 2nd sentence: change "indefinitely" to
> "indefinite".

OK.

> Page 21, Section 9, 2nd paragraph, 2nd sentence: change "WPAv2" to "WPA2"
> (the Wi-Fi Alliance's term).

OK.

> Page 23, Section 10: change "a" to "an".

OK.

> Page 27, Section A.1, 1st sentence: change "An" to "A".

OK.

> Page 29, 1st partial sentence: if you're going to drop beta earlier in the
> section, you might as well give the BIND version number here as well.  It's
> no longer apparent that a beta version was involved.

OK.

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com