IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04

Roni Even <ron.even.tlv@gmail.com> Wed, 17 February 2021 05:07 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A8843A14DF; Tue, 16 Feb 2021 21:07:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zIC-cp7mzfPv; Tue, 16 Feb 2021 21:07:48 -0800 (PST)
Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5E063A14DD; Tue, 16 Feb 2021 21:07:47 -0800 (PST)
Received: by mail-wm1-x336.google.com with SMTP id n10so1346916wmq.0; Tue, 16 Feb 2021 21:07:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=/gqfXgdh/mEpSJsHqR85PBOujlxEqs4qQYPY01fHzNw=; b=JcfPv4pvQSMIykMQXSMfCIwTKuMNgdTw/tf0ptc8C2ONI8SUaiF4Vs/xkRUjQj9gtI Wj2uz2WUkEbHgUUJntPjZXl2VBo9FQEJYT8jj7neLBo6E677Mhhmt98gy2sKORq0md4f BaRrtcqZkQJ/mlstkcLafgdNlTNhB+puO8Ee7Jif69WPg1GD2yHKSJgTcPkkajLOQTfe iJBLiZIw2b5XxdflITgwvIjga/599tx/NUzaR53BoNemhS24mcJs39dkGI7H25ghoP0R hOtdAWZ6uTwMN25p/eRUHDB+3Yss4QerCEruCjDH/q7weaMdUO5+BCmRA3QmrUJFPqkK EcUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=/gqfXgdh/mEpSJsHqR85PBOujlxEqs4qQYPY01fHzNw=; b=BjI3yR+7ZPWD1oJgq1ivr53aOsfl7muVB9wTTKukUKUMEDx9NdvOp+kkwuQrk6EvQD +pF2Iqru28qCz+zIVqzc0mqdyb8UOgtcvh8fmzOXR+tqNpxaSJApySlOxILJqQ1a+aBl 2igaK8uh5elhNMCORRLW+3olgBXgkBzY6EcW4fHVrVWyrkTkPhOS+aApTNkxGB6V8TnL oy1iZqw/K34Hy23KTqe5R56xduzDJRijAgMsAyZdVdDgnxuZ6+TglUPOQM/17Nn9ej5w FphH1L2peCBnt2rPLXlon+RdTEvarkSZfbHkbBpb+usB0oRPpRprPtcReDHVB+K5L+GN yqvw==
X-Gm-Message-State: AOAM531pL6Yu4s5c3VhWcWrsxAhPutl0NjtHi7NkNUk1cBATnqonLP3m DTWed6p7eGVU48T1OTKqkndVlzt/q5k=
X-Google-Smtp-Source: ABdhPJy41TTyAx4EeZNOMZ0xYwhkbQnnFjYzWGvrEePZblDrKPMDDe/yhGyBOhHOshjllGDCMh7V/w==
X-Received: by 2002:a7b:c5cc:: with SMTP id n12mr5436430wmk.123.1613538465826; Tue, 16 Feb 2021 21:07:45 -0800 (PST)
Received: from RoniPC (bzq-109-65-42-55.red.bezeqint.net. [109.65.42.55]) by smtp.gmail.com with ESMTPSA id i8sm2247930wry.90.2021.02.16.21.07.44 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 16 Feb 2021 21:07:45 -0800 (PST)
From: Roni Even <ron.even.tlv@gmail.com>
To: 'Ken Murchison' <murch@fastmail.com>, gen-art@ietf.org
Cc: calsify@ietf.org, draft-ietf-calext-valarm-extensions.all@ietf.org, last-call@ietf.org
References: <161338513250.5032.11173671129331374190@ietfa.amsl.com> <a87b7942-9976-39c5-43dd-23f4acfa9a6a@fastmail.com>
In-Reply-To: <a87b7942-9976-39c5-43dd-23f4acfa9a6a@fastmail.com>
Date: Wed, 17 Feb 2021 07:07:42 +0200
Message-ID: <244d01d704ea$d2e76f40$78b64dc0$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQJmwDIr8DqYv1HStF1XR4ItQwCmlAMJDWRfqSQMsPA=
Content-Language: he
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/rIomyI1vXtolIVKdtYH0l-XQZZo>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Feb 2021 05:07:50 -0000

Hi Ken,
Thanks, it is OK 
Roni

> -----Original Message-----
> From: Ken Murchison [mailto:murch@fastmail.com]
> Sent: Monday, February 15, 2021 2:27 PM
> To: Roni Even; gen-art@ietf.org
> Cc: calsify@ietf.org; draft-ietf-calext-valarm-extensions.all@ietf.org; last-
> call@ietf.org
> Subject: Re: Genart last call review of draft-ietf-calext-valarm-extensions-04
> 
> Hi Roni,
> 
> Thanks for the review.  Your comment is addressed below.
> 
> 
> On 2/15/21 5:32 AM, Roni Even via Datatracker wrote:
> > Reviewer: Roni Even
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed by
> > the IESG for the IETF Chair.  Please treat these comments just like
> > any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> >
> > Document: draft-ietf-calext-valarm-extensions-??
> > Reviewer: Roni Even
> > Review Date: 2021-02-15
> > IETF LC End Date: 2021-02-16
> > IESG Telechat date: Not scheduled for a telechat
> >
> > Summary:
> > The document is ready for publication as standard track RFC with nits
> >
> > Major issues:
> >
> > Minor issues:
> >
> > Nits/editorial comments:
> >
> > 1. The structured-location is optional so if it is not specified for
> > proximity I assume that it implies current location?
> 
> 
> STRUCTURED-LOCATION is optional because its not used for PROXIMITY:
> [DIS]CONNECT.  I've made the following change to the text:
> 
>               <t hangText="Description:">This property is used to
>               indicate that an alarm has a location-based trigger. Its
>               value identifies the direction of motion used to trigger
> -            the alarm. One or more location values are set using
> +            the alarm. One or more location values MUST be set using
>               "STRUCTURED-LOCATION" properties.</t>
> 
> Is this sufficient?
> 
> --
> Kenneth Murchison
> Senior Software Developer
> Fastmail US LLC

v2.23.0 | Report a Bug | By Email