Re: [Gen-art] review of draft-ietf-hip-dex-11.txt

Miika Komu <miika.komu@ericsson.com> Wed, 20 November 2019 16:24 UTC

Return-Path: <miika.komu@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D98AB12088F; Wed, 20 Nov 2019 08:24:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0BQwfMIag2Qm; Wed, 20 Nov 2019 08:24:46 -0800 (PST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2D1B91200F8; Wed, 20 Nov 2019 08:24:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJj90OOhW4FiarstMFVuNP4CPvUL6Mxf4rPOnCX8RocAG8Z6CodlpFvOu1uSK27YiMkQdGiu91azkiLu9WHfEkZ5Tev2Uju8f+BHjMHiYo1x9SLNu3/r9zKhk6HN27Y4slQRUwkz2zJhp0Qhnh9i6ZyVNjnQKlejVvwkTsX7pZ7FUVq6aaDK3JQkNjQYZwR0QBLbHnNmOONcSOuT24WOvEP1sMXfBWYOkvPYxsV+ucUTSGk+OuyhpJK+WVNduBjUY3m1OCiL10l6Pl/JA8JmwkwhKXXaciIagmc8yCbA5ZCvFS7VgpL/CfT2rlDOTw1N+tiuIxxzcGAsLdnIMBsKBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4iobbb+bH9OfJR10W2h7v/+H+QxWLar3IwzidJl/V0=; b=eT0Zbua05EVruc2Q9s2898NMIJPRf+jo45lC/mNbjlD6cmQHZrYuClutmlxFhCjTYuWwnQHjc14q8es+TqVZHuPQvUPNFFLvIb8yvdkL022vOI7ECbpC4P2p06ah4+nShZFqW5tltPAzgvr+6Be+Aw/hT0lQ68t4oZh+rZL3/HHZUzfyF0eEyyflaa3igmMpaVuZO3u+4wlTxq9HcriC19GJEItekbul7JEnaISheiTL2PHnz79erYBJllq7bqp9Kp1mXZvXKsm9796XEcLPMRtYMuMHxUUDhxce49aMvK7BA6n8+Gi7IAh/peAsQPDi/Ai7wrqALf6jODiwJTuJZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4iobbb+bH9OfJR10W2h7v/+H+QxWLar3IwzidJl/V0=; b=lVqlqc9uhUfW0+bOYDs2AFJFcF2ez4bIji1IfW2ZPV5fNI9CsKacHi2KRo8N6sFS9QEjP5MfxGvN6KyGV6uMB5zfzJZ+7DHENvUQYJO+rQdTcrfqIAD2l7rmaXilf4I2ZHD/eVwd03jq2xYrZqJ9ywqElCLqN6inaLRG44Vu6ms=
Received: from HE1PR0702MB3786.eurprd07.prod.outlook.com (52.133.7.16) by HE1PR0702MB3788.eurprd07.prod.outlook.com (52.133.5.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.13; Wed, 20 Nov 2019 16:24:43 +0000
Received: from HE1PR0702MB3786.eurprd07.prod.outlook.com ([fe80::3db1:a1b9:f919:f64a]) by HE1PR0702MB3786.eurprd07.prod.outlook.com ([fe80::3db1:a1b9:f919:f64a%6]) with mapi id 15.20.2474.018; Wed, 20 Nov 2019 16:24:43 +0000
From: Miika Komu <miika.komu@ericsson.com>
To: "Francis.Dupont@fdupont.fr" <Francis.Dupont@fdupont.fr>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-hip-dex.all@ietf.org" <draft-ietf-hip-dex.all@ietf.org>
Thread-Topic: review of draft-ietf-hip-dex-11.txt
Thread-Index: AQHVmv8Zmr5UjQgBxkyL0Ys6hzJNU6eUSAgA
Date: Wed, 20 Nov 2019 16:24:43 +0000
Message-ID: <d5d84c66abaa98f341110823125d8fccbb2a5e05.camel@ericsson.com>
References: <201911141428.xAEESkn0001499@givry.fdupont.fr>
In-Reply-To: <201911141428.xAEESkn0001499@givry.fdupont.fr>
Accept-Language: fi-FI, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Evolution 3.28.5-0ubuntu0.18.04.1
authentication-results: spf=none (sender IP is ) smtp.mailfrom=miika.komu@ericsson.com;
x-originating-ip: [89.166.49.243]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c274c84c-eac4-4c0d-8089-08d76dd62698
x-ms-traffictypediagnostic: HE1PR0702MB3788:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <HE1PR0702MB37888E8F8C0CD45B970D7F62FC4F0@HE1PR0702MB3788.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 02272225C5
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(54094003)(199004)(189003)(71190400001)(71200400001)(305945005)(44832011)(7736002)(478600001)(476003)(6512007)(229853002)(11346002)(486006)(2616005)(6306002)(66066001)(14454004)(6486002)(6436002)(446003)(50226002)(4326008)(2501003)(26005)(118296001)(316002)(186003)(86362001)(6116002)(25786009)(6246003)(66946007)(76116006)(91956017)(6506007)(102836004)(4001150100001)(66476007)(64756008)(66446008)(66556008)(256004)(14444005)(99286004)(76176011)(81166006)(2906002)(36756003)(110136005)(8936002)(3846002)(81156014)(5660300002)(8676002)(99106002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0702MB3788; H:HE1PR0702MB3786.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: w780tt2n1cJAmdAs28RbEQ8/xa5m+qreOn7m+yXpixbQewjMelppexMUB4zT4zbpk7E6cdrh2Tls25ityCV232dqIKEeRUwO0lEJzdqlN7NnhDgOWYU1jmgARKLwu2qc4s3MWm7YDLy1uxgYzcvVu0uuqJ46IIDWzrIgXGgF9eYCAJzWfdy3AdvOln2YGut7l1o5In+rYKzUDbTm96rCdsvRWxfF/ZiwCN9BWtXh6qlzFtQ4NPqQRwjLLRyH9XyK69em5Yf7yLm5BImqrUPhkZMi7nFgOfatFi5qaCX0rZBR6ECEG8qn7tIiOCcJ9NCIxjgxgs8OBqyNOqG0uVgU4KlUrcVNXpQURSE8HY9r3EQSAhn5OnUPypKKSXv9l5ky5UMu21NBPNGxhs+QttNtxsh7LhwU2n9wZsNYXn5yUtVWR3a6s5ju17q48GV50Pmu11gelFzDNvQm22hbCBBAz/WDB+meHZRejsC5gt/FdgY=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <EE825787E53AD8418E8037B84CED5157@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c274c84c-eac4-4c0d-8089-08d76dd62698
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2019 16:24:43.3252 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YrOZVCumU1KSgx8Eu08c/WFRi8wdbB82Nz76oSyJFC2COtDbJecOuK8UDmiS1A5OFkiQ7G4n4nwEKxLT/6dQGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0702MB3788
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/rX1aKVGjipxzM25vFhwxQ-wWEx0>
Subject: Re: [Gen-art] review of draft-ietf-hip-dex-11.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Nov 2019 16:24:49 -0000

Hi Francis,

thanks for you feedback, it will be visible in the next version of the
HIP DEX document.

to, 2019-11-14 kello 15:28 +0100, Francis Dupont kirjoitti:
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-hip-dex-11.txt
> Reviewer: Francis Dupont
> Review Date: 20191107
> IETF LC End Date: 20191114
> IESG Telechat date: unknown
> 
> Summary: Ready
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
>  - 1.2 page 6: highligts -> highlights

fixed thanks!

>  - 3 page 8: RFC 6090 does not fully define ECDH because of the
> "compact"
>   representation. Now it is a detail and if it can have an impact for
>   implementors I think the security directorate will ask for a
> clarification
>   (and in general I rely on the security directorate for all security
>    related points, for instance whether DEX has a formal proof of its
>    security properties)

we have ongoing discussion on this topic (some disclaimer will be added
to the intro).

>  - 5.3.2 page 23: return-routablility -> return-routability

fixed, thanks

>  - 4.1.1 page 11: I wonder if the puzzle solution check includes the
>   check of the puzzle itself but the remark saying with K=0 the
> puzzle
>   is just a retrun-routability cookie provided an answer... (so
> nothing
>   to change)

I guess no change is needed, but just for clarification:

k=0: return routability cookie
k>0: return routability + DoS prevention

>  - at the exception of the Acknowledgments section you use the
> English
>   spelling (with a 'e'): it is consistent with other HIP documents so
>   I have no problem with this.

I changed Acknowledgments to Acknowledgements

>  - 4.1.3.1 page 14: "and he system" -> "and the system"
> 
>  - 9 page 42: perhaps a SHOULD in "Thus, any signaling
>       that indicates such anonymity should be ignored as explained in
>       Section 1.1." ?
> 
>  - 9 page 43: computated -> computed
> 
>  - B page 50: IEDG -> IESG

fixed.