Re: [Gen-art] Genart last call review of draft-ietf-ntp-using-nts-for-ntp-22

Ragnar Sundblad <ragge@netnod.se> Thu, 27 February 2020 16:56 UTC

Return-Path: <ragge@netnod.se>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BDAA3A0C92 for <gen-art@ietfa.amsl.com>; Thu, 27 Feb 2020 08:56:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=netnod-se.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9mv6HeONiHwD for <gen-art@ietfa.amsl.com>; Thu, 27 Feb 2020 08:56:13 -0800 (PST)
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 95A893A0C90 for <gen-art@ietf.org>; Thu, 27 Feb 2020 08:56:13 -0800 (PST)
Received: by mail-lf1-x132.google.com with SMTP id b15so2623318lfc.4 for <gen-art@ietf.org>; Thu, 27 Feb 2020 08:56:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netnod-se.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lGbUroYpzvyCRiZBsXUfX/WrU9y20NxXaHumWfayGYw=; b=PWsYzRUKgzpxnyrKAacYutIP9eLozvEYqpYWl3a+urm5hgPqfNIyX2Y4JCevYhDf/I ZuwrQw5dThsUoEurcRuEcd9l/1S42BQCcwvOvQ8eDrqF2wV5p+f5NeeqOz0FIHr6WoZH GUDjODx4mLdDOkWzRA6jxocR2TBiHiwmnUdIK5SZnmNjqgwj7DPQJmnNulnUBTHMWuSh QdDC0HyIc0pZfokaM8huyxqW1vWdWeeNiB01K8d1IQafvwZSE/2zh9lsoTfpZPcVrhW7 kMuu+Oze9osKuqOl1sksAzKw3s0JLtopIkgIZCcFeLAmkK+0g224W8ogyvyEXUnuM9sL +YpQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lGbUroYpzvyCRiZBsXUfX/WrU9y20NxXaHumWfayGYw=; b=J7aLWnl+MVYn+iu2Vucd1XiCi0LjuPFBdyvWmDwf3SCOzm/CjEGS0/s4njQtSjuHVX G7hmL+K0GpGDgk1WApacNB8wo8ns24/mXvA/AIsiEhgVVyfBYBhlhe9uAMUdBc4OaCMq uW28FcZu08jWqqwtfGAJJ+0h0RSkeHirW5KApt5B7VRp38NzYGNt5r+TrFBKhq72yhv3 Bnj1GWNnfTemfbchrXqohdPFD9lTWuhNXazm2tFFQRG2FKONOljHVqIdVUZxkzkFBRWA yIMrYLvv/FtVFIcyPF8ygDmSYiLrh1RD89TOoTFzB5TTOLwXkAiakdwfGKLIT7lZi5fc zOAQ==
X-Gm-Message-State: ANhLgQ0vlVqaQDN9SyE38n763WK1613q9e16BwSAhtzig8zJeXuNMVTR T+OsqHObqzQMNH/NOWGKh6f1iv6x6DE=
X-Google-Smtp-Source: ADFU+vu0tQqrjvxt074yQ4wgT4po2p+3GsWbHr+GGUxryg8fnBsBIVqu7EmcsdaVrVQA7tShhM/48A==
X-Received: by 2002:a19:840d:: with SMTP id g13mr185518lfd.162.1582822571751; Thu, 27 Feb 2020 08:56:11 -0800 (PST)
Received: from ?IPv6:2001:6b0:1:1041:c462:4d75:ed2b:fce1? ([2001:6b0:1:1041:c462:4d75:ed2b:fce1]) by smtp.gmail.com with ESMTPSA id h19sm3579171ljl.57.2020.02.27.08.56.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Feb 2020 08:56:10 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
From: Ragnar Sundblad <ragge@netnod.se>
In-Reply-To: <158271156883.17827.13215176673371446527@ietfa.amsl.com>
Date: Thu, 27 Feb 2020 17:56:10 +0100
Cc: gen-art@ietf.org, draft-ietf-ntp-using-nts-for-ntp.all@ietf.org, ntp@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <28B9F231-09E7-4EC4-ACB3-1A9C4BFB8513@netnod.se>
References: <158271156883.17827.13215176673371446527@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-Mailer: Apple Mail (2.3608.60.0.2.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/re3c5ANSNmsXjJIfRXtdd0C1-q4>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ntp-using-nts-for-ntp-22
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Feb 2020 16:56:16 -0000

Hi Dan,

Thank you for reviewing!

On 26 Feb 2020, at 11:06, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dan Romascanu
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ntp-using-nts-for-ntp-22
> Reviewer: Dan Romascanu
> Review Date: 2020-02-26
> IETF LC End Date: 2020-02-28
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> Ready with one minor issue to be discussed.
> 
> A very clear, well written, nicely organized document.
> 
> Major issues:
> 
> Minor issues:
> 
> 1. The tables in Sections 7.6, 7.7, 7.8 state that all undefined values in the
> registries start immediately after the values defined by this document with
> 'Reserved for Private and Experimental Use'. What about future extensions in
> future versions of the document? Would not it be better to leave a range for
> future extensions and start the values for private and experimental use farther
> in the total spaces?

We are not sure what you mean - we believe that the tables say that the upper halves of the spaces are 'Reserved for Private and Experimental Use’, while the lower halves are unallocated except for those values that are specified in the draft.

Do you have an example of how you would want it to be written/formatted instead?

> Nits/editorial comments:
> 
> 1. In the (very useful) Appendix A for Terms and Abbreviations, there are a few
> abbreviations usually considered part of the shared basis terms in IETF
> documents (like TCP, UDP, IANA, ...)

Ok - Marcus is doing that right now.

Best regards,

Ragnar