Re: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39

Thomas Haynes <thomas.haynes@primarydata.com> Wed, 06 January 2016 16:16 UTC

Return-Path: <thomas.haynes@primarydata.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 08AFD1B2DDA for <gen-art@ietfa.amsl.com>; Wed, 6 Jan 2016 08:16:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hxDdu4olut1E for <gen-art@ietfa.amsl.com>; Wed, 6 Jan 2016 08:16:34 -0800 (PST)
Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D8A3B1B2DD9 for <gen-art@ietf.org>; Wed, 6 Jan 2016 08:16:33 -0800 (PST)
Received: by mail-pf0-x231.google.com with SMTP id e65so188186834pfe.1 for <gen-art@ietf.org>; Wed, 06 Jan 2016 08:16:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primarydata-com.20150623.gappssmtp.com; s=20150623; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6XSC7pY+I5L+HrDB5TFpyTt8/7u8+h411E+Zpyrpe6s=; b=HbvmDeO5UHO/9Zuipb/7GTXoH5ATRnUvt+kiNJdLPSeoPX755QdrrVUDkJeiFUZcWV M1+Zne71UxGGBK349c4xib7urbB3patG/PX9b0ot6GcG1m8ifhmV18sipnEpUuwkDbU9 45T4jUl1NoFChFORR2U8rcspzznJKrZQ7I/vnhYoTzNphRC79XYb+k0/T74idzKRcT+Q v2pKpP+99n/ljpCke3Py+MV8Jq/X0PswUELAYIAOseBid/f4n4q/ucbciKJWmKioqKA6 wkMAjHxaIi7ewqXrqnWLHOVIZX/TV8rWrBXG7mO3E9zXEHO0eJoGCVXEmo9PfeIPXHmf ovZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=6XSC7pY+I5L+HrDB5TFpyTt8/7u8+h411E+Zpyrpe6s=; b=JHPJhtn7oaQ8AsRucoS2/D8AgZ7O7AITvTW2QEkFl1cYXZHratMjazSoT2L6keFduB jjRKOZgXi+aTlHnUo149S52xS5Y5XdsVJc6Lw/1SbxdtUVAFFQMjswq8X1TYWrKxg8Yj mGCepk9UWzkMI3+OEXOfyVIBRtrf6shx1C2LqRxAOzCGe4yPY30R1vXxRTFvBvW23fIm rtihQG7U0twA77BaioeUmSbqmOi9kbPhjvRX/dv7G3Cka+olIhrfVLAkLzu7uAW9rEm1 N4uhE9hHgFwlH7hANm3q5cAl3xIC72Lh1r/nSkolx+XZN0aIE0F5vg15o+rrqRN7ia4g zJMA==
X-Gm-Message-State: ALoCoQk6zDWsdkH4RqtnhefP524ICcW77ujtk98NTL9g2PdL3hjKKyqchkl8gcob79YHYODQ+8duagGB82ALtztmc9DQrN2Qew==
X-Received: by 10.98.14.134 with SMTP id 6mr12969929pfo.6.1452096993486; Wed, 06 Jan 2016 08:16:33 -0800 (PST)
Received: from ?IPv6:2601:647:4400:e4be:5cd2:d198:527d:217e? ([2601:647:4400:e4be:5cd2:d198:527d:217e]) by smtp.gmail.com with ESMTPSA id sy5sm141785124pac.5.2016.01.06.08.16.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Jan 2016 08:16:32 -0800 (PST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
From: Thomas Haynes <thomas.haynes@primarydata.com>
In-Reply-To: <568C76C7.7000101@folly.org.uk>
Date: Wed, 6 Jan 2016 08:16:31 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <34B0F143-BD62-43FB-BE14-6F44D420F0BB@primarydata.com>
References: <566E10D8.3040002@dial.pipex.com> <224DB6F8-608F-44E1-8D72-0BDAB8CA3120@primarydata.com> <56731678.1000004@dial.pipex.com> <568C76C7.7000101@folly.org.uk>
To: Elwyn Davies <elwynd@folly.org.uk>
X-Mailer: Apple Mail (2.3112)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/rllTx3ZTNnZIvzgJ3lSggncFxYc>
Cc: General area reviewing team <gen-art@ietf.org>, draft-ietf-nfsv4-minorversion2-dot-x.all@ietf.org, William.Adamson@netapp.com
Subject: Re: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2016 16:16:38 -0000

> On Jan 5, 2016, at 6:07 PM, Elwyn Davies <elwynd@folly.org.uk> wrote:
> 
> Hi, Tom.
> 
> The existence of draft-ietf-nfsv4-rfc3530-migration-update was pointed out to me this evening.  After a cursory read I realised that SETCLIENTID had been MNI'd in 4.1 so that there is a minor infelicity in the comments in minorversion2-dot-x (and in 4.1).
> 
> The comment here:
>>    /// /*
>>    ///  * Program number is in the transient range since the client
>>    ///  * will assign the exact transient program number and provide
>>    ///  * that to the server via the SETCLIENTID operation.
>>    ///  */
>>    /// program NFS4_CALLBACK {
>>    ///         version NFS_CB {
>>    ///                 void
>>    ///                         CB_NULL(void) = 0;
>>    ///                 CB_COMPOUND4res
>>    ///                         CB_COMPOUND(CB_COMPOUND4args) = 1;
>>    ///         } = 1;
>>  
> is not correct for versions 4.1 and 4.2.  The program number comes from CREATE_SESSION or BACKCHANNEL_CTL in versions 4.1 and 4.2.
> 
> Please update the comment to reflect the current situation.

Done

> 
> Cheers,
> Elwyn
> 
> 
> On 17/12/2015 20:09, Elwyn Davies wrote:
>> Hi, Tom.
>> 
>> Excellent... so I think we are done with dot-x.
>> 
>> One additional point that I was going to write into the main minorversion2 review relating to referencing  the requirements RFC 7204.  rpcsec-gssv3 also references the requirements RFC but the amount of info that is needful to  support implementers seems to be mostly in minorversion2.  Would it be possible for you and Andy to work out if anything extra is really needed in minorversio2 (about guest mode primarily I think) so that the requirements reference is not needed and rpcsec-gssv3 can just reference minorversion2 for all info on the modes?  I wasn't sure what, if anything, extra was needed in minorversion2.
>> 
>> Cheers,
>> Elwyn
>> 
>> On 17/12/2015 02:19, Tom Haynes wrote:
>>>> On Dec 13, 2015, at 4:44 PM, Elwyn Davies <elwynd@dial.pipex.com> wrote:
>>>> 
>>>> I am the assigned Gen-ART reviewer for this draft. The General Area
>>>> Review Team (Gen-ART) reviews all IETF documents being processed
>>>> by the IESG for the IETF Chair.  Please treat these comments just
>>>> like any other last call comments.
>>>> 
>>>> For more information, please see the FAQ at
>>>> 
>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>> 
>>>> Document: draft-ietf-nfsv4-minorversion2-dot-x-39.txt
>>>> Reviewer: Elwyn Davies
>>>> Review Date: 2015-12-13
>>>> IETF LC End Date: 2015-12-09
>>>> IESG Telechat date: (if known) -
>>>> 
>>>> Summary: Ready with nits.  The XDR specification appears to be a superset of the v4.1 XDR specification and combines a correction of the five remaining discrepancies between v4.1 and v4.0bis ( definition and use of the NFS4_OTHER_SIZE constant, addition and use of the ascii_REQUIRED4 type, modification of the typedef of linktext4). The additions of the 4.2 interface appears to match the specification in draft-ietf-nfsv4-minorversion2-39 except for two attribute typedef  items mentioned below.  One discrepancy would have no operational effect as the type used in the other draft  is an alias for the type used here but the clone_blksize error changes the size of the type.
>>>> 
>>>> I have checked that the extracted code is accepted by rpcgen and generates files as expected.
>>>> 
>>>> Major issues:
>>>> None
>>>> 
>>>> Minor issues:
>>>> None
>>> 
>>> 
>>> Hi Elwyn,
>>> 
>>> Thanks for the review - sorry for the delay in responding, I’m just now surfacing from my job. :-)
>>> 
>>> Responses inline.
>>> 
>>>> Nits/editorial comments:
>>>> Observation:  It might be useful to note that this XDR specification is fully upwards compatible with the v4.0bis with the minor exception of the clientaddr4 structure which has been replaced by (strictly, aliased to) netaddr4 which has the same members with the same purposes but the names have changed (r_netid -> na_r_netid, r_addr ->na_r_addr). This effectively fully reconverges the v4.0bis and v4.1 strands of the XDR.
>>>> 
>>> Shamelessly stolen almost verbatim!
>>> 
>>>> Line 1145: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 fattr4_space_freed
>>>>                    whereas in this draft we have                           typedef uint64_t fattr4_space_freed
>>> Fixed this in the XDR document.
>>> 
>>>> Line 1149: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 fattr4_clone_blksize
>>>>                    whereas in this draft we have                           typedef uint32_t fattr4_clone_blksize
>>> 
>>> And for this one, I made the change to uint32_t in draft-ietf-nfsv4-minorversion2-39 .
>>> 
>>> Thanks again!
>>> Tom
>>> 
>> 
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
>