[Gen-art] Gen-ART Telechat Review of draft-ietf-pim-pop-count-06

Pete McCann <mccap@petoni.org> Wed, 20 June 2012 00:08 UTC

Return-Path: <mccap@petoni.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DCA5211E80F6 for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 17:08:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.977
X-Spam-Level:
X-Spam-Status: No, score=-2.977 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DJZ+ND-AyCNM for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 17:08:33 -0700 (PDT)
Received: from mail-pz0-f44.google.com (mail-pz0-f44.google.com [209.85.210.44]) by ietfa.amsl.com (Postfix) with ESMTP id 3ACD711E80A0 for <gen-art@ietf.org>; Tue, 19 Jun 2012 17:08:33 -0700 (PDT)
Received: by dacx6 with SMTP id x6so9179329dac.31 for <gen-art@ietf.org>; Tue, 19 Jun 2012 17:08:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petoni.org; s=google; h=mime-version:x-originating-ip:date:message-id:subject:from:to :content-type; bh=Yl8U37D13j0eaSGMTSBNc5RylvCaAKpncdmPk72BPUM=; b=SlHRL6AdkDvZnq4a74wZyLNLpOQK6OJWT3FHXld1hBxspmA1S+Fmj+gF0kPvMSd6kE OBC+hWwCC/iiUBSZyQJmBwpz9Gqp017VThLYJqb1DheDBMgnSmLXvX0EDAXp4+fsqlB2 zAqLczLIO7mgoALxNXZ280mled2+v0HB9Ao5c=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=Yl8U37D13j0eaSGMTSBNc5RylvCaAKpncdmPk72BPUM=; b=UuCTDVqyjHAOWZ+nw/vl3wOGb4QIvNfBNnKQ5aNNWf9Bgk4Kj5AtMotoDJf7H3Apso lpv1Q96ucNkRnj+33q0ypm9Z6di2MGOUtu8oIotMBMgalemERyDh1xFpeOQTeYClOfL9 ETJsdfP126I/FJYVzQclGOIw+y/GlRYJa72LURHAcQT4I862eX57W0gj4y7BNcZOZCBg i+FDO3qrjLIdBUjTIRblc9s+EUFpeWqLC9+RNdKXhGpm5/0Pj0A6lWaWzWRzNzajoTpN sUr4I0SRHnc7oFWz++4oq7sKMKRSWNo8iTRiFODJivhaSia2DgxPtBK4SfzXQOnes9pq VU5A==
MIME-Version: 1.0
Received: by 10.68.191.201 with SMTP id ha9mr70292047pbc.75.1340150912967; Tue, 19 Jun 2012 17:08:32 -0700 (PDT)
Received: by 10.68.213.99 with HTTP; Tue, 19 Jun 2012 17:08:32 -0700 (PDT)
X-Originating-IP: [68.45.157.93]
Date: Tue, 19 Jun 2012 20:08:32 -0400
Message-ID: <CACvMsLHQKYm41iw85cJzoF1rOs6DXW7jhJH9L9Tdy5cD3UjjMw@mail.gmail.com>
From: Pete McCann <mccap@petoni.org>
To: gen-art@ietf.org, draft-ietf-pim-pop-count.all@tools.ietf.org
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQlBqY2BR8s6sABJTt4f1q+W8IRALgRUpJlmpgls3v2rE7A/DC9zN8DFYY3jAMhzyYbGG0bF
Subject: [Gen-art] Gen-ART Telechat Review of draft-ietf-pim-pop-count-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 00:08:34 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
< http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>gt;.

Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-pim-pop-count-06
Reviewer: Peter McCann
Review Date: 2012-06-19
IETF LC End Date: 2012-06-12
IESG Telechat date: 2012-06-21

Summary: 2 minor issues

Major issues: none

Minor issues:

The Transit and Stub oif-List counts are only 2 octets.  Will these
fields be large enough to contain
the totals for a large multicast distribution tree?

Are there any alignment constraints on the options?  It looks like all
the two-octet options come first
and the single-octet options come last.  However, is this a
requirement for any future options that may
be defined?


Nits/editorial comments:

The descriptions of how the counts are maintained could use a little
clarification.  For example,
when you say:

   Transit Oif-List Count:   This is filled in by a router sending a
      Join/Prune message which is equal to the number of oifs (outgoing
      interfaces) for the multicast route that has been joined by PIM.
      This indicates the transit branches on a multicast distribution
      tree (no members on the links between this router and joining
      routers).  This is added to the value advertised by all downstream
      PIM routers that have joined on this oif.  Length 2 octets.

it isn't clear what you mean by "which is equal to". Literally, you
are saying the Join/Prune message
is equal to something.  I don't think that's quite right.  Did you
mean "with a number that is equal to"?
Maybe, "with a number that is equal to the number of oifs (outgoing
interfaces) for the multicast
route that has been joined by PIM, plus the values advertised by all
downstream PIM routers that
have joined this oif."



-Pete