Re: [Gen-art] Gen-Art telechat review: draft-hansen-scram-sha256-04 (was Re: Gen-art (second) LC review: draft-hansen-scram-sha256)

Jari Arkko <jari.arkko@piuha.net> Wed, 02 September 2015 19:02 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6131B1B49AD; Wed, 2 Sep 2015 12:02:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CN39D35IXdGS; Wed, 2 Sep 2015 12:02:50 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id 0C9BE1B495B; Wed, 2 Sep 2015 12:02:50 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 53BB92CD02; Wed, 2 Sep 2015 22:02:49 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XZhMEVKgVc10; Wed, 2 Sep 2015 22:02:48 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 768882CC5C; Wed, 2 Sep 2015 22:02:48 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_36ECE59B-9002-4344-BD09-D324198741D3"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5.1
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <55E5F476.9080707@nostrum.com>
Date: Wed, 02 Sep 2015 22:02:46 +0300
Message-Id: <E7194464-7BBE-4DCA-9EF6-F1DFF9B7E6C8@piuha.net>
References: <551D8D6E.8010307@nostrum.com> <55C107C7.9020001@nostrum.com> <55E5F476.9080707@nostrum.com>
To: Robert Sparks <rjsparks@nostrum.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/sA829GtMaV32WzFUr6ND21CDLr4>
Cc: General Area Review Team <gen-art@ietf.org>, draft-hansen-scram-sha256@ietf.org, Stephen Farrell <stephen.farrell@cs.tcd.ie>
Subject: Re: [Gen-art] Gen-Art telechat review: draft-hansen-scram-sha256-04 (was Re: Gen-art (second) LC review: draft-hansen-scram-sha256)
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2015 19:02:55 -0000

thanks for your review again, Robert!

Jari

On 01 Sep 2015, at 21:54, Robert Sparks <rjsparks@nostrum.com> wrote:

> For completeness in the gen-art archives and so that Jari doesn't have to go looking:
> 
> (boilerplate elided)
> 
> Summary: Ready for publication as a Proposed Standard
> 
> On 8/4/15 1:43 PM, Robert Sparks wrote:
>> (apologies to the genart list who will see this as a duplicate):
>> 
>> I am the assigned Gen-ART reviewer for this draft. For background on
>> Gen-ART, please see the FAQ at
>> 
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>> 
>> Please resolve these comments along with any other Last Call comments
>> you may receive.
>> 
>> Document: draft-hansen-scram-sha256
>> Reviewer: Robert Sparks
>> Review Date: 04-Aug-2015
>> IETF LC End Date: 25-Aug-2015
>> IESG Telechat date: not yet on any telechat
>> 
>> Summary: Ready for publication as a Proposed Standard
>> 
>> The change to PS addresses the concern I expressed in the review below.
>> miniscule-nit: I still think the extra URI section after the references is not needed.
>> 
>> RjS
>> 
>> On 4/2/15 1:41 PM, Robert Sparks wrote:
>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>> Gen-ART, please see the FAQ at
>>> 
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>> 
>>> Please resolve these comments along with any other Last Call comments
>>> you may receive.
>>> 
>>> Document: draft-hansen-scram-sha256
>>> Reviewer: Robert Sparks
>>> Review Date: 2Apr2015
>>> IETF LC End Date: 24Apr2015
>>> IESG Telechat date: (if known)
>>> 
>>> Summary: Ready for publication as Informational, with nits that should be considered.
>>> 
>>> Nits/editorial comments:
>>> 
>>> Nit:
>>> It raises flags for me when an Informational document uses "Updates" on a standards track document.
>>> I would argue that this does _not_ update 5802. IANA did the things that 5802 requested, and this document
>>> is requesting something else that happens to change those things. That makes this more of a "see also" than
>>> a "the protocol changed", and I think the Updates should be removed.
>>> 
>>> I don't feel super strongly about the difference in _this particular case_, hence its classification as a Nit.
>>> But for consistency, and avoiding the issue of having an Informational update a PS, I hope you choose to remove it.
>>> 
>>> Editorial comment:
>>> The URLs in the references section seem superfluous since you've already expanded them in the introduction?
>>> 
>>> _______________________________________________
>>> Gen-art mailing list
>>> Gen-art@ietf.org
>>> https://www.ietf.org/mailman/listinfo/gen-art
>> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art