Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10

Alissa Cooper <alissa@cooperw.in> Wed, 30 October 2019 15:25 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E83E51200A4; Wed, 30 Oct 2019 08:25:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=T3FqTEZd; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=u6C0tS9Q
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W_P1JMX7mrf0; Wed, 30 Oct 2019 08:25:28 -0700 (PDT)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D6AC12002F; Wed, 30 Oct 2019 08:25:28 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 29DBC4F5; Wed, 30 Oct 2019 11:25:27 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 30 Oct 2019 11:25:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm1; bh=pFONOjIv2/vU23JCCDDfGR7 uS6EaSiGv1tLjryj5zrs=; b=T3FqTEZdRvItfC0P3fQ+N4uy4xKBo/eSqpj6f7k fQQGdnkUnJASlTtKtV3R2sCt1X8koxEz5sJlK0+0jxZajvA/IJKNyFJ5Ts+clXQk Abh20fGjVt5EYR0CYv73iZ8wREpfQvsMBRjWwU4nTAKBgAKmckJ0/hoJLJVqRGhE DgOe5sF4EC5CM9q0ChzRb/BPz03JpOcQnioNi0UkPF8mmXcJCTh5tdZrjFF4R8aN +gS/GEOrUMn/KjTaU1ZRWcEzwcBaYKRqig3H9TKjqrfVhRaMi7UH8uHnmvmRVbkM bs5KkT3vRoA6ZZkrFsJBZPWUge9WEWd9jGh92VNw761FqSQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=pFONOj Iv2/vU23JCCDDfGR7uS6EaSiGv1tLjryj5zrs=; b=u6C0tS9QtDo6JNhRdTDkMT SEj4+CJg4xaOg0oaUKY2JA6WQV24YSsb0Ag57tvRXELZAxy683zkSWJTy4uZ7SLd intCXK6x3G6IWm2mybIeUO/TLdIplDlWSQ6yD9TFl4+6WVbzBY4A2ejsBCf0z8Sl 3xu3Yfa/7PWsLG+dE7WvXX1GVtxfT7R+HFiY+j/rfZsFd52AhO1JWL3aozMxB6ju dNESUUyCq5ckWcX/Y7Kl+KL0WFMY1tDqzcd+6b4HslyJyG7b/oD3ijpr4gLIbtx+ RZMldc9uQhJ2zb+A8znjo9mbeCtEkiuXve2KGALuwP4StY8b25SfMAhfMwjzYFxQ ==
X-ME-Sender: <xms:Zqu5XWImOnpLOC3aSy-7Za0Sc_lwM_sK7sTH33yATHecY8lwNUtVuw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddtfedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgfvfhfosegrtdhmrehhtddvnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomhgrih hnpehivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrdeileenucfrrghrrghm pehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhushhtvg hrufhiiigvpedt
X-ME-Proxy: <xmx:Zqu5XSZZu0gmt0R4RHCBtaXpbd7ci4iZPij0VPaXACY81QcIAsNYuQ> <xmx:Zqu5XRsGkC6pjXsNTvt6Z848dttegAWd1K04I2E4Rf3WPQBJhAwesA> <xmx:Zqu5XfvksVI5xFgp6Pbc6rQeIxyBO4CcRC5b32qZDxkKw3NkIofDTA> <xmx:Zqu5Xfas0QQ32yii99p3csWo3EqKQ8u_IQUZoyofaYIUSdAFgyXKiQ>
Received: from rtp-vpn2-1786.cisco.com (unknown [173.38.117.69]) by mail.messagingengine.com (Postfix) with ESMTPA id 8882A8005B; Wed, 30 Oct 2019 11:25:25 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <1DF9384F-1107-4971-B86D-429959A409BE@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_E7EA0859-22FF-4793-B62C-6859EB9B0C95"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 30 Oct 2019 10:25:24 -0500
In-Reply-To: <6E58094ECC8D8344914996DAD28F1CCD23D931BF@DGGEMM506-MBX.china.huawei.com>
Cc: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>, "last-call@ietf.org" <last-call@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, SIPCORE <sipcore@ietf.org>, "draft-ietf-sipcore-digest-scheme.all@ietf.org" <draft-ietf-sipcore-digest-scheme.all@ietf.org>
To: "Roni Even (A)" <roni.even@huawei.com>
References: <157173348155.3011.12458315336826264414@ietfa.amsl.com> <CAGL6epLBJQgEH=F9V9daEAsn3P9BWjcXsgx8K15k-Vk9FcVWmg@mail.gmail.com> <6E58094ECC8D8344914996DAD28F1CCD23D93020@DGGEMM506-MBX.china.huawei.com> <CAGL6epK0_2JvAmbUU7iiBDZoxfwnWJnoZWJRsQaG54ObdM6NEA@mail.gmail.com> <6E58094ECC8D8344914996DAD28F1CCD23D931BF@DGGEMM506-MBX.china.huawei.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/sGnlcY67s9Cb8B00sxH8N5mzDxs>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2019 15:25:30 -0000

Roni, thanks for your review of this document. Rifaat, thanks for responding. I entered a DISCUSS ballot to chat about a remaining issue with the ABNF.

Best,
Alissa


> On Oct 23, 2019, at 7:28 AM, Roni Even (A) <roni.even@huawei.com> wrote:
> 
> HI Rifaat,
> OK, no other comments
> Roni
>  
> From: Rifaat Shekh-Yusef [mailto:rifaat.ietf@gmail.com <mailto:rifaat.ietf@gmail.com>] 
> Sent: Wednesday, October 23, 2019 3:25 PM
> To: Roni Even (A)
> Cc: Roni Even; last-call@ietf.org <mailto:last-call@ietf.org>; gen-art@ietf.org <mailto:gen-art@ietf.org>; SIPCORE; draft-ietf-sipcore-digest-scheme.all@ietf.org <mailto:draft-ietf-sipcore-digest-scheme.all@ietf.org>
> Subject: Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
>  
> Hi Roni,
>  
> I agree with the ABNF issue. I will fix that in the next version of the draft.
>  
> Thanks,
>  Rifaat
>  
>  
> On Wed, Oct 23, 2019 at 1:43 AM Roni Even (A) <roni.even@huawei.com <mailto:roni.even@huawei.com>> wrote:
> Rifaat thanks,
> See in line
> Roni
>  
>  
> On Tue, Oct 22, 2019 at 4:38 AM Roni Even via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
> Reviewer: Roni Even
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>>.
> 
> Document: draft-ietf-sipcore-digest-scheme-??
> Reviewer: Roni Even
> Review Date: 2019-10-22
> IETF LC End Date: None
> IESG Telechat date: 2019-10-31
> 
> Summary:
> The document is almost ready for publication as a standard track RFC
> 
> Major issues:
> 
> Minor issues:
> 
> 1. In section 2.4 " If the UAC cannot respond to any of the challenges in the
> response, then it SHOULD abandon attempts to send the request, e.g. if the UAC
>    does not have credentials or has stale credentials for any of the realms,
>    unless a local policy dictates otherwise." Yet RFC3261 section 22.2 " If no
>    credentials for a realm can be located, UACs MAY attempt to retry the
>    request with a username of "anonymous" and no password (a  password of "").
>    Is this deprecated ?
> 
>  
> No, it is not deprecated by this document, and that part is covered by the last sentence of the quoted paragraph, which talks about a local policy.
>  
> RE: I have no strong feeling it is just that the language is different
>  
>  
> 2. RFC3261 algorithm includes "MD5-sess" while section 2.6 removed it
>  
> These changes are provided in the context of RFC7616, so if an implementation supports "-sess" it could always refer to that document for these details.
>  
> RE: I think that the BNF
> algorithm = "algorithm" EQUAL ( "MD5" / "SHA-512-256" / "SHA-256"/ token ) 
> should be 
> algorithm = "algorithm" EQUAL ( "MD5" / "MD5-sess / "SHA-512-256" / "SHA-256"/ token )
>  
>  
>  
> 
> 3. it may be good to have a backward compatibility section.
> 
> I believe we covered that in the security consideration section. Do you see anything missing there?
>  
> RE: OK, no problem.
>  
> Regards,
>  Rifaat
>  
>  
> Nits/editorial comments:
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>