IETF Logo Mail Archive

[Gen-art] Gen-ART Last Call review of draft-ietf-mboned-mtrace-v2-21

Meral Shirazipour <meral.shirazipour@ericsson.com> Fri, 17 November 2017 20:57 UTC

Return-Path: <meral.shirazipour@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 185A0124BAC; Fri, 17 Nov 2017 12:57:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i2rK-2NEW0XR; Fri, 17 Nov 2017 12:57:13 -0800 (PST)
Received: from usplmg20.ericsson.net (usplmg20.ericsson.net [198.24.6.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DCF9E1205D3; Fri, 17 Nov 2017 12:57:09 -0800 (PST)
X-AuditID: c618062d-8d7ff70000004288-53-5a0f4d2413ff
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id FB.27.17032.42D4F0A5; Fri, 17 Nov 2017 21:57:09 +0100 (CET)
Received: from EUSAAMB104.ericsson.se ([147.117.188.121]) by EUSAAHC002.ericsson.se ([147.117.188.78]) with mapi id 14.03.0352.000; Fri, 17 Nov 2017 15:57:08 -0500
From: Meral Shirazipour <meral.shirazipour@ericsson.com>
To: "draft-ietf-mboned-mtrace-v2.all@ietf.org" <draft-ietf-mboned-mtrace-v2.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART Last Call review of draft-ietf-mboned-mtrace-v2-21
Thread-Index: AdNf5pDCR++L8p2/QUWtCRBkHz+m2g==
Date: Fri, 17 Nov 2017 20:57:07 +0000
Message-ID: <ABCAA4EF18F17B4FB619EA93DEF7939A4F638E24@eusaamb104.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.117.188.10]
Content-Type: multipart/alternative; boundary="_000_ABCAA4EF18F17B4FB619EA93DEF7939A4F638E24eusaamb104erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsUyuXSPn66qL3+UweVz/BYfpj9ltrj66jOL A5PHkiU/mQIYo7hsUlJzMstSi/TtErgyrq+ay1Kwwb3iwYGzLA2Mx227GDk5JARMJG72nmTs YuTiEBI4wiixdutJVghnOaPE9yk32UCq2AQsJLb/fg6WEBFoYZTYeK2RHSQhLOAs8erMM1YQ W0TAQ+LYhp3sELaexMX2F0BjOThYBFQlZh3iAjF5BXwlNs3iBKlgFBCT+H5qDROIzSwgLnHr yXwmiIMEJJbsOc8MYYtKvHz8jxXCVpKYtPQcK0R9vsT2iz9ZQGxeAUGJkzOfsExgFJyFZNQs JGWzkJRBxHUkFuz+xAZha0ssW/iaGcY+c+AxE7L4Akb2VYwcpcUFObnpRgabGIGhfkyCTXcH 4/3pnocYBTgYlXh4C534o4RYE8uKK3MPMUpwMCuJ8M5YzhclxJuSWFmVWpQfX1Sak1p8iFGa g0VJnPeMJ2+UkEB6YklqdmpqQWoRTJaJg1OqgXGKCXvt38k1gl965suzLZi+tnCii4W9zOV5 aepNEbPmfJaKzGB0b0jYdZ1vzUIZdz6pjDmzVh06vP2t9pbrDz2fLrveNNX+W+tJVuMLyxa9 vS6bxidxOaFbT3cS5wrFny2uC0IVijx4pd8bBWvc3xtwxC7uVcZ7XkfRoFezA5Z/3KlVlGV7 NU2JpTgj0VCLuag4EQBpGVd/cQIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/sKKZrD8B5yqOUzORBJFO4YZnvIQ>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-mboned-mtrace-v2-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Nov 2017 20:57:15 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.


Document: draft-ietf-rtgwg-rlfa-node-protection-09
Reviewer: Meral Shirazipour
Review Date: 2017-11-16
IETF LC End Date:  2017-11-23
IESG Telechat date: NA

Summary:
This draft is ready to be published as Standards Track RFC but I have comments.

Major issues:
Minor issues:
Nits/editorial comments:
-please spell out acronyms at first use.

-[Page 7,8]
"If an implementation receives an
   unknown TLV type for the first TLV in a message, it SHOULD ignore and
   silently discard the TLV and any subsequent TLVs in the packet
   containing the TLV.  If an implementation receives an unknown TLV
   type for a subsequent TLV within a message, it SHOULD ignore and
   silently discard the TLV.  If the length of a TLV exceeds the
   available space in the containing packet, the implementation MUST
   ignore and silently discard the TLV and any remaining portion of the
containing packet.  Any data in the packet after the specified TLV
   length is considered to be outside the boundary of the TLV and MUST
   be ignored during processing of the TLV.
"

this whole paragraph is a bit confusing.

e.g. "If an implementation receives an unknown TLV type for the first TLV in a message", is this refering to the header TLV?
e.g. "If an implementation receives an unknown TLV   type for a subsequent TLV within a message, it SHOULD ignore and
   silently discard the TLV.", does this mean TLVs after this one TLV should not be discarded?
e.g. "Any data in the packet after the specified TLV length is considered to be outside the boundary of the TLV and MUST
   be ignored during processing of the TLV.", does this apply to last case only of when the length of a TLV exceeds the available space in the packet?

-[Page 12, 13], "UNIX timeval" or  timespec?
(please verify if usec or nsec)

-[Page 17], "An unique"--->"A unique"


Best Regards,
Meral
---
Meral Shirazipour
Ericsson
Research
www.ericsson.com

v2.23.0 | Report a Bug | By Email