Re: [Gen-art] Genart telechat review of draft-ietf-payload-rtp-ttml-03

James Sandford <james.sandford@bbc.co.uk> Tue, 15 October 2019 10:17 UTC

Return-Path: <james.sandford@bbc.co.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 47D411200E3; Tue, 15 Oct 2019 03:17:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.201
X-Spam-Level:
X-Spam-Status: No, score=-4.201 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8FLIK_Io8sBF; Tue, 15 Oct 2019 03:17:14 -0700 (PDT)
Received: from mailout1.telhc.bbc.co.uk (mailout1.telhc.bbc.co.uk [132.185.161.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4ED8B1200D6; Tue, 15 Oct 2019 03:17:14 -0700 (PDT)
Received: from BGB01XI1002.national.core.bbc.co.uk ([10.184.50.52]) by mailout1.telhc.bbc.co.uk (8.15.2/8.15.2) with ESMTP id x9FAHCZU025321; Tue, 15 Oct 2019 11:17:12 +0100 (BST)
Received: from BGB01XUD1001.national.core.bbc.co.uk ([10.184.52.80]) by BGB01XI1002.national.core.bbc.co.uk ([10.184.50.52]) with mapi id 14.03.0408.000; Tue, 15 Oct 2019 11:17:08 +0100
From: James Sandford <james.sandford@bbc.co.uk>
To: Russ Housley <housley@vigilsec.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "ietf@ietf.org" <ietf@ietf.org>, "avt@ietf.org" <avt@ietf.org>, "draft-ietf-payload-rtp-ttml.all@ietf.org" <draft-ietf-payload-rtp-ttml.all@ietf.org>
Thread-Topic: Genart telechat review of draft-ietf-payload-rtp-ttml-03
Thread-Index: AQHVgFrzWZwbGvLmk0yTzWQZR4FopadbcqQR
Date: Tue, 15 Oct 2019 10:17:07 +0000
Message-ID: <734752AF0E88364D983373FE5CEFED5770DE3755@bgb01xud1001>
References: <157081561475.29329.4440266604305969718@ietfa.amsl.com>
In-Reply-To: <157081561475.29329.4440266604305969718@ietfa.amsl.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [132.185.132.13]
x-exclaimer-md-config: c91d45b2-6e10-4209-9543-d9970fac71b7
x-tm-as-product-ver: SMEX-12.5.0.1300-8.2.1013-24052.007
x-tm-as-result: No-9.512000-8.000000-10
x-tmase-matchedrid: Jm7Yxmmj9Om7lpQUW6Uvz7iMC5wdwKqdwZLXS0hN8p1pptXQGEEyxExw YYUVwXgL5CExRqzKGHbfIEEaMgv7AvZomtZBUIXQnIGynr5ObIZ579SS+Zr4D1AoBBK61BhcaJY FSEH91fvrUWEjTM9FIBBuD/IBx/c+Dkubg39L7f+dVNZaI2n6/wVyeo9hM9SHycsO6qPr9KSgC8 +CbB0wrwq+JKxIqr0LU96g+TFMoUfHN1lQDGm/Hfp1plqEbuqx9yS7vvkvVUZtw+n+iKWyyLmdM 1aLrFCBuiIcdMkoZb8DZCldP9AFvrQ/gWi/bNdVyPPRU9ScEDXfVqwz+CynaV42zm1Zi+MJ3vbY 4m6N26DFOK/wVLIhcgt1FbTRkWhl2X53LeVAc3F2aFFWhkT3QAPVIQPxDK8D5aFo3CHjGICVLv/ AO1ECy/eExRIv1fiq2Vwt16YNk5djioffPaDkIdPNaYYJeRf5hEIiqNvBrmPjud2x7TPVt7t1xJ fOjWSqejolImHtk8m4A3csSqVso5H0YXYnbGozgxsfzkNRlfIBpRCTkRk5SfoLR4+zsDTtw38dX ReMtXdXEpHG898XvnHM7AGSLTE1u2Diu3fmdJgqkke931OtM1Zca9RSYo/b
x-tm-as-user-approved-sender: Yes
x-tm-as-user-blocked-sender: No
x-tmase-result: 10--9.512000-8.000000
x-tmase-version: SMEX-12.5.0.1300-8.2.1013-24052.007
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/sPI9uUMRxf5BLrICGS_Hu40SQw8>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-payload-rtp-ttml-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 10:17:16 -0000

Hello,
Thank you for the further feedback. 

In an earlier draft we had the second paragraph of section 7.1 elsewhere in the document. I believe it was in section 4.2.1.2 which discusses, amongst other things, how the TTML document timing relates to the RTP timestamps. We concluded that the document was easier to understand when all of the information related to clock rate was in the one section. If this goes against convention, I'm happy to move the second paragraph to another part of the document. But from the position of making the document easy to understand, leaving the information in one place might be best.

With regards to <CODE BEGINS> <CODE ENDS>, I understand that these are defined in the TLP for the purpose of identifying Code Components that aren't already one of the types listed in the accompanying Code Components document and that the Code Components document includes XML. I also see in this thread that the CODE BEGINS notation is seen as optional https://www.rfc-editor.org/pipermail/rfc-interest/2016-December/009782.html . I would prefer to not use the CODE BEGINS notation as, at a glance, it looks quite similar to XML itself and may be confusing. Furthermore, the understanding of the meaning of the CODE BEGINS notation requires the reader to read the TLP which already clearly specifies that XML is considered a Code Component. I believe that, in this case, CODE BEGINS is redundant and would make the document more confusing rather than less. 

Regards,
James

==========
James Sandford
R&D Project Engineer

BBC Research and Development
5th Floor
Dock House
MediaCityUK
Salford
M50 2LH

Tel: 030304 (09549)
Web: http://www.bbc.co.uk/rd

________________________________________
From: Russ Housley via Datatracker [noreply@ietf.org]
Sent: 11 October 2019 18:40
To: gen-art@ietf.org
Cc: ietf@ietf.org; avt@ietf.org; draft-ietf-payload-rtp-ttml.all@ietf.org
Subject: Genart telechat review of draft-ietf-payload-rtp-ttml-03

Reviewer: Russ Housley
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>;.

Document: draft-ietf-payload-rtp-ttml-03
Reviewer: Russ Housley
Review Date: 2019-10-11
IETF LC End Date: 2019-10-10
IESG Telechat date: 2019-10-17


Thank you for addressing my comments on the previous version of this
Internet-Draft.


Summary: Ready with Nits

Major Concerns:

None.


Minor Concerns:

None.


Nits:

My guess is that the second paragraph in Section 7.1 uses "should"
because it is asking implementors to think about these things when
selecting a clock rate.  I expected this section to be talking about
the payload format parameters, not implementation considerations.  I
am not sure, but this paragraph might be more impactful elsewhere.

In section 4.2.1.1 and 4.2.1.2.1.2, should the blocks of XML be
enclosed between '<CODE BEGINS>' and '<CODE ENDS>' lines to make it
very clear that the Simplified BSD License applies here?