Re: [Gen-art] Genart last call review of draft-ietf-opsawg-tacacs-yang-09

"Wubo (lana)" <lana.wubo@huawei.com> Mon, 22 March 2021 11:17 UTC

Return-Path: <lana.wubo@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 590A73A1179; Mon, 22 Mar 2021 04:17:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level:
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9KbSgtD652xr; Mon, 22 Mar 2021 04:17:37 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3D1CB3A117C; Mon, 22 Mar 2021 04:17:33 -0700 (PDT)
Received: from fraeml734-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F3sFB3VP2z6829D; Mon, 22 Mar 2021 19:08:46 +0800 (CST)
Received: from dggeme702-chm.china.huawei.com (10.1.199.98) by fraeml734-chm.china.huawei.com (10.206.15.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 12:17:26 +0100
Received: from dggeme752-chm.china.huawei.com (10.3.19.98) by dggeme702-chm.china.huawei.com (10.1.199.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Mon, 22 Mar 2021 19:17:24 +0800
Received: from dggeme752-chm.china.huawei.com ([10.6.80.76]) by dggeme752-chm.china.huawei.com ([10.6.80.76]) with mapi id 15.01.2106.013; Mon, 22 Mar 2021 19:17:24 +0800
From: "Wubo (lana)" <lana.wubo@huawei.com>
To: Mohit Sethi <mohit.m.sethi@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-opsawg-tacacs-yang.all@ietf.org" <draft-ietf-opsawg-tacacs-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "opsawg@ietf.org" <opsawg@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-opsawg-tacacs-yang-09
Thread-Index: AdcfDK/KwWEXIWheakqasL8K4gOm0Q==
Date: Mon, 22 Mar 2021 11:17:24 +0000
Message-ID: <01be7b4f40f240a88470652ea1e74be3@huawei.com>
Accept-Language: en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.123.156]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/saO_5XwrBwNiuabF5UVY4Dxp0MA>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-opsawg-tacacs-yang-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Mar 2021 11:17:41 -0000

Hi Mohit,

Thanks for the review. I will fix the nits in the next revision.

Thanks,
Bo

-----邮件原件-----
发件人: Mohit Sethi via Datatracker [mailto:noreply@ietf.org] 
发送时间: 2021年3月20日 18:25
收件人: gen-art@ietf.org
抄送: draft-ietf-opsawg-tacacs-yang.all@ietf.org; last-call@ietf.org; opsawg@ietf.org
主题: Genart last call review of draft-ietf-opsawg-tacacs-yang-09

Reviewer: Mohit Sethi
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-opsawg-tacacs-yang-09
Reviewer: Mohit Sethi
Review Date: 2021-03-20
IETF LC End Date: 2021-03-29
IESG Telechat date: Not scheduled for a telechat

Summary: This document defines a TACACS+ YANG module for configuring TACACS+ clients so that they can use TACACS+ servers as an alternative to RADIUS servers or local user configuration.

Major issues:

Minor issues:

Nits/editorial comments:
Perhaps expand TACACS+ on first usage. The same for FIB. Perhaps add the acronym AAA to the first usage of Authentication, Authorization and Accounting