[Gen-art] Genart last call review of draft-ietf-ipsecme-qr-ikev2-09

Christer Holmberg via Datatracker <noreply@ietf.org> Fri, 13 December 2019 20:17 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E1D0112008B; Fri, 13 Dec 2019 12:17:58 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: ipsec@ietf.org, last-call@ietf.org, draft-ietf-ipsecme-qr-ikev2.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.113.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Message-ID: <157626827886.12929.4367951047776204825@ietfa.amsl.com>
Date: Fri, 13 Dec 2019 12:17:58 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/t51j90-apJSrRRimcq9isuCcTnQ>
Subject: [Gen-art] Genart last call review of draft-ietf-ipsecme-qr-ikev2-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Dec 2019 20:17:59 -0000

Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ipsecme-qr-ikev2-09
Reviewer: Christer Holmberg
Review Date: 2019-12-13
IETF LC End Date: 2019-12-25
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well-written, and almost ready for publication.
However, I have a couple of minor comments that I would like the authors to
address.

Major issues: None

Minor issues:

Q1:

The Security Considerations lists IKEv2/IPSec algorithms that are not
considered quantum-resistant. However, that is not mentioned anywhere else. I
think it would be good to mention that in the Abstract and/or Introduction.

Q2:

Section 3 says:

   "If the responder does not support this specification or does not have
   any PPK configured, then it ignores the received notification and
   continues with the IKEv2 protocol as normal."

I assume the ignoring of a non-supported notification and continuing with
normal IKEv2 is part of the IKEv2 specification. If so, I suggest to say add
something like:

", as described in RFCXXXX."

Nits/editorial comments:

Q3:

The Security Considerations talk about the Grover's algorithm. Please add a
reference.