[Gen-art] Genart last call review of draft-ietf-core-multipart-ct-03

Stewart Bryant via Datatracker <noreply@ietf.org> Sat, 06 April 2019 09:26 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1EEA7120316; Sat, 6 Apr 2019 02:26:48 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Stewart Bryant via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-core-multipart-ct.all@ietf.org, ietf@ietf.org, core@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.94.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <155454280808.21871.333722671657907840@ietfa.amsl.com>
Date: Sat, 06 Apr 2019 02:26:48 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/tFpjTQe-4RuQs6-g_0ycVDbOoBk>
Subject: [Gen-art] Genart last call review of draft-ietf-core-multipart-ct-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Apr 2019 09:26:48 -0000

Reviewer: Stewart Bryant
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-core-multipart-ct-03
Reviewer: Stewart Bryant
Review Date: 2019-04-06
IETF LC End Date: 2019-04-08
IESG Telechat date: Not scheduled for a telechat

Summary:

Apart from one figure that was difficult to understand and some trivial nits
this is well written and is ready for publication.

Major issues: None

Minor issues:

         __________       __________       __________
        |          |     |          |     |          |
   ---->|   2.05   |---->|  2.05 /  |---->|  4.xx /  |
        | Pending  |     |   2.03   |     |   5.xx   |
        |__________|     |__________|     |__________|
           ^   \ \          ^    \           ^
            \__/  \          \___/          /
                   \_______________________/

                   Figure 2: Sequence of Notifications:
SB> Not my specialty, but I don't see what message gets sent
SB> to who in the above and RFC7641 has no similar diagram.

Nits/editorial comments:
   accompanying it.  In such a case, the sequence in which these occur
   may not be relevant to the application.  This specification allows to
SB> typo - word missing
  indicate that an optional part is not present by substituting a null
   value for the representation of the part.

==========

   The collection is encoded as a CBOR [RFC7049] array with an even
SB> CBOR needs expanding on first use (it is not on the well known list)
   number of elements.

==========

   Person & email address to contact for further information:
      iesg&ietf.org
SB> Shouldn't that be iesg@ietf.org?

==========