[Gen-art] review of draft-ietf-teas-lsp-attribute-ro-02.txt
Francis Dupont <Francis.Dupont@fdupont.fr> Mon, 16 February 2015 14:02 UTC
Return-Path: <Francis.Dupont@fdupont.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF7601A1AE8 for <gen-art@ietfa.amsl.com>; Mon, 16 Feb 2015 06:02:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.562
X-Spam-Level:
X-Spam-Status: No, score=-1.562 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_FR=0.35, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N23FlPwxWrPx for <gen-art@ietfa.amsl.com>; Mon, 16 Feb 2015 06:02:14 -0800 (PST)
Received: from givry.fdupont.fr (givry.fdupont.fr [IPv6:2001:41d0:1:6d55:211:5bff:fe98:d51e]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D854A1A1B04 for <gen-art@ietf.org>; Mon, 16 Feb 2015 06:02:13 -0800 (PST)
Received: from givry.fdupont.fr (localhost [127.0.0.1]) by givry.fdupont.fr (8.14.3/8.14.3) with ESMTP id t1GDwFvO095836; Mon, 16 Feb 2015 14:58:15 +0100 (CET) (envelope-from dupont@givry.fdupont.fr)
Message-Id: <201502161358.t1GDwFvO095836@givry.fdupont.fr>
From: Francis Dupont <Francis.Dupont@fdupont.fr>
To: gen-art@ietf.org
Date: Mon, 16 Feb 2015 14:58:15 +0100
Sender: Francis.Dupont@fdupont.fr
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/tP52vwfTDLbvVcbQbpCbp8V977Y>
Cc: draft-ietf-teas-lsp-attribute-ro.all@tools.ietf.org
Subject: [Gen-art] review of draft-ietf-teas-lsp-attribute-ro-02.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 14:02:17 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-teas-lsp-attribute-ro-02.txt Reviewer: Francis Dupont Review Date: 20150213 IETF LC End Date: 20150218 IESG Telechat date: unknown Summary: Ready with nits Major issues: none Minor issues: none Nits/editorial comments: There are a heavy use of abbrevs. Note abbrevs are registered under http://www.rfc-editor.org/rfc-style-guide/abbrev.expansion.txt and some (well known abbrevs, starred in the list) must be introduced at the first use. - title page 1: LSP (perhaps because this abbrev has 2 different meanings?) and ERO are not well known abbrevs. - abstract page 1: usually explicit RFC numbers are forbidden here but IMHO this document is an exception (i.e., its content will be merged in the next revision of RFC 5420). - abstract page 1: LSP, ERO and RRO are not well known abbrevs (BTW RSVP is and I give up about RSVP-TE) - ToC page 2 and 3.2.1 title: Subobject presence rule -> Subobject Presence Rule - 1 page 2: this document defines a mechanism to define -> this document provides a mechanism to define ("describes" could be fine too but it is used in the next sentence) - 2.1 page 3, page 4: [Ss]ection Section -> Section (IMHO this problem comes from the way the xref is rendered) - 2.3 page 4: lower case "must" (either "MUST", or "has to" or another not-keyword synonym) (and 3.1 page 6 (twice)) - 3.1 page 5: lower case "may" (either "MAY" or can...) (and 3.2.1 page 6) - 3.2.1 page 6: e.g. -> e.g., - 3.2.3 page 7: are met : -> are met: - 4.3 page 8: registery -> registry - 4.3 page 8: IMHO you should not have a reference in empty lines (i.e., there should be one reference per defined bit) - 4.3 page 8: another lower case keyword: shall - 5 page 9: one should, 3 may's. IMHO you should simply promote them to SHOULD and MAY's at the exception of the last one (This may reveal -> This can reveal). - 5 page 10: another "may reveal". Regards Francis.Dupont@fdupont.fr
- [Gen-art] review of draft-ietf-teas-lsp-attribute… Francis Dupont
- Re: [Gen-art] review of draft-ietf-teas-lsp-attri… Cyril Margaria
- Re: [Gen-art] review of draft-ietf-teas-lsp-attri… Elwyn Davies
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Cyril Margaria
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Elwyn Davies
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Cyril Margaria
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Elwyn Davies
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Cyril Margaria
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Elwyn Davies
- Re: [Gen-art] [Teas] review of draft-ietf-teas-ls… Jari Arkko