Re: [Gen-art] Genart last call review of draft-ietf-grow-bmp-adj-rib-out-05

Linda Dunbar <linda.dunbar@futurewei.com> Thu, 20 June 2019 16:55 UTC

Return-Path: <linda.dunbar@futurewei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 49A45120125; Thu, 20 Jun 2019 09:55:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K4BWkOWIfKOe; Thu, 20 Jun 2019 09:55:48 -0700 (PDT)
Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-eopbgr780139.outbound.protection.outlook.com [40.107.78.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D2A2212013F; Thu, 20 Jun 2019 09:55:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xKJsAMHAd9Ydx4pFQTMxZl8+872l+8WVn54ikSo2HKc=; b=dCJhMA857GlGhLDKL8XHFh5/osJKe7NvXsxnUZLF30iLB5F4A8SUJnzOBQ5/cDntiAtKWCIFU9Hz+7wxxv5TeUdIZhH2ScaSQhm9KLXoJN6EPXysPirqreHi91gOLMrVn+st7z7DDy8u7Mj950t8/tEAk8gII0Ze0KGayIsGV44=
Received: from MN2PR13MB3582.namprd13.prod.outlook.com (10.255.238.139) by MN2PR13MB3520.namprd13.prod.outlook.com (10.255.237.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.5; Thu, 20 Jun 2019 16:55:40 +0000
Received: from MN2PR13MB3582.namprd13.prod.outlook.com ([fe80::b5e8:95cb:5d8e:9397]) by MN2PR13MB3582.namprd13.prod.outlook.com ([fe80::b5e8:95cb:5d8e:9397%7]) with mapi id 15.20.2008.007; Thu, 20 Jun 2019 16:55:40 +0000
From: Linda Dunbar <linda.dunbar@futurewei.com>
To: "Tim Evens (tievens)" <tievens@cisco.com>, Linda Dunbar <Linda.dunbar@huawei.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "grow@ietf.org" <grow@ietf.org>, "draft-ietf-grow-bmp-adj-rib-out.all@ietf.org" <draft-ietf-grow-bmp-adj-rib-out.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-grow-bmp-adj-rib-out-05
Thread-Index: AQHVIvH6yoD5cpRPP0iCJ38k+IoqcaajDrOAgAG6JiA=
Date: Thu, 20 Jun 2019 16:55:40 +0000
Message-ID: <MN2PR13MB35827692DD3862EB9F2783F885E40@MN2PR13MB3582.namprd13.prod.outlook.com>
References: <156054505283.28254.9882843194956326237@ietfa.amsl.com> <846513F6-08F9-40A3-9A0F-0DE471B607F0@cisco.com>
In-Reply-To: <846513F6-08F9-40A3-9A0F-0DE471B607F0@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=linda.dunbar@futurewei.com;
x-originating-ip: [12.111.81.80]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fb885f68-70f5-4e5a-5949-08d6f5a02022
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR13MB3520;
x-ms-traffictypediagnostic: MN2PR13MB3520:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR13MB352042A7FBAA9F2599DA913C85E40@MN2PR13MB3520.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0074BBE012
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(136003)(366004)(39840400004)(396003)(189003)(199004)(13464003)(229853002)(53546011)(6506007)(26005)(6306002)(11346002)(99286004)(68736007)(6436002)(7736002)(186003)(71200400001)(71190400001)(476003)(6116002)(66066001)(55016002)(102836004)(33656002)(7696005)(73956011)(14444005)(76116006)(66476007)(66556008)(74316002)(486006)(53936002)(3846002)(446003)(305945005)(44832011)(52536014)(256004)(9686003)(66946007)(66446008)(64756008)(2501003)(966005)(45080400002)(81156014)(478600001)(14454004)(76176011)(81166006)(8936002)(110136005)(8676002)(316002)(25786009)(2906002)(6246003)(4326008)(86362001)(54906003)(5660300002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR13MB3520; H:MN2PR13MB3582.namprd13.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: futurewei.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: hBOYLdkNlN7vZxg0K1oRJB7sFSN+MHIsMHC9RWOp1E5+4dsFCrD066LSENzp6KZ08Y+7nWzfEK6+QHs4yqoLhsmIPPeSY08vWTW+LqNqpYg3MtAR+gRqhOLiKLKi0y++u7t3og65hzgujzsG2sMJyaCuJzyY2+5IllY3MSgAOHyXYzuIY7LOSXMA31l7+BpfY7s5rkx/TVO87kN2AhlcyIbStzYFqsnW1RXzoB+dynLKFIJ3U5HAipQg3i1kRnuWwXYIw0MDytdRJzOncOtAPpQviuTzGMvmecdRzLlUZji2YYhnKMFE3+0lJwZuy0CHbZoRp23t1R5zccXNpsHprvVcIkWMavoNTr0gVwdhrpZAMomJhnmhASfM2LSWrU1T8dCmszsV2S3gnK8KOteDIIJanLNLefCporL9l3GKWe4=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb885f68-70f5-4e5a-5949-08d6f5a02022
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2019 16:55:40.0869 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ldunbar@futurewei.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3520
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/vcKGO0tVzygfMv9rlbzUkNr7jv0>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-grow-bmp-adj-rib-out-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2019 16:55:56 -0000

Tim,

Thank you very much for the changes. 
Your newly proposed texts are very clear. 

Linda

-----Original Message-----
From: Gen-art <gen-art-bounces@ietf.org> On Behalf Of Tim Evens (tievens)
Sent: Wednesday, June 19, 2019 4:22 PM
To: Linda Dunbar <Linda.dunbar@huawei.com>; gen-art@ietf.org
Cc: grow@ietf.org; draft-ietf-grow-bmp-adj-rib-out.all@ietf.org; ietf@ietf.org
Subject: Re: [Gen-art] Genart last call review of draft-ietf-grow-bmp-adj-rib-out-05

Hi Linda,

Thank you so much for your review and comments.  Please see response inline marked [tievens].


On 6/14/19, 1:44 PM, "Linda Dunbar via Datatracker" <noreply@ietf.org> wrote:
    
    Summary:
    
    The draft updates the BGP Monitoring Protocol BMP by adding access to the
    Adj-RIB-Out RIBs. There are some unclear areas that need authors to clarify.
    
    Major issues:
    
    Minor issues:
    
    Section 1 last paragraph:
    It is not clear if BMP sender send to multiple BMP receivers  or just  to one
    "BMP receiver". The first part of the sentence says "..send to a BMP
    receivers", the second part says ".. advertise to BGP peers, .."
    
    Suggest to make it consistent, such as sending  to multiple, or just one.   "..
    to send to BMP receivers what it advertises.."

[tievens] There are one or more receivers for each sender. The implementation 
defines how many receivers it can send to.   I've updated it to:

  "Adding Adj-RIB-Out provides the ability for a BMP sender to send to 
   BMP receivers what it advertises to BGP peers, which can be used for
   outbound policy validation and to monitor RIBs that were advertised."

[Linda] Yes, your new text is much more clear. 
    
    Does a BMP sender also send out Adj-RIB-In? it is not clear to.

[tievens] Yes, RFC7854 defines Adj-RIB-In only.  How about the below?

  "BGP Monitoring Protocol (BMP) RFC 7854 [RFC7854] only defines Adj-
   RIB-In being sent to BMP receivers.  This document updates section
   4.2 [RFC7854] per-peer header by adding a new flag to distinguish
   Adj-RIB-In verses Adj-RIB-Out. BMP senders use the new flag to send
   either Adj-RIB-In or Adj-RIB-Out."

 [Linda] Thank you for the change. It is very clear now (sorry that I didn't devote time to read the RFC7854). 
   
    Section 6 first sentence: just curious which BMP messages are NOT applicable to
    Adj-RIB-In or Adj-RIB-out?   If it is specified in other documents, please add
    a reference.
    
[tievens] How about the below update to clarify some.   I didn’t want to create a list
of them because it could be different in updated/new drafts.

 "Many BMP messages have a per-peer header but some are not applicable
  to Adj-RIB-In or Adj-RIB-Out monitoring, such as peer up and down
  notficiations."

[Linda] thanks. It is very clear now. 


    Nits/editorial comments:
    
    Thank you.
    
    Linda Dunbar
    
    

_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fgen-art&amp;data=02%7C01%7Clinda.dunbar%40futurewei.com%7C71348478589849f9d41b08d6f4fc2b04%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C636965761234078303&amp;sdata=gWj2o%2BUm8nRnYFVqIazO0bKQehhkjQZPsZpP7hXqVlU%3D&amp;reserved=0