[Gen-art] Gen-art telechat review of draft-ietf-teas-rsvp-te-li-lb-04.txt (updated)

Elwyn Davies <elwynd@folly.org.uk> Wed, 04 March 2015 18:46 UTC

Return-Path: <elwynd@folly.org.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DCD261AC406; Wed, 4 Mar 2015 10:46:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ttnJKD_yAypa; Wed, 4 Mar 2015 10:46:33 -0800 (PST)
Received: from auth.a.painless.aa.net.uk (a.painless.aa.net.uk [IPv6:2001:8b0:0:30::51bb:1e33]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40EDB1A872A; Wed, 4 Mar 2015 10:46:33 -0800 (PST)
Received: from mightyatom.folly.org.uk ([81.187.254.250]) by a.painless.aa.net.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77) (envelope-from <elwynd@folly.org.uk>) id 1YTEJO-0005J8-AI; Wed, 04 Mar 2015 18:46:30 +0000
Message-ID: <54F75304.706@folly.org.uk>
Date: Wed, 04 Mar 2015 18:46:28 +0000
From: Elwyn Davies <elwynd@folly.org.uk>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: General area reviewing team <gen-art@ietf.org>, "draft-ietf-teas-rsvp-te-li-lb.all" <draft-ietf-teas-rsvp-te-li-lb.all@tools.ietf.org>, teas@ietf.org
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/tc0O4lzInXtiXT-SoHveH71TSOk>
Subject: [Gen-art] Gen-art telechat review of draft-ietf-teas-rsvp-te-li-lb-04.txt (updated)
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2015 18:46:36 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
< http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-teas-rsvp-te-li-lb-04.txt
Reviewer: Elwyn Davies
Review Date: 2015/03/03
IETF LC End Date: 2015/02/18
IESG Telechat date: 20150305

Summary: Almost ready for PS.  I noticed at a late stage in the last 
call reviewing process that the requirement that the hop before a 
loopback node should be a strict hop was unnecessary.  The draft editor, 
Dong Jie, has agreed that this is the case and is checking that the 
removal of this constraint is acceptable to the other authors.  There is 
one other outstanding fix agreed for a nit. Otherwise all my last call 
comments have been cleared.  Thanks.

An additional minor issue about labels has come to light.  See below.

Major issues:
None

Minor issues:
s3.2, para 2, et seq:
The requirement that the hop before the loopback entity MUST be a strict 
hop is unnecessary.  The essential constraint (which is fully specified 
in the -04 draft) is that the entity at which loopback is to occur has 
to be uniquely identified (i.e., it can't be an 'abstract node' 
signifying (potentially) a group of nodes, such as an AS).  I have 
discussed this with Dong Jie, as editor, and he has agreed that the 
constraint is not needed.  A new version of the draft removing the 
constraint is in hand, pending agreement with the other authors and 
checking with the WG.

s3.2:
If dealing with a bidirectional LSP as per RFC 3473, and the ERO 
waypoint (say, an IPv4 address) is qualified with two Label subobjects, 
does loopback put BOTH paths into loopback?  Alternatively, the loopback 
flag could be defined so that it applies to only one of the Labels if 
the ERO Hop attribute subobject is placed after the Label or to both if 
it is placed immediately after the identifying subobject (in this case 
the IPv4 address subobject).

Nits/editorial comments:

s3.2, para 3:
OLD :

    Currently, the type value MUST be verified to be
    less than 32, and for type values 1 and 2, the prefix length MUST be
    32 and 128 respectively.

NEW:
    Currently, the type value MUST be verified to be
    less than 32 (i.e., able to identify a specific entity where a 
loopback can
    occur, see Section 4.3), and for type values 1 (IPv4 address) and 2 
(IPv6
    address), the prefix length MUST be 32 and 128 respectively.

_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art