Re: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39

Elwyn Davies <elwynd@folly.org.uk> Wed, 06 January 2016 02:07 UTC

Return-Path: <elwynd@folly.org.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 29C721A895D; Tue, 5 Jan 2016 18:07:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2CoWfwi5sqPA; Tue, 5 Jan 2016 18:07:16 -0800 (PST)
Received: from a.painless.aa.net.uk (a.painless.aa.net.uk [IPv6:2001:8b0:0:30::51bb:1e33]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3493E1A8953; Tue, 5 Jan 2016 18:07:16 -0800 (PST)
Received: from mightyatom.folly.org.uk ([81.187.254.250]) by a.painless.aa.net.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77) (envelope-from <elwynd@folly.org.uk>) id 1aGdVD-0000ab-Mn; Wed, 06 Jan 2016 02:07:10 +0000
To: Elwyn Davies <elwynd@dial.pipex.com>, Tom Haynes <thomas.haynes@primarydata.com>
References: <566E10D8.3040002@dial.pipex.com> <224DB6F8-608F-44E1-8D72-0BDAB8CA3120@primarydata.com> <56731678.1000004@dial.pipex.com>
From: Elwyn Davies <elwynd@folly.org.uk>
Message-ID: <568C76C7.7000101@folly.org.uk>
Date: Wed, 6 Jan 2016 02:07:03 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <56731678.1000004@dial.pipex.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/tfsoYDlovTtNJojTKcrWv2iofYU>
Cc: General area reviewing team <gen-art@ietf.org>, William.Adamson@netapp.com, draft-ietf-nfsv4-minorversion2-dot-x.all@ietf.org
Subject: Re: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2016 02:07:19 -0000

Hi, Tom.

The existence of draft-ietf-nfsv4-rfc3530-migration-update was pointed 
out to me this evening.  After a cursory read I realised that 
SETCLIENTID had been MNI'd in 4.1 so that there is a minor infelicity in 
the comments in minorversion2-dot-x (and in 4.1).

The comment here:
>     /// /*
>     ///  * Program number is in the transient range since the client
>     ///  * will assign the exact transient program number and provide
>     ///  * that to the server via the SETCLIENTID operation.
>     ///  */
>     /// program NFS4_CALLBACK {
>     ///         version NFS_CB {
>     ///                 void
>     ///                         CB_NULL(void) = 0;
>     ///                 CB_COMPOUND4res
>     ///                         CB_COMPOUND(CB_COMPOUND4args) = 1;
>     ///         } = 1;
>   
is not correct for versions 4.1 and 4.2.  The program number comes from 
CREATE_SESSION or BACKCHANNEL_CTL in versions 4.1 and 4.2.

Please update the comment to reflect the current situation.

Cheers,
Elwyn


On 17/12/2015 20:09, Elwyn Davies wrote:
> Hi, Tom.
>
> Excellent... so I think we are done with dot-x.
>
> One additional point that I was going to write into the main 
> minorversion2 review relating to referencing  the requirements RFC 
> 7204.  rpcsec-gssv3 also references the requirements RFC but the 
> amount of info that is needful to  support implementers seems to be 
> mostly in minorversion2.  Would it be possible for you and Andy to 
> work out if anything extra is really needed in minorversio2 (about 
> guest mode primarily I think) so that the requirements reference is 
> not needed and rpcsec-gssv3 can just reference minorversion2 for all 
> info on the modes?  I wasn't sure what, if anything, extra was needed 
> in minorversion2.
>
> Cheers,
> Elwyn
>
> On 17/12/2015 02:19, Tom Haynes wrote:
>>> On Dec 13, 2015, at 4:44 PM, Elwyn Davies <elwynd@dial.pipex.com> 
>>> wrote:
>>>
>>> I am the assigned Gen-ART reviewer for this draft. The General Area
>>> Review Team (Gen-ART) reviews all IETF documents being processed
>>> by the IESG for the IETF Chair.  Please treat these comments just
>>> like any other last call comments.
>>>
>>> For more information, please see the FAQ at
>>>
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>
>>> Document: draft-ietf-nfsv4-minorversion2-dot-x-39.txt
>>> Reviewer: Elwyn Davies
>>> Review Date: 2015-12-13
>>> IETF LC End Date: 2015-12-09
>>> IESG Telechat date: (if known) -
>>>
>>> Summary: Ready with nits.  The XDR specification appears to be a 
>>> superset of the v4.1 XDR specification and combines a correction of 
>>> the five remaining discrepancies between v4.1 and v4.0bis ( 
>>> definition and use of the NFS4_OTHER_SIZE constant, addition and use 
>>> of the ascii_REQUIRED4 type, modification of the typedef of 
>>> linktext4). The additions of the 4.2 interface appears to match the 
>>> specification in draft-ietf-nfsv4-minorversion2-39 except for two 
>>> attribute typedef  items mentioned below.  One discrepancy would 
>>> have no operational effect as the type used in the other draft  is 
>>> an alias for the type used here but the clone_blksize error changes 
>>> the size of the type.
>>>
>>> I have checked that the extracted code is accepted by rpcgen and 
>>> generates files as expected.
>>>
>>> Major issues:
>>> None
>>>
>>> Minor issues:
>>> None
>>
>>
>> Hi Elwyn,
>>
>> Thanks for the review - sorry for the delay in responding, I’m just 
>> now surfacing from my job. :-)
>>
>> Responses inline.
>>
>>> Nits/editorial comments:
>>> Observation:  It might be useful to note that this XDR specification 
>>> is fully upwards compatible with the v4.0bis with the minor 
>>> exception of the clientaddr4 structure which has been replaced by 
>>> (strictly, aliased to) netaddr4 which has the same members with the 
>>> same purposes but the names have changed (r_netid -> na_r_netid, 
>>> r_addr ->na_r_addr). This effectively fully reconverges the v4.0bis 
>>> and v4.1 strands of the XDR.
>>>
>> Shamelessly stolen almost verbatim!
>>
>>> Line 1145: In draft-ietf-nfsv4-minorversion2-39 we have typedef 
>>> length4 fattr4_space_freed
>>>                     whereas in this draft we 
>>> have                           typedef uint64_t fattr4_space_freed
>> Fixed this in the XDR document.
>>
>>> Line 1149: In draft-ietf-nfsv4-minorversion2-39 we have typedef 
>>> length4 fattr4_clone_blksize
>>>                     whereas in this draft we 
>>> have                           typedef uint32_t fattr4_clone_blksize
>>
>> And for this one, I made the change to uint32_t in 
>> draft-ietf-nfsv4-minorversion2-39 .
>>
>> Thanks again!
>> Tom
>>
>
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art