Re: [Gen-art] Genart last call review of draft-ietf-nvo3-evpn-applicability-04

Lars Eggert <lars@eggert.org> Mon, 24 April 2023 14:49 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3004C152DB4; Mon, 24 Apr 2023 07:49:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ACyuIwyxW8BI; Mon, 24 Apr 2023 07:49:03 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A4FAC152DB3; Mon, 24 Apr 2023 07:48:59 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:cc:515f:3561:e4cb]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id ADAAF20CFC; Mon, 24 Apr 2023 17:48:53 +0300 (EEST)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Lars Eggert <lars@eggert.org>
Mime-Version: 1.0 (1.0)
Date: Mon, 24 Apr 2023 17:48:53 +0300
Message-Id: <9EBAB4A4-A0A5-427E-80EE-2A8933E37691@eggert.org>
References: <165712785477.26568.6015388138744672009@ietfa.amsl.com>
Cc: gen-art@ietf.org, draft-ietf-nvo3-evpn-applicability.all@ietf.org, last-call@ietf.org, nvo3@ietf.org
In-Reply-To: <165712785477.26568.6015388138744672009@ietfa.amsl.com>
To: Reese Enghardt <ietf@tenghardt.net>
X-MailScanner-ID: ADAAF20CFC.ABD40
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/v80h_7Ez8haS-zVLca_U5ItFx1E>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-nvo3-evpn-applicability-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2023 14:49:04 -0000

Reese, thank you for your review. I have entered a No Objection ballot.

Lars

> On 6. Jul 2022, at 20:17, Reese Enghardt via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Reese Enghardt
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-nvo3-evpn-applicability-04
> Reviewer: Reese Enghardt
> Review Date: 2022-07-06
> IETF LC End Date: 2022-07-11
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: The document is well-written, though dense, and it does a good job of
> breaking down a complex topic. I only found a few nits to make the document
> more accessible.
> 
> Major issues: None.
> 
> Minor issues:
> 
> Abstract:
> Please expand NVO3 networks on first use.
> Please consider adding a sentence to already state in the abstract/introduction
> that this document does not introduce any new procedures or signaling in EVPN.
> 
> If EVPN gets updated in future RFCs, does this document apply to these updates?
> Not sure if it's worth saying anything about this, but I started wondering
> about this question when seeing the table of EVPN route types in Section 4.1.
> 
> Section 2:
> Please expand CLOS on first use.
> Please add a definition for Tenant System, in addition to expanding the acronym.
> For the BT definition, not having read RFC7432, I got slightly confused
> initially, as "Bridge Table" sounded to me like it's a sort-of lookup table on
> a single NVE, but if it's the instantiation of a BD, it would potentially span
> multiple NVEs. Having read the doc, it seems like a BT spans multiple NVEs and
> potentially is the same on all NVEs in the same BD. If this is true, please
> consider adding a clarifying sentence to the BT definition.
> 
> Section 4.2:
> Figure 1 uses the terms "single-active" and "all-active", but the document only
> defines/explains them in Section 4.7.5 - Is this intentional? Even though
> Figure 1 uses "single-active" and "all-active", I am not seeing these terms
> used in any example later on when the terms are explained. Please consider
> either elaborating on how the terms relate to the Figure 1 example or removing
> these terms from Figure 1.
> 
> Section 4.2.2:
> Please consider expanding PMSI on first use.
> 
> Nits/editorial comments:
> 
> Section 4:
> "The intend is" -> "The intent is"
> 
> 
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call