Re: [Gen-art] Genart last call review of draft-ietf-isis-yang-isis-cfg-37

"Acee Lindem (acee)" <acee@cisco.com> Fri, 20 September 2019 19:22 UTC

Return-Path: <acee@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6983412011F; Fri, 20 Sep 2019 12:22:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=grX7/nkT; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=L5D4smlf
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cK4XBbIqqoiJ; Fri, 20 Sep 2019 12:22:50 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 004941200E0; Fri, 20 Sep 2019 12:22:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1882; q=dns/txt; s=iport; t=1569007370; x=1570216970; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=xIyfdYiwa1C4et/GABSAfnqv1ukkrZbpINT25z2japg=; b=grX7/nkTlabyftSZgZbSq00+5J9YkJGwUQCTXfXFMlZzWYCKmRKhps6Z VmW7DYtHszmTAWqIQTZ//OZnuSqiHAYU//Gr62dxA9jYuTShvpOXN/jNJ q8QO7o9u5iiROXnVB4DSns8nind2xwGOZv7HLnzLScvjhAzJwOgdBkq03 E=;
IronPort-PHdr: 9a23:oH/DSRS/yoQz2Ln3abYhBxvGR9psv++ubAcI9poqja5Pea2//pPkeVbS/uhpkESUANfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH15NksAKh0olCc+BB1f8KavjZCE3NM9DT1RiuXq8NBsdFQ==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0A2AACaJoVd/5xdJa1lGwEBAQEDAQEBBwMBAQGBVQQBAQELAYFKUANtViAECyqEIoNHA4p4gjcll3SBLoEkA1QJAQEBDAEBIwoCAQGEPwIXgnIjNgcOAgMJAQEEAQEBAgEFBG2FLQyFSwIEEhERDAEBNwEPAgEIFAYCJgICAjAVEAIEAQ0FIoMAAYFqAx0BAgygXQKBOIhhc4Eygn0BAQWFDRiCFwMGgQwoAYwIGIF/gRABJwwTgkw+gmECgWGDCzKCJo0igjidNwqCIocFigiDfRuCNodLjyWOGogTkQQCBAIEBQIOAQEFgVkDLoFYcBVlAYJBUBAUgU6DcoUUhT9zgSmOGgEB
X-IronPort-AV: E=Sophos;i="5.64,529,1559520000"; d="scan'208";a="330059707"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 20 Sep 2019 19:22:47 +0000
Received: from XCH-RCD-015.cisco.com (xch-rcd-015.cisco.com [173.37.102.25]) by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id x8KJMlbW017089 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 20 Sep 2019 19:22:47 GMT
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by XCH-RCD-015.cisco.com (173.37.102.25) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Sep 2019 14:22:47 -0500
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Sep 2019 15:22:46 -0400
Received: from NAM04-CO1-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 20 Sep 2019 14:22:45 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VzZBQu37enEAt943kIvlDfp4MMGTuL6KeHII77b/x74ePcYWZxzZ4G/Hx07J9fX8dDfZi2LlxSnoIOov9G3kfq/30zhP+sxoU98D+UpXWmcQ5iLdfQladn2+7zTpJqtUvuFApg+kuCP3bkp2SR4h/ncWos3yNEAut+HBtlbCF8IiWD4iJQYYA3yhbodrVe5+lAsw9Su8j8X7/zNbzBq0uXCoxi5wP3DCoFJGONeEM/DYW96fNLHTdDLhTZeXcwBAxGQO7kCt3ChRA0AcC/XEIZOVimLKOKfE/Q+MG+Nuom50ofI8foRzG4s/FuFa6S1Xh6cpKlq95PbkNkFjeALDrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xIyfdYiwa1C4et/GABSAfnqv1ukkrZbpINT25z2japg=; b=Mg+6oBQzwLNJgGIKmi4iFUPaOaEKGx5+0jlvsK2/LztC+ukFsG/HPomTtnq9hmPLL0UUy6j1f1UJt5C3Oe2hJdAfqaGDmkot2a5FmE2JDbTvl22h2nYSUuRot48YGlcZec8BB8rBfQUP6avBdOcsPEnkCA1T3Ut1ZXx+QDZ6if7zAN2ccnBPT/Dmiq5wBgWqzUaA+oP93gMLPKTNfiruqihpcxNi+mA1gVGWPraDOAum6jgkeRkQfRtWnN4NyabAO0v/65no/+5ImEL+VTIcfuqMdr7P/5HXzmseCj6NUC/uC98+y9qZQwAm6EEdT3PeOsazWSB0mlTv1WqQhr0ojw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xIyfdYiwa1C4et/GABSAfnqv1ukkrZbpINT25z2japg=; b=L5D4smlfitRCJ19O4y8KPYxiEVdczcvj554EunOaxivhlhAj0N7t6FS0Y6aU8vfNgQXOH7H+Qp8dVJiHFvnIEDzZ58MxX5AKySEWjR0WVr9ODbqYbWdL3HJ6tKqGlOSMsuSmCrEtvhXP128ymYcflMIyca3y8IMrJZXPr9PKDhM=
Received: from MN2PR11MB4221.namprd11.prod.outlook.com (52.135.38.14) by MN2PR11MB3950.namprd11.prod.outlook.com (10.255.181.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.23; Fri, 20 Sep 2019 19:22:44 +0000
Received: from MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::cdc1:a2cf:eb3:a420]) by MN2PR11MB4221.namprd11.prod.outlook.com ([fe80::cdc1:a2cf:eb3:a420%6]) with mapi id 15.20.2284.023; Fri, 20 Sep 2019 19:22:44 +0000
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Stewart Bryant <stewart.bryant@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-isis-yang-isis-cfg.all@ietf.org" <draft-ietf-isis-yang-isis-cfg.all@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-isis-yang-isis-cfg-37
Thread-Index: AQHVbjwfQRcTMlZecUaQJp6BOt5spqc0kH+A
Date: Fri, 20 Sep 2019 19:22:44 +0000
Message-ID: <5D24364E-0490-41A4-8B86-0868E9D1C3AC@cisco.com>
References: <156882324948.4553.2228459253680589792@ietfa.amsl.com>
In-Reply-To: <156882324948.4553.2228459253680589792@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=acee@cisco.com;
x-originating-ip: [2001:420:c0c4:1006::1e2]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 32371774-b8fe-4bd7-9939-08d73dffe9c1
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR11MB3950;
x-ms-traffictypediagnostic: MN2PR11MB3950:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <MN2PR11MB3950028E849766260E4AB983C2880@MN2PR11MB3950.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0166B75B74
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(199004)(189003)(4326008)(36756003)(64756008)(99286004)(6512007)(76116006)(2906002)(66476007)(66946007)(54906003)(25786009)(46003)(66556008)(5660300002)(2501003)(76176011)(11346002)(6436002)(7736002)(305945005)(446003)(6486002)(256004)(8676002)(71200400001)(316002)(6116002)(66446008)(186003)(102836004)(476003)(2616005)(33656002)(229853002)(110136005)(81156014)(71190400001)(478600001)(6246003)(14454004)(81166006)(86362001)(486006)(6306002)(8936002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3950; H:MN2PR11MB4221.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: BuPZrmyppMbd6GAdQpT7uxE2bManRWssiD4rWG5xrxzCQNVkAJSsjsRTFpGExfr0yLFJ2/Cw3qNdfhou4Ku0W49H7EwrMqE+QBNl6kJMt+wzf2wrh7BYkUXqjSKbZoU34LzJiLi2XMaS5yCTdrNy1zJ8d5IFATgzd3R0LAbnXKGVeay5wzFDp8kXHr9JCRY5Ov49jmoHHsZIjK0syiGkk15EkGsc3VCa2XnM4dacfot5bU4ir9LScWAIsrgLcRCeF4rGFqy3L0/q/WE4bVMVQkpEMgbB6wuz1hPboiiZWTdDNvWyKBilc8GzvH3dy8ru0JglWgNTbb/EiHprEF/2vamlUpG79a3nBSfR0p7h66QUwyTch3z+KB3TK48D0Ki2Mbm9kWDKFVQ9n7awGhHESU99aFCq02RjeXzGvoVsxOU=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <600B66A6D5A3E044B27C9F055118CA53@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 32371774-b8fe-4bd7-9939-08d73dffe9c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2019 19:22:44.1649 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AvUtkbqjQkLaQedJPQbbJUwzv4bmJoJjCflr3yQEFObNYKKTrosCufUOUJQ62OYZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3950
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.25, xch-rcd-015.cisco.com
X-Outbound-Node: rcdn-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/vKvRxJ3jWsSp-BaONyF5lrF74ms>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-isis-yang-isis-cfg-37
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Sep 2019 19:22:53 -0000

Thanks Stewart - we will fix this nit in the -38 version. 
Acee

On 9/18/19, 10:14 AM, "Stewart Bryant via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Stewart Bryant
    Review result: Ready
    
    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    
    Document: draft-ietf-isis-yang-isis-cfg-??
    Reviewer: Stewart Bryant
    Review Date: 2019-09-18
    IETF LC End Date: 2019-09-23
    IESG Telechat date: Not scheduled for a telechat
    
    Summary: A true magnum opus. Well written and from a GENART point of view ready
    to be published. I have not checked the YANG syntax, and have only checked that
    the configuration symantics look plausible. I assume that specalist YANG and
    Routing reviewers will look at that detail.
    
    Major issues: None
    
    Minor issues: None
    
    Nits/editorial comments:
       This document defines a YANG data model that can be used to configure
       and manage IS-IS protocol on network elements.
    
    SB> s/manage/manage the/