Re: [Gen-art] Genart last call review of draft-wilde-service-link-rel-06
Erik Wilde <erik.wilde@dret.net> Tue, 20 November 2018 21:06 UTC
Return-Path: <erik.wilde@dret.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 948E7124D68; Tue, 20 Nov 2018 13:06:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.7
X-Spam-Level:
X-Spam-Status: No, score=-1.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (public key: not available)" header.d=dret.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MZkMNIS7nKfm; Tue, 20 Nov 2018 13:06:13 -0800 (PST)
Received: from postoffice.gristmillmedia.com (dret.net [209.188.86.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E665112785F; Tue, 20 Nov 2018 13:06:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dret.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version :Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mDrCBuhSDCB3PQF2oOuCLSgdWV9lZOcs99A4EWu2Ack=; b=xHEy926zf4+CpMHITafAiVIKww YYGr6J3D8QJsDpkwwf3yMt5/yhfGq+6GNnTz+SGsROtw1w9GRLQXQ2rIXoTUdC2vQ3ntTKEXEvfHZ Ag78u+jANK8zKCPCjdEkc7XxI3rmTyZtXmnxIN0DpkDSM3TUYDa888yCgPL1fJ33m5gD32b+AKVYQ XmvV66AgbwCcXaW+ghD2ZPtPF+E8YP0fDPgqmQrYpYdFhGW5Earc10SyHWROJTbqiHjekyyOHvriV z9zDHGi0p+Sf8DXNZFBNNNunKt37g/5UC3eTUduUKEjxnf+3/YM6hQTRCiySzZEh9Dc3JnFyXL7Yg c5j5mWXw==;
Received: from [82.194.106.114] (port=53748 helo=dretbook.local) by postoffice.gristmillmedia.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from <erik.wilde@dret.net>) id 1gPDDn-0007A7-9g; Tue, 20 Nov 2018 16:06:11 -0500
To: Peter Yee <peter@akayla.com>, gen-art@ietf.org
Cc: draft-wilde-service-link-rel.all@ietf.org, ietf@ietf.org
References: <154273091439.18526.1398228083840805519@ietfa.amsl.com>
From: Erik Wilde <erik.wilde@dret.net>
Message-ID: <3ee2454c-49f7-1377-8734-b25e38e87e94@dret.net>
Date: Tue, 20 Nov 2018 22:06:09 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <154273091439.18526.1398228083840805519@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - postoffice.gristmillmedia.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - dret.net
X-Get-Message-Sender-Via: postoffice.gristmillmedia.com: authenticated_id: birdhouse@dret.net
X-Authenticated-Sender: postoffice.gristmillmedia.com: birdhouse@dret.net
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/vLJy7oZ0Aam4W0IE4p1WZSEnEAA>
Subject: Re: [Gen-art] Genart last call review of draft-wilde-service-link-rel-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 21:06:15 -0000
hello. thanks, peter, for your review! On 2018-11-20 17:21, Peter Yee wrote: > Page 8, Section 7: RFC 2223 requires you do more than provide an ellipsis here. > You might want to consider what makes sense. Perhaps a discussion of what > happens to a client that obtains a maliciously formatted service-desc or even > an errant service-desc. While a human might be able to see through problems in > a "service-doc", it's quite possible that a machine will want to take > precautions about handling the received data and acting upon it. thanks for the suggestion! https://github.com/dret/I-D/commit/3f065e662ccd66419c92246a2bba9bd8c5127ade adds security considerations. > Nits/editorial comments: > > Page 1, Note to Readers: Presumably this section will be removed prior to > publication. done in https://github.com/dret/I-D/commit/f5e8c10f4a9400d55a867d64b8aef9846ae4106b > Page 3, 4th full paragraph, 1st sentence: Delete the comma after "consumption" > and delete the "for" following that. > > Page 5, Section 3.3, 1st paragraph, 1st section: change "of" to "between". Put > the section references in parentheses. > > Page 5, Section 3.3, 1st paragraph, 2nd sentence: insert "a" before "better". addressed in https://github.com/dret/I-D/commit/cc902371fff59b96d3185e643522fe8f1462d042 i think with these changes in the draft i have addressed the comments in this review. i have posted a new version of the draft that includes the changes mentioned here. https://tools.ietf.org/html/draft-wilde-service-link-rel-07 thanks again and kind regards, dret. -- erik wilde | mailto:erik.wilde@dret.net | | http://dret.net/netdret | | http://twitter.com/dret |