[Gen-art] Genart last call review of draft-ietf-ippm-ioam-data-11
Dan Romascanu via Datatracker <email@example.com> Sat, 05 December 2020 10:05 UTC
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 947C83A10DC; Sat, 5 Dec 2020 02:05:34 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
From: Dan Romascanu via Datatracker <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org
Reply-To: Dan Romascanu <email@example.com>
Date: Sat, 05 Dec 2020 02:05:34 -0800
Subject: [Gen-art] Genart last call review of draft-ietf-ippm-ioam-data-11
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:firstname.lastname@example.org?subject=unsubscribe>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:email@example.com?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2020 10:05:35 -0000
Reviewer: Dan Romascanu Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-ippm-ioam-data-11 Reviewer: Dan Romascanu Review Date: 2020-12-05 IETF LC End Date: 2020-12-08 IESG Telechat date: Not scheduled for a telechat Summary: This is a very useful and rather complex document that discusses the data fields and associated data types for IOAM that can be encapsulated into a variety of protocols. It's well written, detailed and accurate. It is READY from a Gen-ART perspective, with a few editorial comments that I suggest being addressed before approval or as part of the final editorial process. Major issues: Minor issues: Nits/editorial comments: 1. How are specific IOAM encapsulations being defined? Will specifications that define IOAM encapsulations into various protocols be within the scope of the IPPM WG? of the IETF? Do they require to be RFCs? Some clarification text would be useful. 2. In Section 188.8.131.52 I found the following: > The authors acknowledge that in some operational cases there is a need for the units to be consistent across a packet path through the network, hence RECOMMEND the implementations to use standard units such as Bytes. 'The authors ... RECOMMEND' seems a little bit odd. The active verb form is not within the list of keywords as per [RFC2119], also mentioned in Section 3 of this document. To be on the safe side I would recommend reformulating the sentence so that the RECOMMENDED form is used. Alternatively, just do not use capitalization here. 3. In Section 8.7 I found: > The expert will post the request on the IPPM mailing list, and possibly on other relevant mailing lists, to allow for community feedback. I assume that this means the IPPM WG mailing list. The abbreviation of IPPM may be very familiar for the current audiences, but the situation may change in the future. The scope even of this document may outlive the WG. I suggest to expand IPPM in Section 3 and possibly reformulate the sentence so that posting the request on the IPPM list does not sound as the eternal procedure.
- [Gen-art] Genart last call review of draft-ietf-i… Dan Romascanu via Datatracker
- Re: [Gen-art] [Last-Call] Genart last call review… Lars Eggert