Re: [Gen-art] Gen-ART review of draft-ietf-trill-rbridge-channel-06.txt

Donald Eastlake <d3e3e3@gmail.com> Tue, 19 June 2012 11:55 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C387121F85EF for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 04:55:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -103.413
X-Spam-Level:
X-Spam-Status: No, score=-103.413 tagged_above=-999 required=5 tests=[AWL=0.186, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zSjNu-TYzdkV for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 04:55:33 -0700 (PDT)
Received: from mail-gg0-f172.google.com (mail-gg0-f172.google.com [209.85.161.172]) by ietfa.amsl.com (Postfix) with ESMTP id 2D51B21F85E6 for <gen-art@ietf.org>; Tue, 19 Jun 2012 04:55:33 -0700 (PDT)
Received: by ggnc4 with SMTP id c4so5002059ggn.31 for <gen-art@ietf.org>; Tue, 19 Jun 2012 04:55:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=udXbyiANVdNsPiYYB6U7asi2+aklf9PM0/Qm4s6vmds=; b=VgwoYsd/U/t+qX7oiApF7Nq6SFMU8yx507bPq/XfuvYGTQh0XSuRMSJj50PRz+rSpW vF5Dcfz9zXkn5FeE4i4BblQteV1VWGpJRWZmoynNQyHZxf6583ZfMpF6EVfG952otUOd yWv7iqrj+b6XJ1inEIWDhjucN9qlbMFd8TNvpaQv4fVc32pqd8FYMoTv4YJiHyqqRuuX 57Ic8hXz/jy92zg5RvUpR2VsF8xfQPvXValF9LbtUi2mKWh9NBlNahhFW6Q8LsVJr8NM 2WXVXfSibNz3z4FLpMr3xhsG+ZKppW0pEzxhtwXC2pwTOcb8ookVuD4DPEAT+jEgfZmy sLBQ==
Received: by 10.50.194.200 with SMTP id hy8mr743690igc.58.1340106932343; Tue, 19 Jun 2012 04:55:32 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.64.16.227 with HTTP; Tue, 19 Jun 2012 04:55:12 -0700 (PDT)
In-Reply-To: <4FE029AB.6060108@ericsson.com>
References: <4FE029AB.6060108@ericsson.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 19 Jun 2012 07:55:12 -0400
Message-ID: <CAF4+nEEhS=unKAe1L7k+3=Kk4RLk6yV+SdUYEXSMso8mvnoPAA@mail.gmail.com>
To: "Miguel A. Garcia" <Miguel.A.Garcia@ericsson.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: nordmark@acm.org, General Area Review Team <gen-art@ietf.org>, Ralph Droms <rdroms.ietf@gmail.com>, draft-ietf-trill-rbridge-channel.authors@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-trill-rbridge-channel-06.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2012 11:55:33 -0000

Hi Miguel,

On Tue, Jun 19, 2012 at 3:26 AM, Miguel A. Garcia
<Miguel.A.Garcia@ericsson.com> wrote:
> I have been selected as the General Area Review Team (Gen-ART)
> reviewer for this draft. For background on Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>
> Please resolve these comments along with any other comments you may receive.
>
> Document: draft-ietf-trill-rbridge-channel-06.txt
> Reviewer: Miguel Garcia <Miguel.A.Garcia@ericsson.com>
> Review Date: 2012-06-19
> IETF LC End Date: 2012-06-20
> IESG Telechat date: 2012-06-21
>
> Summary: This document is ready for publication as a standards track RFC
>
> Major issues: none
>
> Minor issues: none
>
> Nits/editorial comments:
>
> The document is well written and easy to read. Congratulations to the
> authors.

Thanks.

> I have some minor editorial comments.
>
> - All the figures that represent bits on the wire do not follow the
> convention of numbering the bits. I would suggest to add the bit number as
> per the RFC style guide. This means adding these two lines to most figures
> in the document:
>
>
>       0                   1                   2                   3
>       0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1

OK. I believe there are two figures where this should be added.

> - Also, related to figures. I would suggest to add a caption to each figure,
> for example, under the figure in Section 2.1:
>
>      Figure 2: RBridge Channel Message inner frame
>
> This allows other documents to easily refer to the figure by number (e.g.,
> "Figure 2 in RFC xxxx").

OK.

> - Section 2.1.1: s/species/specifies

Thanks for spotting that.

> - Section 4. There are 5 bullet points. Something is wrong with the
> indentation of the third bullet point.

OK.

Thanks for the review,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

> /Miguel
> --
> Miguel A. Garcia
> +34-91-339-3608
> Ericsson Spain