Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-avtcore-cryptex-05

Lars Eggert <lars@eggert.org> Thu, 16 June 2022 11:10 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1395FC14CF09; Thu, 16 Jun 2022 04:10:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.109
X-Spam-Level:
X-Spam-Status: No, score=-2.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o3jhNJtMXPJq; Thu, 16 Jun 2022 04:10:47 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 26207C14F606; Thu, 16 Jun 2022 04:10:44 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:1c88:e8ae:82ba:5180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 9FBEE1F0734; Thu, 16 Jun 2022 14:10:33 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1655377833; bh=j7axECFEO935pj1isDCrGCyStNA+zq4xxW5g+3K3BCE=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=b9X6wLbXDNE3q/TbD/4hVeya7GLaDKTq+T7ziqqk9X9IbF7N68jcDu75o6xsQE45t P35KgL0ZnIb/4bD+bpbbJo9ot3DV9c4eCJHM2E3zyOc1getMcvt1vPoWxFeidPHgYq dGR/VcJ3FY3javDFgI+4j8TYDngKgZ8J5TFsYqk4=
Content-Type: multipart/signed; boundary="Apple-Mail=_B7517EA1-5D4D-4844-BD18-01E7385EE0E8"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <164918271145.1399.16972717746743002964@ietfa.amsl.com>
Date: Thu, 16 Jun 2022 14:10:32 +0300
Cc: gen-art@ietf.org, last-call@ietf.org, draft-ietf-avtcore-cryptex.all@ietf.org, avt@ietf.org
Message-Id: <FF756D10-91C0-4AFA-8388-8E53025325B3@eggert.org>
References: <164918271145.1399.16972717746743002964@ietfa.amsl.com>
To: Linda Dunbar <linda.dunbar@futurewei.com>
X-MailScanner-ID: 9FBEE1F0734.A4C57
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/wvY4oHSuMTDYTOQcCZr6yaLBWAk>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-avtcore-cryptex-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2022 11:10:51 -0000

Linda, thank you for your review. I have entered a DISCUSS ballot for this document (as a placeholder for IANA).

Lars


> On 2022-4-5, at 21:18, Linda Dunbar via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Linda Dunbar
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-avtcore-cryptex-05
> Reviewer: Linda Dunbar
> Review Date: 2022-04-05
> IETF LC End Date: 2022-04-05
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> This document specifies a new mechanism that completely encrypts header
> extensions and CSRCs for RTP.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> a couple of questions:
> - Section 4: this document defines a new "a=cryptex" Session Description
> Protocol (SDP) [RFC4566] attribute to indicate support. Then the next sentence
> states that "This attribute takes no value".  Why "no value"?  The first
> statement already says a new "a=cryptex" attribute.  It is confusing.
> 
> -  Section 6.3:  what does "region" mean in the statement?   "The decryption
> procedure is identical to that of [RFC3711] except for the region to decrypt"
> Do you mean the "header" to be encrypted by the scheme described in this
> document?
> 
> Thank you,
> Linda Dunbar
> 
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call