[Gen-art] Gen-ART review of draft-ietf-trill-rbridge-channel-06.txt

"Miguel A. Garcia" <Miguel.A.Garcia@ericsson.com> Tue, 19 June 2012 07:26 UTC

Return-Path: <miguel.a.garcia@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A6F021F84D9 for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 00:26:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.249
X-Spam-Level:
X-Spam-Status: No, score=-6.249 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_EQ_SE=0.35, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UnDnGOYznHtE for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 00:26:39 -0700 (PDT)
Received: from mailgw2.ericsson.se (mailgw2.ericsson.se [193.180.251.37]) by ietfa.amsl.com (Postfix) with ESMTP id E5F3621F85E6 for <gen-art@ietf.org>; Tue, 19 Jun 2012 00:26:38 -0700 (PDT)
X-AuditID: c1b4fb25-b7fbf6d000002e5d-3d-4fe029ad8397
Received: from esessmw0197.eemea.ericsson.se (Unknown_Domain [153.88.253.125]) by mailgw2.ericsson.se (Symantec Mail Security) with SMTP id 35.20.11869.DA920EF4; Tue, 19 Jun 2012 09:26:37 +0200 (CEST)
Received: from [159.107.24.226] (153.88.115.8) by esessmw0197.eemea.ericsson.se (153.88.115.88) with Microsoft SMTP Server id 8.3.264.0; Tue, 19 Jun 2012 09:26:36 +0200
Message-ID: <4FE029AB.6060108@ericsson.com>
Date: Tue, 19 Jun 2012 09:26:35 +0200
From: "Miguel A. Garcia" <Miguel.A.Garcia@ericsson.com>
User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: draft-ietf-trill-rbridge-channel.authors@tools.ietf.org
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgluLIzCtJLcpLzFFi42KZGfG3Vnet5gN/g4W/hC0urK2xuPrqM4tF /9SdTBaN1/pYHVg8Ll/x9tg56y67x5IlP5k8vlz+zBbAEsVlk5Kak1mWWqRvl8CV8WTKGuaC 3zwVN282sDUwXufsYuTkkBAwkVh15y4LhC0mceHeejYQW0jgFKPE0acZXYxcQPYaRonHR26z gyR4BbQlZh26zNzFyMHBIqAqsXapPEiYTcBconXjRrASUYFgiTOf1kOVC0qcnPkEbL6IgLXE 5mstTCA2s0CmxKqJz5hAxggLOEnM+iUPEbaVuDDnOguELS+x/e0cZohzNCUm31zKPIGRfxaS qbOQtMxC0rKAkXkVo3BuYmZOermRXmpRZnJxcX6eXnHqJkZgaB7c8lt1B+OdcyKHGKU5WJTE ea237vEXEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwFjB90ykctojb8c3oa0Cq/kO/XguNX/W k18i8ZFSjRuTe4XsFhw85Myy5O2+CxNPft8TsPz8bNMpxpPlfimcseO+Hb/4ZEnydg5Bn+vB hWoMWmK3t8hXnQ0XNdrz7elv2atbHic7WPc+EuA+7bfxfPPbaN8yMXHB3g3+1T76+ZOUlSfs XRfQl6DEUpyRaKjFXFScCAAfgXxGGwIAAA==
Cc: nordmark@acm.org, General Area Review Team <gen-art@ietf.org>, Ralph Droms <rdroms.ietf@gmail.com>
Subject: [Gen-art] Gen-ART review of draft-ietf-trill-rbridge-channel-06.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2012 07:26:40 -0000

I have been selected as the General Area Review Team (Gen-ART)
reviewer for this draft. For background on Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Please resolve these comments along with any other comments you may receive.

Document: draft-ietf-trill-rbridge-channel-06.txt
Reviewer: Miguel Garcia <Miguel.A.Garcia@ericsson.com>
Review Date: 2012-06-19
IETF LC End Date: 2012-06-20
IESG Telechat date: 2012-06-21

Summary: This document is ready for publication as a standards track RFC

Major issues: none

Minor issues: none

Nits/editorial comments:

The document is well written and easy to read. Congratulations to the 
authors.

I have some minor editorial comments.

- All the figures that represent bits on the wire do not follow the 
convention of numbering the bits. I would suggest to add the bit number 
as per the RFC style guide. This means adding these two lines to most 
figures in the document:


        0                   1                   2                   3
        0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1


- Also, related to figures. I would suggest to add a caption to each 
figure, for example, under the figure in Section 2.1:

       Figure 2: RBridge Channel Message inner frame

This allows other documents to easily refer to the figure by number 
(e.g., "Figure 2 in RFC xxxx").



- Section 2.1.1: s/species/specifies

- Section 4. There are 5 bullet points. Something is wrong with the 
indentation of the third bullet point.




/Miguel
-- 
Miguel A. Garcia
+34-91-339-3608
Ericsson Spain