Re: [Gen-art] Genart last call review of draft-ietf-quic-recovery-32

alissa@cooperw.in Tue, 05 January 2021 17:13 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 958F13A1053; Tue, 5 Jan 2021 09:13:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.119
X-Spam-Level:
X-Spam-Status: No, score=-2.119 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=LaDigvQx; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=o1xSGVmK
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e_1Y85K72PNz; Tue, 5 Jan 2021 09:13:00 -0800 (PST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B9AF3A1065; Tue, 5 Jan 2021 09:12:48 -0800 (PST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BD0DF5C00B1; Tue, 5 Jan 2021 12:12:47 -0500 (EST)
Received: from imap37 ([10.202.2.87]) by compute3.internal (MEProxy); Tue, 05 Jan 2021 12:12:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=3JYIAahTxuR5AHIjHNbC/4aIXcrQgbN otz2yLEVtCNk=; b=LaDigvQx6uBb+IUTx/Ehv1l50Htj1s1lrk3RLuJBToa+1FB pvtqPrz1iCM4Fewtn90m5Cnx1vRDl9fB82EXX0KZuWxat6HLz1ayWP68aHUzsSa2 cb5GiAplk3aRa/4pDb50ZZxGaTASBD9NOask1Jiu0bWU9gLqNwwHmcsP+UBC/5Xx SjQ+4x7mxgoS2f2EnVb1JxwzLd42zqcyqt11ESAYPMdJIRPxaBqfv/gVr/Qo48c2 ue6GCG5cLmZ2skYOdB8EvBqua+4PxNcHnxhFM1o/KhLrab/cD1Vm5bzhOo2JkTZl oef46/CvhKgU0fURtow/kz0pM9fB5ns2G6gkbxQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3JYIAa hTxuR5AHIjHNbC/4aIXcrQgbNotz2yLEVtCNk=; b=o1xSGVmK6cKzc6f703Ekv5 aAq6iP+hB5ylHJOP4CWmKpVyGzxznc7EPOt4JgM8cwvSERLqMnR0oO9UQoRLckxQ V/L08ZAme9uu7dgpMNHMcrfs2PAhD7ontHbe0VXD2rtKyNeWV0hQECyQNX38ZpaA 5Ex6Yc4sl4IdJHFLKbHvzUGoFDQYGQwfoWS1Rx7n8sUgr8iMowU9YF009QBC0Uup B16Om+XJKEIn7ksmj3e1TPFsh8wBJryDF7ado3Jtghl8YmvHYltxoM/AscJTs13Q iqS6PzHG4PZNoJ3Lvlall4kdtnZz6pY9zD6IApfolRFfs08S8bEFMKZN/4KONdpg ==
X-ME-Sender: <xms:D570Xw3tGPB5DfuKX6U5pAgJP4WaklMtmQPpw6KTbCB_oABGRUOn0Q> <xme:D570X7G4iLXMaUAhvAVk8J3P-IQD6KhadhF4fh9CRbybq_PRjbcig9u3BO34u-v7_ qMJtZc1EytIbEmIeA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefjedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomheprghlihhs shgrsegtohhophgvrhifrdhinhenucggtffrrghtthgvrhhnpefggefhhffggefhudfffe dvieejiefhteevgefhtdefieegteeutedttdejleffheenucffohhmrghinhepghhithhh uhgsrdgtohhmpdhivghtfhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhn
X-ME-Proxy: <xmx:D570X44Bstn7JIOobQH_IvF9YRQ8-FP43P3OLcxbVRHDLrg2adAy2Q> <xmx:D570X52p-3U7_LprwmSYmFVokF4SRxb8fU1qGU8i-xkjR4DOaqVJsA> <xmx:D570XzEKihWsguJiR7Toq0ThJdLxH7lSq4_V5jSnzW50QIHs7BHTjg> <xmx:D570X3gbaItjz0H_FbXNAtxw07IUIH9c8h3i5KNM8MGGSFf-PaZjmg>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0E3871900078; Tue, 5 Jan 2021 12:12:47 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396
Mime-Version: 1.0
Message-Id: <c3dac027-ee92-44ad-b7ad-bb77c69ae6c0@www.fastmail.com>
In-Reply-To: <CALGR9obi=LgUSRK8C0_OU8OoKrMCOw=T-ZJkEzr1ngKNCYGpyQ@mail.gmail.com>
References: <160693012624.7900.16758034630109890895@ietfa.amsl.com> <CALGR9obi=LgUSRK8C0_OU8OoKrMCOw=T-ZJkEzr1ngKNCYGpyQ@mail.gmail.com>
Date: Tue, 05 Jan 2021 12:12:26 -0500
From: alissa@cooperw.in
To: "Lucas Pardue" <lucaspardue.24.7@gmail.com>, "Vijay Gurbani" <vijay.gurbani@gmail.com>
Cc: last-call@ietf.org, gen-art@ietf.org, "QUIC WG" <quic@ietf.org>, draft-ietf-quic-recovery.all@ietf.org, "Magnus Westerlund" <magnus.westerlund@ericsson.com>
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/x0blDv1_ryvxQd461yjxm5YGwJY>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-quic-recovery-32
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2021 17:13:03 -0000

Vijay, thanks for your review. Jana, thanks for addressing Vijay's comments. I entered a Yes ballot.

Alissa

On Wed, Dec 2, 2020, at 1:44 PM, Lucas Pardue wrote:
> Hi Vijay,
> 
> Thanks for the review! Since the QUIC WG uses a Github Workflow I've 
> created a separate issue for each of the items in your review, see 
> in-line responses for the precise issue link. All issues are track in 
> the milestone https://github.com/quicwg/base-drafts/milestone/22
> 
> We'd appreciate it if you could coordinate with the Recovery document 
> editors via GitHub, on the issue itself and/or any Pull Request that 
> might be raised to address your comments.
> 
> Cheers
> Lars and Lucas
> QUIC WG Co-chairs
> 
> On Wed, Dec 2, 2020 at 5:28 PM Vijay Gurbani via Datatracker 
> <noreply@ietf.org> wrote:
> > Reviewer: Vijay Gurbani
> > Review result: Ready with Nits
> > 
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed
> > by the IESG for the IETF Chair.  Please treat these comments just
> > like any other last call comments.
> > 
> > For more information, please see the FAQ at
> > 
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> > 
> > Document: draft-ietf-quic-recovery-32
> > Reviewer: Vijay K. Gurbani
> > Review Date: 2020-12-02
> > IETF LC End Date: 2020-11-16
> > IESG Telechat date: Not scheduled for a telechat
> > 
> > Summary: Ready for publication with nits/minor issues.
> > 
> > Major issues: 0
> > 
> > Minor issues: 2 (Sn refers to Section n)
> > 
> > - S1: "Mechanisms described in this document follow the spirit of existing 
> >  TCP congestion control and loss recovery mechanisms, described in RFCs, 
> >  various Internet-drafts, or academic papers ..." ==> It may be helpful
> >  to provide some references to the RFCs and academic papers.  On the
> >  academic paper side, a couple of survey papers may help.  A quick
> >  search indicates the following recent publications may be useful:
> > 
> >  [1] Al-Saadi, R., Armitage, G., But, J. and Branch, P., 2019. A survey 
> >  of delay-based and hybrid TCP congestion control algorithms. IEEE 
> >  Communications Surveys & Tutorials, 21(4), pp.3609-3638.
> >  [2] Widmer, J., Denda, R. and Mauve, M., 2001. A survey on TCP-friendly 
> >  congestion control. IEEE network, 15(3), pp.28-37.
> > 
> >  For RFCs, perhaps rfc5681 is useful to cite?  Any others?
> > 
> > - S4.2, first paragraph: Perhaps citing rfc6298 is helpful here to further
> >  provide information on the "retransmission ambiguity" problem?
> > 
> > Nits/editorial comments: 0
> > 
> > 
> > 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art
>