Re: [Gen-art] Genart last call review of draft-kucherawy-rfc8478bis-03
Alissa Cooper <alissa@cooperw.in> Thu, 20 February 2020 04:58 UTC
Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92417120859; Wed, 19 Feb 2020 20:58:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=Hm9jWDNX; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=WFXJFFTS
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i8AsB7tSTsTl; Wed, 19 Feb 2020 20:58:38 -0800 (PST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDEF4120805; Wed, 19 Feb 2020 20:58:34 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0A58021B88; Wed, 19 Feb 2020 23:58:34 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 19 Feb 2020 23:58:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm2; bh=Q lsa4b/XZWzvwN63FZURw0lGlbCAGnPm18tQxFPp3KM=; b=Hm9jWDNXJnFqMFFk+ Ab8wglYFPk30iPbCFe6uujyghNFk66tSLRKXOpBL/XESop4sa2YSD9WB1Rzl4B9t K9QKFRdWw2lfkc4xvHRiVOGUluVYYaV0JUU3V169L/tPzSEdXx7oUXWH9Mex0deS v5jYhldw71YbxphXMw6ySabncYa+JJme+krV39yQyaw+RLN7W2/cg/vSMC+5gVBa 9hRChP27oOef5a6mjothsBJ3nEoZzcoCY+BbFYsnlFnBsnfg1Bvd7FYwa0SQwK9p O1Id4Fb/9lg32ib1puOnwTty+oABNRXDRG3hDX3azd5MsU5yC4VBndxLtCxDgzv+ TsQUg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Qlsa4b/XZWzvwN63FZURw0lGlbCAGnPm18tQxFPp3 KM=; b=WFXJFFTSCDFWdqCpYoOon2+LY18K7iY/+qfUJRqHBPSWTvAN7lMYy3j2+ GvaMsIK58C4zWMlTNm/C/Q8ONjyl74+xl2VM2eigjEKH87ioDtJH7Es5Vg8hXt8L jDgrUymVRrqrWRi9+v3lYaeqbdoAPd9RbZxwyMXs5bIyxwLfmaoYUVam4bXBf4aN L8h+PcYhGEfYhzwow6RcM3s9mp455UbhMs9/8COwrQjtT6zVmre63BGbRJLhkwy6 kQA/5c1qT3qEnxIZlKf58cKLbfcFjF5tC0EKx6cOc/eZ/e5Ujmyld6y4Jvv4wRbM C6f1McdCBViCQ5/ezp9/GQvEOq93w==
X-ME-Sender: <xms:-RFOXhK_O6LZcUL3q3vCqcSIkM28qeWXm0gfzA0epf8quNnXl0cvTg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrkedugdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomhgrih hnpehivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrdekkeenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhishhsrgestghooh hpvghrfidrihhn
X-ME-Proxy: <xmx:-RFOXny2MgOXUk2sMVfR2n_opXGwEmk8pdvJHKr7TsDNpYmBr_RURA> <xmx:-RFOXvvQfMB19BAC2IRMuuJ-wdPzUC-HWBL4nrE-3KvgryYIISO0sQ> <xmx:-RFOXiB5UTN_D4PiFmcsZsO8Ymio_TLkydAorb5F_Gv3n0KAd9ZwYg> <xmx:-hFOXvu8h3Rem2_CK90TFX0S0zmuJplzk7VFUx759pX__v7Bh49Pyw>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.88]) by mail.messagingengine.com (Postfix) with ESMTPA id 5CEB73280059; Wed, 19 Feb 2020 23:58:33 -0500 (EST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <0AAC36AF-A087-4E49-B5E4-0F38B67D7C27@fb.com>
Date: Wed, 19 Feb 2020 23:58:32 -0500
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "draft-kucherawy-rfc8478bis.all@ietf.org" <draft-kucherawy-rfc8478bis.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <735B3FF2-5764-4091-AC1A-A80215BFF122@cooperw.in>
References: <157740940842.25212.10128806838650474998@ietfa.amsl.com> <0AAC36AF-A087-4E49-B5E4-0F38B67D7C27@fb.com>
To: Yann Collet <cyan@fb.com>, Joel Halpern <jmh@joelhalpern.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/xA4aLN_N-olTF92bRJ4TSrv4MXA>
Subject: Re: [Gen-art] Genart last call review of draft-kucherawy-rfc8478bis-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Feb 2020 04:58:43 -0000
Joel, thanks for your review. Yann, thanks for your response. I entered a No Objection ballot. One comment below. > On Dec 30, 2019, at 2:19 PM, Yann Collet <cyan@fb.com> wrote: > >> I assume that the "last block" flag is the least significant bit of the first byte of the block header? > > Yes, this is correct > >> And Literals_Block_Type is the least significant two bits of the first byte of the Literals_Section_Header? > > Yes, this is correct too. > >> Should this be stated more explicitly? > > In both cases, the bitfield is preceded by the mention "little-endian" : > > - " Block_Header uses 3 bytes, written using little-endian convention. It contains 3 fields " > - Literals_Section_Header: "It's a byte-aligned variable-size bitfield, ranging from 1 to 5 bytes, using little-endian convention." > > "Little-endian" was presumed a "good enough" indication that the first byte is the lowest one. > After that, the "lowest bit" becomes the least significant bit of the first byte. > > Nevertheless, if this is deemed not clear enough, > some additional statement could be added to make the specification more explicit. I think this is clear enough in the spec. Thanks, Alissa > > > > On 12/26/19, 17:16, "Joel Halpern via Datatracker" <noreply@ietf.org> wrote: > > Reviewer: Joel Halpern > Review result: Ready > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > Document: draft-kucherawy-rfc8478bis-03 > Reviewer: Joel Halpern > Review Date: 2019-12-26 > IETF LC End Date: 2020-01-17 > IESG Telechat date: Not scheduled for a telechat > > Summary: This review primarily focused on the differences, which seem > appropriate, from the RFC. > > Major issues: N/A > > Minor issues: N/A > > Nits/editorial comments: > I presume that bits within a byte are still interpreted in the normal > fashions since we do not work in terms of the serialization of bits on a > wire, and in fact different wires may do it differently. This does leave > the question of how bit fields are interpreted when they describe bits > within a byte. Thus, I assume that the "last block" flag is the least > significant bit of the first byte of the block header? And > Literals_Block_Type is the least significant two bits of the first byte of > the Literals_Section_Header? (I presume that the use of little-endian > encoding is due to existing practice, and therefore presume it is what this > needs to describe.) Should this be stated more explicitly? > > > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Genart last call review of draft-kucher… Joel Halpern via Datatracker
- Re: [Gen-art] Genart last call review of draft-ku… Yann Collet
- Re: [Gen-art] Genart last call review of draft-ku… Alissa Cooper