Re: [Gen-art] [OPSAWG] Gen-ART review of draft-ietf-opsawg-hmac-sha-2-usm-snmp-05

t.petch <ietfc@btconnect.com> Tue, 14 April 2015 10:40 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A525C1A887D; Tue, 14 Apr 2015 03:40:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.002
X-Spam-Level:
X-Spam-Status: No, score=-0.002 tagged_above=-999 required=5 tests=[BAYES_40=-0.001, SPF_HELO_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bMYDsyT8aDEW; Tue, 14 Apr 2015 03:40:36 -0700 (PDT)
Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0749.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe00::749]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C3C81A886D; Tue, 14 Apr 2015 03:40:31 -0700 (PDT)
Received: from pc6 (81.151.162.168) by DB3PR07MB060.eurprd07.prod.outlook.com (10.242.137.151) with Microsoft SMTP Server (TLS) id 15.1.130.23; Tue, 14 Apr 2015 10:38:42 +0000
Message-ID: <020c01d0769f$0076aec0$4001a8c0@gateway.2wire.net>
From: "t.petch" <ietfc@btconnect.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, gen-art@ietf.org
References: <7594FB04B1934943A5C02806D1A2204B1D793917@ESESSMB209.ericsson.se>
Date: Tue, 14 Apr 2015 11:36:56 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1106
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106
X-Originating-IP: [81.151.162.168]
X-ClientProxiedBy: DB3PR08CA0041.eurprd08.prod.outlook.com (25.161.51.179) To DB3PR07MB060.eurprd07.prod.outlook.com (10.242.137.151)
Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB3PR07MB060;
X-Microsoft-Antispam-PRVS: <DB3PR07MB060EED028CBBD3499D983BEA0E60@DB3PR07MB060.eurprd07.prod.outlook.com>
X-Forefront-Antispam-Report: BMV:1; SFV:NSPM; SFS:(10019020)(6009001)(13464003)(377454003)(15975445007)(50226001)(47776003)(62966003)(77156002)(40100003)(61296003)(1456003)(4001410100001)(42186005)(230783001)(122386002)(77096005)(33646002)(50466002)(86362001)(87976001)(1556002)(46102003)(92566002)(62236002)(44716002)(66066001)(23756003)(14496001)(116806002)(81816999)(44736004)(19580405001)(19580395003)(84392001)(81686999)(76176999)(50986999)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB3PR07MB060; H:pc6; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en;
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(5002010); SRVR:DB3PR07MB060; BCL:0; PCL:0; RULEID:; SRVR:DB3PR07MB060;
X-Forefront-PRVS: 054642504A
Received-SPF: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2015 10:38:42.8583 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR07MB060
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/yJrb5rp6kaKQq36WY_tS_0lIkE0>
X-Mailman-Approved-At: Tue, 14 Apr 2015 04:12:12 -0700
Cc: opsawg@ietf.org, draft-ietf-opsawg-hmac-sha-2-usm-snmp.all@tools.ietf.org
Subject: Re: [Gen-art] [OPSAWG] Gen-ART review of draft-ietf-opsawg-hmac-sha-2-usm-snmp-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Apr 2015 10:40:38 -0000

----- Original Message -----
From: "Christer Holmberg" <christer.holmberg@ericsson.com>
To: <gen-art@ietf.org>
Cc: <draft-ietf-opsawg-hmac-sha-2-usm-snmp.all@tools.ietf.org>
Sent: Saturday, April 11, 2015 2:07 PM

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Document:
draft-ietf-opsawg-hmac-sha-2-usm-snmp-05

Reviewer:                           Christer Holmberg

Review Date:                     11 April 2015

IETF LC End Date:             20 April 2015

IETF Telechat Date:         N/A

Summary:        The document is well written, and almost ready for
publication. I do, however, have a couple of comments (see below).

Major Issues: None

Minor Issues:

Q1_10-1: In the IANA Considerations section, IANA is requested to
register new values. However, it is not mentioned in which registry the
new values will be registered.

<tp>

Christer

You puzzle me.  When I look in the I-D I see

"IANA is requested to assign a value in the SnmpAuthProtocols registry "

which looks to me like a mention of which registry the new values will
be registered in.

Tom Petch


Editorial nits:

Q1_GENERAL-1:              Regarding reference, sometimes you say "RFC
XXXX [RFCXXXX]", sometimes "RFC XXXX" and sometimes "[RFCXXXX]".

I think you should be consistent, and e.g. use "RFC XXXX [RFCXXXX]" on
first occurrence, and then "RFC XXXX".

In some cases "[RFCXXXX]" is ok, though, e.g. in section 9.4 where you
say "SNMP-USER-BASED-SM-MIB [RFC3414].".







------------------------------------------------------------------------
--------


> _______________________________________________
> OPSAWG mailing list
> OPSAWG@ietf.org
> https://www.ietf.org/mailman/listinfo/opsawg
>