[Gen-art] review of draft-ietf-ccamp-mw-yang-09.txt
Francis Dupont <Francis.Dupont@fdupont.fr> Tue, 02 October 2018 21:09 UTC
Return-Path: <Francis.Dupont@fdupont.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44E741310E3; Tue, 2 Oct 2018 14:09:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ER3DyByxM9Ag; Tue, 2 Oct 2018 14:09:31 -0700 (PDT)
Received: from givry.fdupont.fr (givry.fdupont.fr [IPv6:2001:41d0:1:6d55:211:5bff:fe98:d51e]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1714613117F; Tue, 2 Oct 2018 14:09:30 -0700 (PDT)
Received: from givry.fdupont.fr (localhost [IPv6:::1]) by givry.fdupont.fr (8.14.7/8.14.7) with ESMTP id w92KYepv005399; Tue, 2 Oct 2018 22:34:40 +0200 (CEST) (envelope-from dupont@givry.fdupont.fr)
Message-Id: <201810022034.w92KYepv005399@givry.fdupont.fr>
From: Francis Dupont <Francis.Dupont@fdupont.fr>
To: gen-art@ietf.org
Cc: draft-ietf-ccamp-mw-yang.all@ietf.org
Date: Tue, 02 Oct 2018 22:34:40 +0200
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/yMAN-qeHqDEeBbfsjfQnYATOd5Y>
Subject: [Gen-art] review of draft-ietf-ccamp-mw-yang-09.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 21:09:33 -0000
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-ccamp-mw-yang-09.txt Reviewer: Francis Dupont Review Date: 20180926 IETF LC End Date: 20181002 IESG Telechat date: unknown Summary: Ready Major issues: None Minor issues: None Nits/editorial comments: The yang model mixes config, state and actions, not like the others I know. But if the Yang experts have no concern I have none too... - 4 page 7: I notices the date of the model is 2018-06-30 when it was modified the 2018-08-31. I don't know the rule, perhaps the date is updated just before publication? Not an issue by itself. - action manual-switch-working page 30 and many others: please add a space before '{'. - A.1 page 46: the JSON is not valid (even it is readable) and I am afraid it is really JSON and not something JSON like. In detail: // does not begin comments in JSON (there are no comments in fact in JSON so IMHO it is not a real problem :-) extra commas (more an issue) - A.1 page 46: please add a space in "single":{ - same comments about A.2 pages 47 and 48, and A.3 pages 48-50 (with BTW two "single":{) - B page 50: Spain (ESP) -> Spain Regards Francis.Dupont@fdupont.fr
- [Gen-art] review of draft-ietf-ccamp-mw-yang-09.t… Francis Dupont
- Re: [Gen-art] review of draft-ietf-ccamp-mw-yang-… Jonas Ahlberg