Re: [Gen-art] Genart last call review of draft-ietf-ippm-rfc8889bis-02

Giuseppe Fioccola <giuseppe.fioccola@huawei.com> Thu, 30 June 2022 08:35 UTC

Return-Path: <giuseppe.fioccola@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7AB01C15AE27; Thu, 30 Jun 2022 01:35:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.907
X-Spam-Level:
X-Spam-Status: No, score=-1.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 601hSaIrMnTF; Thu, 30 Jun 2022 01:35:48 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1603BC15A73A; Thu, 30 Jun 2022 01:35:48 -0700 (PDT)
Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LYWnG3V7bz6H7g9; Thu, 30 Jun 2022 16:33:22 +0800 (CST)
Received: from fraeml714-chm.china.huawei.com (10.206.15.33) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 30 Jun 2022 10:35:45 +0200
Received: from fraeml714-chm.china.huawei.com ([10.206.15.33]) by fraeml714-chm.china.huawei.com ([10.206.15.33]) with mapi id 15.01.2375.024; Thu, 30 Jun 2022 10:35:45 +0200
From: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
To: Russ Housley <housley@vigilsec.com>
CC: IETF Gen-ART <gen-art@ietf.org>, "draft-ietf-ippm-rfc8889bis.all@ietf.org" <draft-ietf-ippm-rfc8889bis.all@ietf.org>, "ippm@ietf.org" <ippm@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-ippm-rfc8889bis-02
Thread-Index: AQHYi8EVl1F4LlFy2EG0+9dD5ILGWK1meb2wgAA8E4CAAOpJAA==
Date: Thu, 30 Jun 2022 08:35:45 +0000
Message-ID: <8134b6c06e3243c3b33da5a396751efa@huawei.com>
References: <165651143026.26585.5485702741745802901@ietfa.amsl.com> <f4fa115f0d3e4857aed207e2fbebafa1@huawei.com> <6208EE34-544F-44B1-8406-AE80F2DF8B7A@vigilsec.com>
In-Reply-To: <6208EE34-544F-44B1-8406-AE80F2DF8B7A@vigilsec.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.81.212.56]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/yUoj7qpcbuL8MVKauHKNHokuUFY>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ippm-rfc8889bis-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2022 08:35:49 -0000

Hi Russ,
Please see my reply inline tagged as [GF].

Thanks,

Giuseppe

-----Original Message-----
From: Russ Housley <housley@vigilsec.com> 
Sent: Wednesday, June 29, 2022 10:33 PM
To: Giuseppe Fioccola <giuseppe.fioccola@huawei.com>
Cc: IETF Gen-ART <gen-art@ietf.org>; draft-ietf-ippm-rfc8889bis.all@ietf.org; ippm@ietf.org; last-call@ietf.org
Subject: Re: Genart last call review of draft-ietf-ippm-rfc8889bis-02



> On Jun 29, 2022, at 11:57 AM, Giuseppe Fioccola <giuseppe.fioccola@huawei.com> wrote:
> 
> Dear Russ,
> Thank you for your review.
> I will revise the draft to address your comments.
> Please see my reply inline tagged as [GF].
> 
> Best Regards,
> 
> Giuseppe
> 
> 
> -----Original Message-----
> From: Russ Housley via Datatracker <noreply@ietf.org> 
> Sent: Wednesday, June 29, 2022 4:04 PM
> To: gen-art@ietf.org
> Cc: draft-ietf-ippm-rfc8889bis.all@ietf.org; ippm@ietf.org; last-call@ietf.org
> Subject: Genart last call review of draft-ietf-ippm-rfc8889bis-02
> 
> Reviewer: Russ Housley
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
> 
> For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ippm-rfc8889bis-02
> Reviewer: Russ Housley
> Review Date: 2022-06-29
> IETF LC End Date: 2022-06-21
> IESG Telechat date: 2022-07-14
> 
> 
> Summary: Ready with Nits
> 
> 
> Major Concerns: None
> 
> 
> Minor Concerns:
> 
> Section 8 says: "... can be incorporated into A, ..."
> I think that "A" is described in Figure 5, but it took me a few minutes to figure that out.  Please clarify.
> 
> [GF]: Sure, I will clarify that A is introduced in RFC8321bis and possibly refer to the Figure.
> 
> 
> Section 9 says:
> 
>   Either one or two flag bits might be available for marking in
>   different deployments:
> 
> This is followed by three labeled paragraphs.  Can this sentence be expanded to cover all three of the paragraphs that follow?
> 
> [GF]: Yes, I will highlight that three possibilities are possible.
> 
> 
> Nits:
> 
> Section 5.1: s/split our monitoring/split the monitoring/
> 
> [GF]: Ok
> 
> Section 5.1: s/In our monitoring network/In the monitoring network/
> 
> [GF]: Ok

All of the above look fine.

[GF]: Great. I will update the draft accordingly.

> 
> Section 5.1 says:
> 
>   The algorithm described above network is an iterative clustering
>   algorithm, but it is also possible to apply a recursive clustering
>   algorithm by using the node-node adjacency matrix representation
>   [IEEE-ACM-ToN-MPNPM].
> 
> I cannot understand is sentence.
> 
> [GF]: [IEEE-ACM-ToN-MPNPM] describes different algorithms (iterative and recursive) for cluster partition. In this document we only describe the iterative approach since it executes steps in iterations. While the recursive algorithm is detailed in the paper. I will reword this paragraph to make it clearer.

This is a grammar concern.  "The algorithm described above network is ..." does not parse.

[GF]: Ok, I will revise the sentence. The word "network" is not necessary.

Russ