Re: [Gen-art] Genart last call review of draft-ietf-calext-eventpub-extensions-12
Alissa Cooper <alissa@cooperw.in> Wed, 29 May 2019 20:59 UTC
Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C416D1201E2; Wed, 29 May 2019 13:59:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=M9Vh7yYz; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=JgsN1NFJ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKWEq_NDb0uX; Wed, 29 May 2019 13:59:29 -0700 (PDT)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0E6D6120096; Wed, 29 May 2019 13:59:26 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5872222375; Wed, 29 May 2019 16:59:25 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 29 May 2019 16:59:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=9 OcQxZMGUoFpIxRyVrgiknAw6BOo6rOT3+TPhGlkw8M=; b=M9Vh7yYztJwg3hgzh 7eyIfK54EI/Hwl1C8yZI5dMKR7ACpTPmSXxtkIsIiuu45FDG4Zwf/La+qAitIpzZ iApS8/wJ9kAcMryCnFKwFfHKYJ5xYJp8Jb+VHqX5Pmcza1/Fn6iyleo3EpXfT2o/ 1R2kiJvEIMaPsd+Iz83Kud5w/Yreem4hBICiyYddoQP7nFSL6KMETEJ0E5t8WEv0 y2oXlrBs6PFMdb8bCQzWEf3lj4m4LAvpUB7jY5nACRR1eJdy6gZuLmFinS/kk8qt q9Nb1G5oLwBVxBm90aJzbC1DMIoEaAnrd8r6+w2I4A+P4pT3gpv04A89YSwY4qPn qbjDw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9OcQxZMGUoFpIxRyVrgiknAw6BOo6rOT3+TPhGlkw 8M=; b=JgsN1NFJSmEU/s1SfN4JNRJp6+UA/9c61rXrd94n8m3Tlqz3l5rRsesKe IdFXuE4d8eJKquKPbizxJbj4aEi7bqcIQ0d02ybdT5b/SLnu/5z/mERoK0o3npB5 waxkFFVEwWhf8tThprpXlfPpJAnDdOaa2gAY+MyM38a9ptLXRrADfe1RvOE9xqSB g8A0pIRoz3Diocpn8KK4qEOaNu22R10gMCclAN4huf9s2uVHAWmr7tyBENOadTAo 0MEGgffp4MayLgxnrteJbfZQ62BvmH2TL90sAAzNhamqSw0KRi2daIgp3xD6jXrh ucy9yPIqcFwu4tQrWfWMMcjZc6LdA==
X-ME-Sender: <xms:rPLuXPr33c1CNQhmX7ypa2BIeFmjckgDlXIePqIXda7PBZF-BRCUaw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddvjedgudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeetlhhi shhsrgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomh grihhnpehivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrdekfeenucfrrghr rghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhush htvghrufhiiigvpedt
X-ME-Proxy: <xmx:rPLuXLJbZgARjeU5TRGqOqLrrgaATCeWqsarz5yAgyQHxM8c3Av7dQ> <xmx:rPLuXMSzJDuAst_2HannKKrmuhH2WzkEqaNEysKkRMmWiHPfNXm-mA> <xmx:rPLuXCv8ztxWNxkHa_IQ9JvrKoDbSvEsFg5fJSUIyG2w1lcGophv4w> <xmx:rfLuXL6prhrMzTgK68V3e6O0ikZ0TwHZDt5MVQkRbtxJ7PiPsIKh8g>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.83]) by mail.messagingengine.com (Postfix) with ESMTPA id 75CC380061; Wed, 29 May 2019 16:59:24 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <155644551863.20986.430303451434247977@ietfa.amsl.com>
Date: Wed, 29 May 2019 16:59:22 -0400
Cc: gen-art@ietf.org, draft-ietf-calext-eventpub-extensions.all@ietf.org, ietf@ietf.org, calsify@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <95DC1C99-63C4-4EF2-BE0D-061E168AAC73@cooperw.in>
References: <155644551863.20986.430303451434247977@ietfa.amsl.com>
To: Dan Romascanu <dromasca@gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/ymZfVIxsrcQxqwol5S0SN4Xkd78>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-calext-eventpub-extensions-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2019 20:59:32 -0000
Dan, thanks for your review. I entered a DISCUSS ballot on a couple of unrelated points and asked the authors to respond to you. Alissa > On Apr 28, 2019, at 5:58 AM, Dan Romascanu via Datatracker <noreply@ietf.org> wrote: > > Reviewer: Dan Romascanu > Review result: Ready with Issues > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-calext-eventpub-extensions-12 > Reviewer: Dan Romascanu > Review Date: 2019-04-28 > IETF LC End Date: 2019-04-29 > IESG Telechat date: Not scheduled for a telechat > > Summary: > > This is a clear and detailed document updating RFC 5545 to include new > properties and components to iCalendar. The document is READY for publication. > I found a number of minor issues as well as a few nits which should be > clarified and fixed in the further editing process. > > Major issues: > > Minor issues: > > 1. The document uses the term 'event' which has many meanings in many contexts. > It would be useful to include or reference a definition of what is meant by > 'event' in the context of iCalendar > > 2. The Abstract mentions that some of the updates are useful for social > networking. I could not find any support for this claim in the text, with the > exception mybe of mentioning 'social calendaring' in Section 3, which is also a > vague term (or at least I do not know where it is defined or referred in the > IETF). I suggest to either clarify, or drop these mentions. > > 3. In Section 3: > >> Using STRUCTURED-LOCATION, information about a number of interesting > locations can be communicated, for example, address, region, country, > > Isn't it rather 'supplementary information about the location' than > 'information about a number of interesting locations'? > > 4. Inconsistent use/non-use of keywords. > > In 5.2: > > 'This parameter MAY be specified on STRUCTURED-RESOURCE > and provides a way to differentiate multiple properties.' > > while in 5.5: > > 'This property parameter can be specified on any > property when the value is derived from some other property or > properties.' > > I suggest to decide on a consistent use of either MAY or 'can'. > > Nits/editorial comments: > > 1. In Section 2: > >> This is a > better match for the way [W3C.REC-xml-20081126] and JSON, [RFC8259] > handles such structures and allows richer definitions. > > Fix grammar (plural) > > 2. In the use cases in Section 3, there are many optional parameters, and the > use of conditional in the text may be more appropriate. > > For example in 3.1.1: > > 'In addition, there will be sponsorship information for > sponsors of the event' > > better > > 'In addition, there may be sponsorship information for > sponsors of the event' > > 3. In Section 3.1.2.1 > > s/A meeting may have 10 attendees non of which are co-located/A meeting may > have 10 attendees, none of which are co-located/ > > 4. I do not know if Appendix B will be kept, but in case it will be, there is a > typo in: > >> Fix PARTTYPE/PARTICPANT-TYPE inconsistency > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Genart last call review of draft-ietf-c… Dan Romascanu via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Alissa Cooper