Re: [Gen-art] Genart last call review of draft-ietf-lsr-isis-rfc5306bis-04

Russ Housley <housley@vigilsec.com> Fri, 16 August 2019 21:05 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD2881200C4 for <gen-art@ietfa.amsl.com>; Fri, 16 Aug 2019 14:05:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OcQXwFv1GelP for <gen-art@ietfa.amsl.com>; Fri, 16 Aug 2019 14:05:08 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28B0012007C for <gen-art@ietf.org>; Fri, 16 Aug 2019 14:05:08 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 333E9300B00 for <gen-art@ietf.org>; Fri, 16 Aug 2019 16:45:50 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OqUo_-boVipx for <gen-art@ietf.org>; Fri, 16 Aug 2019 16:45:48 -0400 (EDT)
Received: from a860b60074bd.fios-router.home (unknown [138.88.156.37]) by mail.smeinc.net (Postfix) with ESMTPSA id 416D330046F; Fri, 16 Aug 2019 16:45:48 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <BYAPR11MB3638E9D9F2CE8D0D9092DAE6C1AF0@BYAPR11MB3638.namprd11.prod.outlook.com>
Date: Fri, 16 Aug 2019 17:05:05 -0400
Cc: IETF Gen-ART <gen-art@ietf.org>, "draft-ietf-lsr-isis-rfc5306bis.all@ietf.org" <draft-ietf-lsr-isis-rfc5306bis.all@ietf.org>, IETF <ietf@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4C7AC8C9-4DA8-4E17-93EE-8628D368A5BB@vigilsec.com>
References: <156590505334.15902.14295595773952354164@ietfa.amsl.com> <BYAPR11MB3638E9D9F2CE8D0D9092DAE6C1AF0@BYAPR11MB3638.namprd11.prod.outlook.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zY8F8YJl04y61esD9W-KYIUnYqc>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lsr-isis-rfc5306bis-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Aug 2019 21:05:10 -0000

>> Nits:
>> 
>> Section 3.2.3: The lettered paragraphs at the top of the section
>> begin with lower case letters, but the lettered paragraphs at the
>> top of the section begin with upper case letters.  Please be
>> consistent.
>> 
> [Les:] Done

Cool.

>> Section 3.2.3: s/time after which the adjacency will now expire/
>>                /time after which the adjacency will expire/
>> 
> [Les:] I left this unchanged.  The text is identical to text in Section 3.2.1 regarding the RA bit. The point of using "now expire" is to emphasize that the expiration time has been adjusted as a result of the RR/PR request.
> Hope this is OK with you.

Sure.  That makes sense.

>> Section 3.2.3 says:
>> 
>>   ... It
>>   is therefore useful to signal a planned restart (if the forwarding
>>   plane on the restarting router is maintained) so that ...
>> 
>> I suggest:
>> 
>>   ... If
>>   the forwarding plane on the restarting router is maintained, it
>>   is useful to signal a planned restart so that ...
> 
> [Les:] I rewrote this paragraph. The term "restart" has been defined in Section 2 to be associated with a control plane restart which involves maintenance of the forwarding plane - so some of the text was redundant. 
> I hope the revised text is both more readable and more precise.

I just fetched the -05 version.  The revised paragraph looks good to me.

Russ