Re: [Gen-art] Gen-ART Review of draft-ietf-kitten-pkinit-freshness-07

Michiko Short <michikos@microsoft.com> Mon, 28 November 2016 16:59 UTC

Return-Path: <michikos@microsoft.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4493129EAC; Mon, 28 Nov 2016 08:59:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.022
X-Spam-Level:
X-Spam-Status: No, score=-2.022 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=microsoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e24ZR-IVTMN9; Mon, 28 Nov 2016 08:59:05 -0800 (PST)
Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0131.outbound.protection.outlook.com [104.47.40.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 987B2129E9A; Mon, 28 Nov 2016 08:59:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eptSXQayF3iiAGBuevFmtLbc+AMnls/3zEfiZOisZZU=; b=Fo9/MvItW9ZQc9o6j8hiYffiGY6ZgPsnLd/JmRxfVkk1Ry7UbQ9VG7p15jB6K8BEgPtUgBv3Paqf0zPm9vPkFgVw1uJBDvnMTBi7Od4iHnWWpNeRDzYQnomp0dL46gQH4KLpgMwGgzcB9ID5FdPJyxGpGF76M3fWp849dhHSlII=
Received: from CY1PR03MB2315.namprd03.prod.outlook.com (10.166.207.138) by CY1PR03MB2316.namprd03.prod.outlook.com (10.166.207.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.747.13; Mon, 28 Nov 2016 16:59:04 +0000
Received: from CY1PR03MB2315.namprd03.prod.outlook.com ([10.166.207.138]) by CY1PR03MB2315.namprd03.prod.outlook.com ([10.166.207.138]) with mapi id 15.01.0734.018; Mon, 28 Nov 2016 16:59:04 +0000
From: Michiko Short <michikos@microsoft.com>
To: Russ Housley <housley@vigilsec.com>, "draft-ietf-kitten-pkinit-freshness.all@ietf.org" <draft-ietf-kitten-pkinit-freshness.all@ietf.org>
Thread-Topic: Gen-ART Review of draft-ietf-kitten-pkinit-freshness-07
Thread-Index: AQHSSOilm69tVN+pU06lGGXZjXK2bKDunlrA
Date: Mon, 28 Nov 2016 16:59:03 +0000
Message-ID: <CY1PR03MB23155A8C6BEE7C1E24F5DCF1D08A0@CY1PR03MB2315.namprd03.prod.outlook.com>
References: <EE7359A5-ACD3-4CD1-B1B0-E01579203FFE@gmail.com> <0AD0BB5E-1539-4C38-99A4-B40AD4E9D9A1@vigilsec.com>
In-Reply-To: <0AD0BB5E-1539-4C38-99A4-B40AD4E9D9A1@vigilsec.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=michikos@microsoft.com;
x-originating-ip: [2001:4898:80e8:1::681]
x-ms-office365-filtering-correlation-id: b57fb878-66be-4c87-902a-08d417afdbcd
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY1PR03MB2316;
x-microsoft-exchange-diagnostics: 1; CY1PR03MB2316; 7:2YDA4EX9XEtHGm0dCamSXZoOzLTbntPwMDTpCvZnJpzNV4Mz5jdD03rOOmGy+DxUe5/Vj8WZsTVHdtuqoqo3F2+4gdrDR1nm632KaDPLAbrA1qXnSiia5oOzKlZwaWvryhwKc95n8zovAV2+0LcJo4Z8Zu/YEsBYB49Y74oe6UivwqTXI8W8qfNMvyLObYtvuGg4hKP3zTTXZ0fk4tXbwUarF39K9foaWAuRdhvSsbl/7s8JGNqakbf54hIDKrTWmm28GB6tqCqanF55BKmP5tKck8TGgMUTmNWTinvzTOsiRIC7LUXiPe6SWD6lW+NaY4Ggc3UaSQ1nzxeXJOANWb9EMaymfYytbB4twc7nxZqD+TtRKUIuVMibQDIfatWkHkXToOBu7WYwgRlzFPK7mnobYZSiRFuaUn5pOMDP2Ds6QLGwmHt22FxR4+bIyoGS4fu1kqB4jItvQQZGYtIHNH5hgtdZO0nSc18oUEVDyns=
x-microsoft-antispam-prvs: <CY1PR03MB2316A0F9C89A7EDF85DC78CCD08A0@CY1PR03MB2316.namprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6060326)(6040361)(6045199)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038)(6046074)(6041248)(6061324)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6047074)(6072148); SRVR:CY1PR03MB2316; BCL:0; PCL:0; RULEID:; SRVR:CY1PR03MB2316;
x-forefront-prvs: 01401330D1
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(377424004)(199003)(377454003)(189002)(13464003)(2501003)(77096006)(39410400001)(39400400001)(39450400002)(39380400001)(229853002)(68736007)(2950100002)(189998001)(10290500002)(74316002)(5005710100001)(86612001)(7696004)(97736004)(86362001)(4001150100001)(8990500004)(2906002)(5660300001)(4326007)(5001770100001)(101416001)(106356001)(3660700001)(76176999)(7736002)(54356999)(7846002)(105586002)(6116002)(102836003)(305945005)(50986999)(99286002)(10090500001)(38730400001)(122556002)(8936002)(2900100001)(9686002)(230783001)(8676002)(6506003)(81156014)(81166006)(106116001)(33656002)(76576001)(3280700002)(92566002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR03MB2316; H:CY1PR03MB2315.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2016 16:59:03.8398 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2316
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/z_Oe0j1LiLhAqozTDxMwKvndXdE>
Cc: IETF Gen-ART <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Review of draft-ietf-kitten-pkinit-freshness-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Nov 2016 16:59:08 -0000

The size issue a is big one for this late in the process as it never came up before. We would have to bring it up to the WG for discussion. Is this required? 

Happy to submit an updated version with the client & KDC flipped, first reference of KDC in abstract spelled out, and 2.1 PA_AS_FRESHNESS referencing 4. Just tell me when I can make the updates.

-----Original Message-----
From: Russ Housley [mailto:housley@vigilsec.com] 
Sent: Sunday, November 27, 2016 11:55 AM
To: draft-ietf-kitten-pkinit-freshness.all@ietf.org
Cc: IETF Gen-ART <gen-art@ietf.org>;
Subject: Gen-ART Review of draft-ietf-kitten-pkinit-freshness-07

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>;.

Document: draft-ietf-kitten-pkinit-freshness-07
Reviewer: Russ Housley
Review Date: 2016-11-27
IETF LC End Date: 2016-11-03
IESG Telechat date: 2016-12-01

Summary: Almost Ready

Major Concerns

I understand that freshness tokens provide corroboration that the client had access to the private key at the time that the AS-REQ was constructed.  I also understand that the freshness tokens do not have to be single use tokens for specific AS exchanges.  However, some guidance on the minimum size of the freshness token seems to be appropriate.  If the freshness token is too small, then the client could be generate signatures using all of the possible token values at when it does have access to the private key, offering the one that matches the freshness token during the exchange with the KDC.  Please specify a minimum size for the freshness token.

Please add a discussion of the minimum freshness token size to Section 7 (Security Considerations).

Question: Is there a reson to specify a maximum size for the freshness token?  If an implementor knows that the freshness token will be under some maximum, then the code can incorporate that information into the buffer management and easily discard any KRB-ERROR messages that exceed that maximum.


Minor Concerns

In the Abstract and Section 1 (Introduction), please spell out KDC the first time the acronym is used.

In Section 2.2 (Generation of KRB_ERROR Message), please give the reader a heads up that PA_AS_FRESHNESS is defined in this document.  I went looking for it in RFC 4120; a pointer could have avoided this wild goose chase.


Nits

In Figure 1, since the client begins the conversation, it would read better if the Client were on the left side of the figure.