[Gen-art] Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04

Christer Holmberg via Datatracker <noreply@ietf.org> Fri, 11 June 2021 07:58 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 95DB53A2DCF; Fri, 11 Jun 2021 00:58:42 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Christer Holmberg via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org, last-call@ietf.org, mpls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.31.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <162339832253.24163.8210945265296547396@ietfa.amsl.com>
Reply-To: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Fri, 11 Jun 2021 00:58:42 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zayJNOhwH1aA53cmY44IINORV-I>
Subject: [Gen-art] Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2021 07:58:43 -0000

Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
Reviewer: Christer Holmberg
Review Date: 2021-06-11
IETF LC End Date: 2021-06-21
IESG Telechat date: Not scheduled for a telechat

Summary: The document is easy to read, and is almost ready for publication.
However, I do have a few editorial comments that I would like the authors to
address.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:

Q1:

The Abstract and Introductions says:

   "This document proposes the code point to be used in the Segment ID
     Sub-TLV and Downstream Detailed Mapping TLV when the IGP is OSPFv3."

I suggest to say "specifies" or "defines" instead of "proposes".

Q2:

Would it be more clear to call Section 6 "Update to RFC 8287"?

Q3:

Section 6 says:

   "This document specifies that the above code points will be used only for
   OSPFv2."

I suggest to be more explicit, and say something like:

   "This document updates RFC 8287, by specifying that the "OSPF" code points
   will be used only for OSPFv2."

Q4:

Section 7.2 adds a note to the IANA registry for the existing "OSPF" code
point. Should this specification also be added as a reference for the existing
"OSPF" code point (in addition to RFC 8287?