[Gen-art] Re: Genart last call review of draft-ietf-httpbis-compression-dictionary-08

Patrick Meenan <patmeenan@gmail.com> Mon, 05 August 2024 17:46 UTC

Return-Path: <patmeenan@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 033D5C151538; Mon, 5 Aug 2024 10:46:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.863
X-Spam-Level:
X-Spam-Status: No, score=-0.863 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NORMAL_HTTP_TO_IP=0.001, NUMERIC_HTTP_ADDR=1.242, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9xxrxCMZ-n8E; Mon, 5 Aug 2024 10:46:12 -0700 (PDT)
Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C42CC151066; Mon, 5 Aug 2024 10:46:09 -0700 (PDT)
Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5b391c8abd7so10789328a12.2; Mon, 05 Aug 2024 10:46:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722879967; x=1723484767; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FoDk+6hkOW0q4Vd6XyQtSFZBukhhFgStMFFfHpIXrVw=; b=iLIV0OPeh0zMQx7zRWguj9HFo01SCt+CT7gypndDV1FiNQi/P+ysnj1cxOGg68h1oN JwIARV3EctdeMtRci6FzV/RI60pC+2ESVHgZKZ5Z5y37V12xfvidBnyvmZbU+edeyvXO 1Op58pzpszjEIlkg5VrvbrT91XKB0QmR+AgbOfiUHCrIiBPEOdVs9hZyahmu/RDu69xq qIRvz/hABh1xcAVnVLsBfBs9WK3BcygFNKsoHP09B8Kli0U+tfp1dpca6attgcoC/Nqj SPzOijKigbhrSDv+vDr2lLw4jMdzpXqe4w4nOCHZD6GrWVQqlWnNqb/W3BqOib3jqdTn iwhw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722879967; x=1723484767; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FoDk+6hkOW0q4Vd6XyQtSFZBukhhFgStMFFfHpIXrVw=; b=sRo395SFfNFqkw4Fx5ucpZpuSduvYYopQsE93YAb9tIzGv2znII9ua7z2TbXJHZK8v aj6Qym3phos+QJPb3ju3CckdKkN3sFpjH+HspTfIKTwOSXIbCTeJG36Rdhm72I3HwO9r NCr7rjGw949a+kGC6E2PP5kaNltGMDH2sBFASiTTe+hHnMOlXAAJP4MhgwC/VI1nKh1w YtErUTsghCwmKiZl5TQR5LJRMmtGGV2ZX2dWqvkJ1XgNpOqRH/tsaWv27c/1dGjcgGu1 qG8C195e2dzp8vUdJH0+PKRxtXj6eXTG4Luk8DFEDpTM+Tqr4/iNTKd/aBDj4HNOHGpX 6QKA==
X-Forwarded-Encrypted: i=1; AJvYcCXwmrFfDKnWIe7hZE5sHKV6nsSvN/zGC0XMsATMMY6mCKcLerUQ8ti6Ny1fGorjozkFUcUbiCfK0im2BTXLrlcZ/Ma7PROODapcLl8KFZwGr7pQz4IZPyv35HUGrsVBUQ8JJYYqzlmfiW6EVsRMD/toBoJt4AjRSNUUnw==
X-Gm-Message-State: AOJu0Yxc5etgnKu2242EPNqFZr1+ilwexadf9LKHI1UoIFNfydOIqKSl z+0OWSNfNEWL8PzxH7xgY9G18kt7p5aip2CaVu+vSktWWyUBzsFt+8sv2LdjnO9mMujX1+ny3Ll P4VGZr5Url6fIjONqRIlyZFWjeI8=
X-Google-Smtp-Source: AGHT+IGrMbUx5BgIOmAEWL19GTDBag0LwFx0U7YYYrqwllR0dWhr7DjZAN9IvNBwObCexDitlwu42SuoR1tk8S0rvWE=
X-Received: by 2002:a17:907:2d08:b0:a7d:a031:7bb2 with SMTP id a640c23a62f3a-a7dc4fa2265mr825627266b.40.1722879966895; Mon, 05 Aug 2024 10:46:06 -0700 (PDT)
MIME-Version: 1.0
References: <172287502811.658486.5801714086488550365@dt-datatracker-6dd76c4557-2mkrj>
In-Reply-To: <172287502811.658486.5801714086488550365@dt-datatracker-6dd76c4557-2mkrj>
From: Patrick Meenan <patmeenan@gmail.com>
Date: Mon, 05 Aug 2024 13:45:54 -0400
Message-ID: <CAJV+MGxv-O2zRhgJjF9GH=0rnbsB3JoemeLM3rZ-+G=XbmpXzA@mail.gmail.com>
To: Reese Enghardt <ietf@tenghardt.net>
Content-Type: multipart/alternative; boundary="0000000000006ae547061ef34042"
Message-ID-Hash: XBV75YGEDNPDAV6PVQDWFECIXRERVX67
X-Message-ID-Hash: XBV75YGEDNPDAV6PVQDWFECIXRERVX67
X-MailFrom: patmeenan@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-gen-art.ietf.org-0; header-match-gen-art.ietf.org-1; header-match-gen-art.ietf.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: gen-art@ietf.org, draft-ietf-httpbis-compression-dictionary.all@ietf.org, ietf-http-wg@w3.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Gen-art] Re: Genart last call review of draft-ietf-httpbis-compression-dictionary-08
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zgAXQvBwWbAuby10JeKp9lKPpE8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Owner: <mailto:gen-art-owner@ietf.org>
List-Post: <mailto:gen-art@ietf.org>
List-Subscribe: <mailto:gen-art-join@ietf.org>
List-Unsubscribe: <mailto:gen-art-leave@ietf.org>

Thank you. draft-09 has been released with the suggested updates:
https://datatracker.ietf.org/doc/draft-ietf-httpbis-compression-dictionary/09/

Mostly some added explanations but good catch on the one-year expiration.
That was leftover from earlier drafts when the dictionaries had
expiration independent of the HTTP caching and shouldn't have been there
(and has been removed).

On Mon, Aug 5, 2024 at 12:28 PM Reese Enghardt via Datatracker <
noreply@ietf.org> wrote:

> Reviewer: Reese Enghardt
> Review result: Ready with Nits
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
>
> Document: draft-ietf-httpbis-compression-dictionary-08
> Reviewer: Reese Enghardt
> Review Date: 2024-08-05
> IETF LC End Date: 2024-08-06
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: The document is concise and to the point. I just have a few
> suggestions for clarifications.
>
> Major issues: None.
>
> Minor issues:
>
> Section 1:
>
> What is the motivation for this work? Increased efficiency relative to
> other
> compression schemas, or is there more to it? Please consider adding a
> sentence
> or two.
>
> What versions of HTTP does this document apply to? I might have missed
> something that makes it so that a statement of versioning is not needed.
> But
> otherwise, please consider adding a statement about this.
>
> Section 2.1.1:
>
> "The following algorithm will return TRUE for a valid match pattern and
> FALSE
> for an invalid pattern that MUST NOT be used"
>
> Please consider adding one sentence of motivation or clarification for the
> algorithm - IIUC it enforces the Same Origin Policy. I think explaining
> this
> motivation briefly here would make the algorithm easier to follow.
>
> Section 2.1.5.2:
>
> "Would match main.js in any directory under /app/ and expiring as a
> dictionary
> in one year."
>
> This is the first time the document mentions expiration as a concept. How
> is
> expiration specified in this example - I don't see it specified
> explicitly, so
> is one year the default? Please consider adding a clarification.
>
> Nits/editorial comments: None.
>
>
>
>