[Gen-art] Genart last call review of draft-ietf-lamps-pkix-shake-08

Joel Halpern via Datatracker <noreply@ietf.org> Sat, 30 March 2019 09:55 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 0563C12015F; Sat, 30 Mar 2019 02:55:23 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joel Halpern via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: spasm@ietf.org, ietf@ietf.org, draft-ietf-lamps-pkix-shake.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.94.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Joel Halpern <jmh@joelhalpern.com>
Message-ID: <155393972295.3950.3582710869606616692@ietfa.amsl.com>
Date: Sat, 30 Mar 2019 02:55:23 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zmLwjR-lYIBRVCiEnNMq-TW8drU>
Subject: [Gen-art] Genart last call review of draft-ietf-lamps-pkix-shake-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Mar 2019 09:55:23 -0000

Reviewer: Joel Halpern
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-pkix-shake-08
Reviewer: Joel Halpern
Review Date: 2019-03-30
IETF LC End Date: 2019-04-10
IESG Telechat date: Not scheduled for a telechat

Summary: This document is almost ready for publication as a Proposed Standard

Major issues:
    One of the key points of this RFC seems to be to assign the identifiers for
    the use of the two SHAKE variants.  It is thus confusing that the
    identifiers end with "TBD", and thus are not defined in this document.

Minor issues:
    The algorithm identifiers are label as TVD.  There are at least two values
    (one for SHAKE128 and one for SHAKE256) with each used in two context
    (RSASSA-PSS and ECDSA).  It would be helpful if the two (or four)
    identifiers were labeled clearly TBD1 and TBD2 (and possibly TBD3 and TBD4).

Nits/editorial comments:
    There is one use of "SHAKES" as the plural of SHAKE in section 5.1.1.  All
    other uses are "SHAKEs", which seems to be correct.