Re: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07

"Yemin (Amy)" <amy.yemin@huawei.com> Mon, 17 October 2016 08:06 UTC

Return-Path: <amy.yemin@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 034DB1295B9; Mon, 17 Oct 2016 01:06:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.652
X-Spam-Level:
X-Spam-Status: No, score=-4.652 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.431, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3cjxnQqQdmiM; Mon, 17 Oct 2016 01:06:53 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BEB7812959F; Mon, 17 Oct 2016 01:06:52 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml704-cah.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CTH54841; Mon, 17 Oct 2016 08:06:50 +0000 (GMT)
Received: from SZXEMA418-HUB.china.huawei.com (10.82.72.36) by lhreml704-cah.china.huawei.com (10.201.5.130) with Microsoft SMTP Server (TLS) id 14.3.235.1; Mon, 17 Oct 2016 09:06:48 +0100
Received: from SZXEMA506-MBS.china.huawei.com ([169.254.4.3]) by SZXEMA418-HUB.china.huawei.com ([10.82.72.36]) with mapi id 14.03.0235.001; Mon, 17 Oct 2016 16:06:41 +0800
From: "Yemin (Amy)" <amy.yemin@huawei.com>
To: "jouni.nospam" <jouni.nospam@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
Thread-Index: AQHSJ/dY4MFemu11Hk2GnlCFVssZVqCr9flw
Date: Mon, 17 Oct 2016 08:06:41 +0000
Message-ID: <9C5FD3EFA72E1740A3D41BADDE0B461F9CE1F3DA@szxema506-mbs.china.huawei.com>
References: <499E4913-F08F-439A-82CA-68F91F507E5D@gmail.com>
In-Reply-To: <499E4913-F08F-439A-82CA-68F91F507E5D@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.169.31.176]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.5804869A.015C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.4.3, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 31575fef552c88e53d84bc250357a6fa
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/zwuO1IXSEDB3U-FxGtUpA17kCsY>
Cc: "draft-ietf-ccamp-ospf-availability-extension.all@ietf.org" <draft-ietf-ccamp-ospf-availability-extension.all@ietf.org>
Subject: Re: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Oct 2016 08:06:55 -0000

Hi Jouni,

Thanks very much for the comments. I fixed the nits in the draft. 

Regarding the Switching Capability-specific information field, we had the discussion in WG, and here's the summary/conclusion:
It's decided that this document will just define the availability TLV, and a new draft will define its technology specific usage.  
For example, for the SCSI which supports TLV(e.g., OTN/WSON), a new type code is needed to make use of availability TLV. 
For the SCSI who doesn’t support TLV(e.g., PSC), a new SC types is needed. 

BR,
Amy

-----Original Message-----
From: jouni.nospam [mailto:jouni.nospam@gmail.com] 
Sent: Monday, October 17, 2016 5:50 AM
To: gen-art@ietf.org
Cc: draft-ietf-ccamp-ospf-availability-extension.all@ietf.org
Subject: Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-ccamp-ospf-availability-extension-07
Reviewer: Jouni Korhonen
Review Date:        2016-10-16
IETF LC End Date:   2016-10-24
IESG Telechat date: 2016-11-03

Summary:

Document is ready with nits.

Major issues:

None.

Minor issues:

It is not clear to me how the ISCD Availability sub-TLV is encoded into RFC4203 Switching Capability-specific information field. This is because RFC4203 lists specific encodings depending on “Switching Cap” field and those encoded information fields seem not to be TLVs. I would like to see some text that deals with switching cap, its relation to the TLV described in this document and the coexistence with existing capability specific information fields described in RFC4203. If I did not understand something regarding the encoding that is supposed to be trivial I am happy to told that ;)

Nits/editorial comments:

o Line 21: ISCD is not expanded.
o Line 142: unnecessary extra space in "a < availability”.
o Line 150: Space needed before the reference "protocol[ETPAI].”
o Line 142-.. TE is never expanded or part of the list acronyms.
o Lines 176-178: formatting issue with indentation, line spacing  and
  line endings (not a fullstop but ‘;’).
o Line 162: TLV is never expanded or  part of the list acronyms.

__________________________________________